VersionListener::onKernelRequest() - Code Metrics - Inspection of "Merge branch '2.x'" - FriendsOfSymfony/FOSRestBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 67823f...9d8d5a )

by Christian

created 2020-03-18 18:11 UTC

VersionListener::onKernelRequest() B

↳ Parent: VersionListener

Complexity

Conditions	10
Paths	9

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	10.3638

Importance

Changes

Metric	Value
dl	0
loc	25
ccs	11
cts	13
cp	0.8462
rs	7.6666
c	0
b	0
f	0
cc	10
nc	9
nop	1
crap	10.3638

How to fix Complexity

<?php

/*
 * This file is part of the FOSRestBundle package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\RestBundle\EventListener;

use FOS\RestBundle\FOSRestBundle;
use FOS\RestBundle\Version\ChainVersionResolver;
use FOS\RestBundle\Version\VersionResolverInterface;
use Symfony\Component\HttpKernel\Event\RequestEvent;

/**
 * @internal
 */
class VersionListener
{
    private $versionResolver;
    private $defaultVersion;

    public function __construct(VersionResolverInterface $versionResolver, $defaultVersion = null)
    {
        $this->versionResolver = $versionResolver;
        $this->defaultVersion = $defaultVersion;
    }

    /**
     * @param RequestEvent $event
     */
    public function onKernelRequest($event)
    {
        $request = $event->getRequest();

        if (!$request->attributes->get(FOSRestBundle::ZONE_ATTRIBUTE, true)) {
            return;
        }

        $version = $this->versionResolver->resolve($request);

        if (!$this->versionResolver instanceof ChainVersionResolver && null !== $version && !is_string($version)) {
            @trigger_error(sprintf('Not returning a string or null from %s::resolve() when implementing the %s is deprecated since FOSRestBundle 2.8.', get_class($this->versionResolver), VersionResolverInterface::class), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }

        if ((false === $version || null === $version) && null !== $this->defaultVersion) {
            $version = $this->defaultVersion;
        }

        // Return if nothing to do
        if (false === $version || null === $version) {
            return;
        }

        $request->attributes->set('version', $version);
    }
}


1		<?php
2
3		/*
4		* This file is part of the FOSRestBundle package.
5		*
6		* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace FOS\RestBundle\EventListener;
13
14		use FOS\RestBundle\FOSRestBundle;
15		use FOS\RestBundle\Version\ChainVersionResolver;
16		use FOS\RestBundle\Version\VersionResolverInterface;
17		use Symfony\Component\HttpKernel\Event\RequestEvent;
18
19		/**
20		* @internal
21		*/
22		class VersionListener
23		{
24		private $versionResolver;
25		private $defaultVersion;
26
27	8	public function __construct(VersionResolverInterface $versionResolver, $defaultVersion = null)
28		{
29	8	$this->versionResolver = $versionResolver;
30	8	$this->defaultVersion = $defaultVersion;
31	8	}
32
33		/**
34		* @param RequestEvent $event
35		*/
36	8	public function onKernelRequest($event)
37		{
38	8	$request = $event->getRequest();
39
40	8	if (!$request->attributes->get(FOSRestBundle::ZONE_ATTRIBUTE, true)) {
41	1	return;
42		}
43
44	7	$version = $this->versionResolver->resolve($request);
45
46	7	if (!$this->versionResolver instanceof ChainVersionResolver && null !== $version && !is_string($version)) {
47		@trigger_error(sprintf('Not returning a string or null from %s::resolve() when implementing the %s is deprecated since FOSRestBundle 2.8.', get_class($this->versionResolver), VersionResolverInterface::class), E_USER_DEPRECATED);
		0 ignored issues – show Security Best Practice introduced 2020-03-17 19:53 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
48		}
49
50	7	if ((false === $version \|\| null === $version) && null !== $this->defaultVersion) {
51	3	$version = $this->defaultVersion;
52		}
53
54		// Return if nothing to do
55	7	if (false === $version \|\| null === $version) {
56		return;
57		}
58
59	7	$request->attributes->set('version', $version);
60	7	}
61		}
62

FriendsOfSymfony / FOSRestBundle

Push — master ( 67823f...9d8d5a )

VersionListener::onKernelRequest() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like