Completed
Pull Request — 2.x (#2227)
by
unknown
08:36
created

RequestBodyParamConverter::__construct()   A

Complexity

Conditions 5
Paths 8

Size

Total Lines 24

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 7
CRAP Score 5.0488

Importance

Changes 0
Metric Value
dl 0
loc 24
ccs 7
cts 8
cp 0.875
rs 9.2248
c 0
b 0
f 0
cc 5
nc 8
nop 5
crap 5.0488
1
<?php
2
3
/*
4
 * This file is part of the FOSRestBundle package.
5
 *
6
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace FOS\RestBundle\Request;
13
14
use FOS\RestBundle\Context\Context;
15
use FOS\RestBundle\Serializer\Serializer;
16
use JMS\Serializer\Exception\Exception as JMSSerializerException;
17
use JMS\Serializer\Exception\UnsupportedFormatException;
18
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
19
use Sensio\Bundle\FrameworkExtraBundle\Request\ParamConverter\ParamConverterInterface;
20
use Symfony\Component\HttpFoundation\Request;
21
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
22
use Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException;
23
use Symfony\Component\OptionsResolver\OptionsResolver;
24
use Symfony\Component\Serializer\Exception\ExceptionInterface as SymfonySerializerException;
25
use Symfony\Component\Validator\Validator\ValidatorInterface;
26
27
/**
28
 * @author Tyler Stroud <[email protected]>
29
 */
30
final class RequestBodyParamConverter implements ParamConverterInterface
31
{
32
    private $serializer;
33
    private $context = [];
34
    private $validator;
35
    private $validationErrorsArgument;
36
37
    /**
38
     * @param string[]|null $groups
39
     */
40
    public function __construct(
41
        Serializer $serializer,
42
        ?array $groups = null,
43
        ?string $version = null,
44
        ValidatorInterface $validator = null,
45 18
        ?string $validationErrorsArgument = null
46
    ) {
47
        $this->serializer = $serializer;
48
49
        if (!empty($groups)) {
50
            $this->context['groups'] = (array) $groups;
51
        }
52 18
53
        if (!empty($version)) {
54 18
            $this->context['version'] = $version;
55 1
        }
56
57
        if (null !== $validator && null === $validationErrorsArgument) {
58 18
            throw new \InvalidArgumentException('"$validationErrorsArgument" cannot be null when using the validator');
59 1
        }
60
61
        $this->validator = $validator;
62 18
        $this->validationErrorsArgument = $validationErrorsArgument;
63
    }
64
65
    /**
66 18
     * {@inheritdoc}
67 18
     */
68 18
    public function apply(Request $request, ParamConverter $configuration): bool
69
    {
70
        $options = (array) $configuration->getOptions();
71
72
        if (isset($options['deserializationContext']) && is_array($options['deserializationContext'])) {
73 9
            $arrayContext = array_merge($this->context, $options['deserializationContext']);
74
        } else {
75 9
            $arrayContext = $this->context;
76
        }
77 9
        $this->configureContext($context = new Context(), $arrayContext);
78 1
79
        try {
80 8
            $object = $this->serializer->deserialize(
81
                $request->getContent(),
0 ignored issues
show
Bug introduced by
It seems like $request->getContent() targeting Symfony\Component\HttpFo...n\Request::getContent() can also be of type resource; however, FOS\RestBundle\Serialize...rializer::deserialize() does only seem to accept string, maybe add an additional type check?

This check looks at variables that are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
82 9
                $configuration->getClass(),
83
                $request->getContentType(),
84
                $context
85 9
            );
86 9
        } catch (UnsupportedFormatException $e) {
87 9
            return $this->throwException(new UnsupportedMediaTypeHttpException($e->getMessage(), $e), $configuration);
88 9
        } catch (JMSSerializerException $e) {
89
            return $this->throwException(new BadRequestHttpException($e->getMessage(), $e), $configuration);
90
        } catch (SymfonySerializerException $e) {
91 3
            return $this->throwException(new BadRequestHttpException($e->getMessage(), $e), $configuration);
92
        }
93 3
94 1
        $request->attributes->set($configuration->getName(), $object);
95 2
96 1
        if (null !== $this->validator && (!isset($options['validate']) || $options['validate'])) {
97
            $validatorOptions = $this->getValidatorOptions($options);
98
99 6
            $errors = $this->validator->validate($object, null, $validatorOptions['groups']);
100
101 6
            $request->attributes->set(
102 1
                $this->validationErrorsArgument,
103
                $errors
104 1
            );
105
        }
106 1
107 1
        return true;
108
    }
109
110
    /**
111
     * {@inheritdoc}
112 6
     */
113
    public function supports(ParamConverter $configuration): bool
114
    {
115
        return null !== $configuration->getClass() && 'fos_rest.request_body' === $configuration->getConverter();
116
    }
117
118 5
    private function configureContext(Context $context, array $options): void
119
    {
120 5
        foreach ($options as $key => $value) {
121
            if ('groups' === $key) {
122
                $context->addGroups($options['groups']);
123 11
            } elseif ('version' === $key) {
124
                $context->setVersion($options['version']);
125 11
            } elseif ('enableMaxDepth' === $key) {
126 3
                $context->enableMaxDepth($options['enableMaxDepth']);
0 ignored issues
show
Unused Code introduced by
The call to Context::enableMaxDepth() has too many arguments starting with $options['enableMaxDepth'].

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
127 2
            } elseif ('serializeNull' === $key) {
128 3
                $context->setSerializeNull($options['serializeNull']);
129 2
            } else {
130 3
                $context->setAttribute($key, $value);
131 1
            }
132 1
        }
133 2
    }
134 1
135 2
    private function throwException(\Exception $exception, ParamConverter $configuration): bool
136 1
    {
137
        if ($configuration->isOptional()) {
138 2
            return false;
139
        }
140
141 11
        throw $exception;
142
    }
143 2
144
    private function getValidatorOptions(array $options): array
145 2
    {
146
        $resolver = new OptionsResolver();
147
        $resolver->setDefaults([
148
            'groups' => null,
149 2
            'traverse' => false,
150
            'deep' => false,
151
        ]);
152 2
153
        return $resolver->resolve(isset($options['validator']) ? $options['validator'] : []);
154 2
    }
155
}
156