FriendsOfSymfony /
FOSRestBundle
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like FOSRestExtension often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use FOSRestExtension, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class FOSRestExtension extends Extension |
||
| 24 | { |
||
| 25 | /** |
||
| 26 | * Loads the services based on your application configuration. |
||
| 27 | * |
||
| 28 | * @param array $configs |
||
| 29 | * @param ContainerBuilder $container |
||
| 30 | * |
||
| 31 | * @throws \InvalidArgumentException |
||
| 32 | * @throws \LogicException |
||
| 33 | */ |
||
| 34 | 47 | public function load(array $configs, ContainerBuilder $container) |
|
| 35 | { |
||
| 36 | 47 | $config = $this->processConfiguration(new Configuration(), $configs); |
|
| 37 | |||
| 38 | 42 | $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config')); |
|
| 39 | 42 | $loader->load('view.xml'); |
|
| 40 | 42 | $loader->load('routing.xml'); |
|
| 41 | 42 | $loader->load('request.xml'); |
|
| 42 | 42 | $loader->load('serializer.xml'); |
|
| 43 | |||
| 44 | 42 | $container->getDefinition('fos_rest.routing.loader.controller')->replaceArgument(4, $config['routing_loader']['default_format']); |
|
| 45 | 42 | $container->getDefinition('fos_rest.routing.loader.yaml_collection')->replaceArgument(4, $config['routing_loader']['default_format']); |
|
| 46 | 42 | $container->getDefinition('fos_rest.routing.loader.xml_collection')->replaceArgument(4, $config['routing_loader']['default_format']); |
|
| 47 | |||
| 48 | 42 | $container->getDefinition('fos_rest.routing.loader.yaml_collection')->replaceArgument(2, $config['routing_loader']['include_format']); |
|
| 49 | 42 | $container->getDefinition('fos_rest.routing.loader.xml_collection')->replaceArgument(2, $config['routing_loader']['include_format']); |
|
| 50 | 42 | $container->getDefinition('fos_rest.routing.loader.reader.action')->replaceArgument(3, $config['routing_loader']['include_format']); |
|
| 51 | |||
| 52 | // The validator service alias is only set if validation is enabled for the request body converter |
||
| 53 | 42 | $validator = $config['service']['validator']; |
|
| 54 | 42 | unset($config['service']['validator']); |
|
| 55 | |||
| 56 | 42 | foreach ($config['service'] as $key => $service) { |
|
| 57 | 42 | if (null !== $service) { |
|
| 58 | 42 | $container->setAlias('fos_rest.'.$key, $service); |
|
| 59 | 42 | } |
|
| 60 | 42 | } |
|
| 61 | |||
| 62 | 42 | $this->loadForm($config, $loader, $container); |
|
| 63 | 42 | $this->loadException($config, $loader, $container); |
|
| 64 | 40 | $this->loadBodyConverter($config, $validator, $loader, $container); |
|
| 65 | 40 | $this->loadView($config, $loader, $container); |
|
| 66 | |||
| 67 | 40 | $this->loadBodyListener($config, $loader, $container); |
|
| 68 | 40 | $this->loadFormatListener($config, $loader, $container); |
|
| 69 | 40 | $this->loadVersioning($config, $loader, $container); |
|
| 70 | 40 | $this->loadParamFetcherListener($config, $loader, $container); |
|
| 71 | 40 | $this->loadAllowedMethodsListener($config, $loader, $container); |
|
| 72 | 40 | $this->loadAccessDeniedListener($config, $loader, $container); |
|
| 73 | 40 | $this->loadZoneMatcherListener($config, $loader, $container); |
|
| 74 | |||
| 75 | // Needs RequestBodyParamConverter and View Handler loaded. |
||
| 76 | 40 | $this->loadSerializer($config, $container); |
|
| 77 | 40 | } |
|
| 78 | |||
| 79 | 42 | private function loadForm(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 86 | |||
| 87 | 40 | private function loadAccessDeniedListener(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 102 | |||
| 103 | 40 | View Code Duplication | private function loadAllowedMethodsListener(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
| 116 | |||
| 117 | 40 | private function loadBodyListener(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 142 | |||
| 143 | 40 | private function loadFormatListener(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 144 | { |
||
| 145 | 40 | if ($config['format_listener']['enabled'] && !empty($config['format_listener']['rules'])) { |
|
| 146 | 5 | $loader->load('format_listener.xml'); |
|
| 147 | |||
| 148 | 5 | if (!empty($config['format_listener']['service'])) { |
|
| 149 | $service = $container->getDefinition('fos_rest.format_listener'); |
||
| 150 | $service->clearTag('kernel.event_listener'); |
||
| 151 | } |
||
| 152 | |||
| 153 | 5 | $container->setParameter( |
|
| 154 | 5 | 'fos_rest.format_listener.rules', |
|
| 155 | 5 | $config['format_listener']['rules'] |
|
| 156 | 5 | ); |
|
| 157 | |||
| 158 | 5 | if ($config['view']['mime_types']['enabled'] && !method_exists(Request::class, 'getMimeTypes')) { |
|
| 159 | 2 | $container->getDefinition('fos_rest.format_negotiator')->addArgument($config['view']['mime_types']['formats']); |
|
| 160 | 2 | } |
|
| 161 | 5 | } |
|
| 162 | 40 | } |
|
| 163 | |||
| 164 | 40 | private function loadVersioning(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 165 | { |
||
| 166 | 40 | if (!empty($config['versioning']['enabled'])) { |
|
| 167 | 2 | $loader->load('versioning.xml'); |
|
| 168 | |||
| 169 | 2 | $versionListener = $container->getDefinition('fos_rest.versioning.listener'); |
|
| 170 | 2 | $versionListener->replaceArgument(2, $config['versioning']['default_version']); |
|
| 171 | |||
| 172 | 2 | $resolvers = []; |
|
| 173 | 2 | View Code Duplication | if ($config['versioning']['resolvers']['query']['enabled']) { |
| 174 | 2 | $resolvers['query'] = $container->getDefinition('fos_rest.versioning.query_parameter_resolver'); |
|
| 175 | 2 | $resolvers['query']->replaceArgument(0, $config['versioning']['resolvers']['query']['parameter_name']); |
|
| 176 | 2 | } |
|
| 177 | 2 | View Code Duplication | if ($config['versioning']['resolvers']['custom_header']['enabled']) { |
| 178 | 2 | $resolvers['custom_header'] = $container->getDefinition('fos_rest.versioning.header_resolver'); |
|
| 179 | 2 | $resolvers['custom_header']->replaceArgument(0, $config['versioning']['resolvers']['custom_header']['header_name']); |
|
| 180 | 2 | } |
|
| 181 | 2 | View Code Duplication | if ($config['versioning']['resolvers']['media_type']['enabled']) { |
| 182 | 2 | $resolvers['media_type'] = $container->getDefinition('fos_rest.versioning.media_type_resolver'); |
|
| 183 | 2 | $resolvers['media_type']->replaceArgument(0, $config['versioning']['resolvers']['media_type']['regex']); |
|
| 184 | 2 | } |
|
| 185 | |||
| 186 | 2 | $chainResolver = $container->getDefinition('fos_rest.versioning.chain_resolver'); |
|
| 187 | 2 | foreach ($config['versioning']['guessing_order'] as $resolver) { |
|
| 188 | 2 | if (isset($resolvers[$resolver])) { |
|
| 189 | 2 | $chainResolver->addMethodCall('addResolver', [$resolvers[$resolver]]); |
|
| 190 | 2 | } |
|
| 191 | 2 | } |
|
| 192 | 2 | } |
|
| 193 | 40 | } |
|
| 194 | |||
| 195 | 40 | View Code Duplication | private function loadParamFetcherListener(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
| 196 | { |
||
| 197 | 40 | if ($config['param_fetcher_listener']['enabled']) { |
|
| 198 | 4 | $loader->load('param_fetcher_listener.xml'); |
|
| 199 | |||
| 200 | 4 | if (!empty($config['param_fetcher_listener']['service'])) { |
|
| 201 | $service = $container->getDefinition('fos_rest.param_fetcher_listener'); |
||
| 202 | $service->clearTag('kernel.event_listener'); |
||
| 203 | } |
||
| 204 | |||
| 205 | 4 | if ($config['param_fetcher_listener']['force']) { |
|
| 206 | 1 | $container->getDefinition('fos_rest.param_fetcher_listener')->replaceArgument(1, true); |
|
| 207 | 1 | } |
|
| 208 | 4 | } |
|
| 209 | 40 | } |
|
| 210 | |||
| 211 | 40 | private function loadBodyConverter(array $config, $validator, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 229 | |||
| 230 | 40 | private function loadView(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 308 | |||
| 309 | 42 | private function loadException(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 310 | { |
||
| 311 | 42 | if ($config['exception']['enabled']) { |
|
| 343 | |||
| 344 | 40 | private function loadSerializer(array $config, ContainerBuilder $container) |
|
| 365 | |||
| 366 | 40 | private function loadZoneMatcherListener(array $config, XmlFileLoader $loader, ContainerBuilder $container) |
|
| 384 | |||
| 385 | 1 | private function createZoneRequestMatcher(ContainerBuilder $container, $path = null, $host = null, $methods = array(), $ip = null) |
|
| 407 | |||
| 408 | /** |
||
| 409 | * Checks if an exception is loadable. |
||
| 410 | * |
||
| 411 | * @param string $exception Class to test |
||
| 412 | * |
||
| 413 | * @throws \InvalidArgumentException if the class was not found. |
||
| 414 | */ |
||
| 415 | 6 | private function testExceptionExists($exception) |
|
| 421 | } |
||
| 422 |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.