FOS\RestBundle\Serializer\Normalizer\FormErrorHandler

Complexity

Total Complexity

14

Size/Duplication

Total Lines	90
Duplicated Lines	27.78 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

79.63%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	serializeFormToXml()	3	29	4
A	serializeFormToJson()	11	11	2
A	serializeFormToYml()	11	11	2
A	adaptFormArray()	0	13	2
A	getStatusCode()	0	11	3

<?php

/*
 * This file is part of the FOSRestBundle package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\RestBundle\Serializer\Normalizer;

use JMS\Serializer\Context;
use JMS\Serializer\Handler\FormErrorHandler as JMSFormErrorHandler;
use JMS\Serializer\JsonSerializationVisitor;
use JMS\Serializer\XmlSerializationVisitor;
use Symfony\Component\Form\Form;
use JMS\Serializer\YamlSerializationVisitor;
use Symfony\Component\Translation\TranslatorInterface;

/**
 * Extend the JMS FormErrorHandler to include more informations when using the ViewHandler.
 */
class FormErrorHandler extends JMSFormErrorHandler
{
    private $translator;

Consider using a different property name as you override a private property of the parent class.

    public function __construct(TranslatorInterface $translator)
    {
        $this->translator = $translator;
        parent::__construct($translator);
    }

    public function serializeFormToXml(XmlSerializationVisitor $visitor, Form $form, array $type, Context $context = null)
    {
        if ($context) {
            $statusCode = $context->attributes->get('status_code');
            if ($statusCode->isDefined()) {
                if (null === $visitor->document) {

This code seems to be duplicated across your project.

                    $visitor->document = $visitor->createDocument(null, null, true);
                }

                $codeNode = $visitor->document->createElement('code');
                $visitor->getCurrentNode()->appendChild($codeNode);
                $codeNode->appendChild($context->getNavigator()->accept($statusCode->get(), null, $context));

                $messageNode = $visitor->document->createElement('message');
                $visitor->getCurrentNode()->appendChild($messageNode);
                $messageNode->appendChild($context->getNavigator()->accept('Validation Failed', null, $context));

                $errorsNode = $visitor->document->createElement('errors');
                $visitor->getCurrentNode()->appendChild($errorsNode);
                $visitor->setCurrentNode($errorsNode);
                parent::serializeFormToXml($visitor, $form, $type);
                $visitor->revertCurrentNode();

                return;
            }
        }

        return parent::serializeFormToXml($visitor, $form, $type);
    }

    public function serializeFormToJson(JsonSerializationVisitor $visitor, Form $form, array $type, Context $context = null)

This method seems to be duplicated in your project.

    {
        $isRoot = null === $visitor->getRoot();
        $result = $this->adaptFormArray(parent::serializeFormToJson($visitor, $form, $type), $context);

The expression $this->adaptFormArray(parent::serializeFormToJson($visitor, $form, $type), $context); of type array|ArrayObject adds the type array to the return on line 74 which is incompatible with the return type of the parent method JMS\Serializer\Handler\FormErrorHandler::serializeFormToJson of type ArrayObject.

        if ($isRoot) {
            $visitor->setRoot($result);
        }

        return $result;
    }

    public function serializeFormToYml(YamlSerializationVisitor $visitor, Form $form, array $type, Context $context = null)

This method seems to be duplicated in your project.

    {
        $isRoot = null === $visitor->getRoot();

The method getRoot() does not seem to exist on object<JMS\Serializer\YamlSerializationVisitor>.

        $result = $this->adaptFormArray(parent::serializeFormToYml($visitor, $form, $type), $context);

The expression $this->adaptFormArray(parent::serializeFormToYml($visitor, $form, $type), $context); of type array|ArrayObject adds the type array to the return on line 86 which is incompatible with the return type of the parent method JMS\Serializer\Handler\FormErrorHandler::serializeFormToYml of type ArrayObject.

        if ($isRoot) {
            $visitor->setRoot($result);

The method setRoot() does not seem to exist on object<JMS\Serializer\YamlSerializationVisitor>.

        }

        return $result;
    }

    private function adaptFormArray(\ArrayObject $serializedForm, Context $context = null)
    {
        $statusCode = $this->getStatusCode($context);
        if (null !== $statusCode) {
            return [
                'code' => $statusCode,
                'message' => 'Validation Failed',
                'errors' => $serializedForm,
            ];
        }

        return $serializedForm;
    }

    private function getStatusCode(Context $context = null)
    {
        if (null === $context) {
            return;
        }

        $statusCode = $context->attributes->get('status_code');
        if ($statusCode->isDefined()) {
            return $statusCode->get();
        }
    }
}