Completed
Push — master ( 4d453b...dbe76a )
by Christian
02:29 queued 11s
created

FOSRestExtension   F

Complexity

Total Complexity 68

Size/Duplication

Total Lines 393
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 10

Test Coverage

Coverage 80.33%

Importance

Changes 0
Metric Value
wmc 68
lcom 1
cbo 10
dl 0
loc 393
ccs 192
cts 239
cp 0.8033
rs 2.96
c 0
b 0
f 0

15 Methods

Rating   Name   Duplication   Size   Complexity  
A getConfiguration() 0 4 1
B load() 0 40 6
A loadForm() 0 10 2
A loadAccessDeniedListener() 0 15 4
A loadAllowedMethodsListener() 0 13 3
A loadBodyListener() 0 34 5
A loadFormatListener() 0 16 4
B loadVersioning() 0 30 7
A loadParamFetcherListener() 0 19 5
A loadBodyConverter() 0 12 3
D loadView() 0 66 11
A loadException() 0 50 4
B loadSerializer() 0 23 6
A loadZoneMatcherListener() 0 19 3
A createZoneRequestMatcher() 0 22 4

How to fix   Complexity   

Complex Class

Complex classes like FOSRestExtension often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use FOSRestExtension, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
/*
4
 * This file is part of the FOSRestBundle package.
5
 *
6
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace FOS\RestBundle\DependencyInjection;
13
14
use FOS\RestBundle\ErrorRenderer\SerializerErrorRenderer;
15
use FOS\RestBundle\EventListener\ResponseStatusCodeListener;
16
use FOS\RestBundle\View\ViewHandler;
17
use Symfony\Component\Config\FileLocator;
18
use Symfony\Component\DependencyInjection\Alias;
19
use Symfony\Component\DependencyInjection\ChildDefinition;
20
use Symfony\Component\DependencyInjection\Compiler\ServiceLocatorTagPass;
21
use Symfony\Component\DependencyInjection\ContainerBuilder;
22
use Symfony\Component\DependencyInjection\ContainerInterface;
23
use Symfony\Component\DependencyInjection\Definition;
24
use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
25
use Symfony\Component\DependencyInjection\Reference;
26
use Symfony\Component\Form\Extension\Core\Type\FormType;
27
use Symfony\Component\HttpFoundation\Response;
28
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
29
use Symfony\Component\Validator\Constraint;
30
31
/**
32
 * @internal
33
 */
34
class FOSRestExtension extends Extension
35
{
36
    /**
37
     * {@inheritdoc}
38
     */
39 14
    public function getConfiguration(array $config, ContainerBuilder $container): Configuration
40
    {
41 14
        return new Configuration($container->getParameter('kernel.debug'));
42
    }
43
44 48
    public function load(array $configs, ContainerBuilder $container): void
45
    {
46 48
        $configuration = new Configuration($container->getParameter('kernel.debug'));
47 48
        $config = $this->processConfiguration($configuration, $configs);
48
49 43
        $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
50 43
        $loader->load('view.xml');
51 43
        $loader->load('request.xml');
52 43
        $loader->load('serializer.xml');
53
54 43
        foreach ($config['service'] as $key => $service) {
55 43
            if ('validator' === $service && empty($config['body_converter']['validate'])) {
56 42
                continue;
57
            }
58
59 43
            if (null !== $service) {
60 43
                if ('view_handler' === $key) {
61 43
                    $container->setAlias('fos_rest.'.$key, new Alias($service, true));
62
                } else {
63 43
                    $container->setAlias('fos_rest.'.$key, $service);
64
                }
65
            }
66
        }
67
68 43
        $this->loadForm($config, $loader, $container);
69 43
        $this->loadException($config, $loader, $container);
70 43
        $this->loadBodyConverter($config, $loader, $container);
71 43
        $this->loadView($config, $loader, $container);
72
73 43
        $this->loadBodyListener($config, $loader, $container);
74 43
        $this->loadFormatListener($config, $loader, $container);
75 43
        $this->loadVersioning($config, $loader, $container);
76 43
        $this->loadParamFetcherListener($config, $loader, $container);
77 43
        $this->loadAllowedMethodsListener($config, $loader, $container);
78 43
        $this->loadAccessDeniedListener($config, $loader, $container);
79 43
        $this->loadZoneMatcherListener($config, $loader, $container);
80
81
        // Needs RequestBodyParamConverter and View Handler loaded.
82 43
        $this->loadSerializer($config, $container);
83 43
    }
84
85 43
    private function loadForm(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
86
    {
87 43
        if (!empty($config['disable_csrf_role'])) {
88
            $loader->load('forms.xml');
89
90
            $definition = $container->getDefinition('fos_rest.form.extension.csrf_disable');
91
            $definition->replaceArgument(1, $config['disable_csrf_role']);
92
            $definition->addTag('form.type_extension', ['extended_type' => FormType::class]);
93
        }
94 43
    }
95
96 43
    private function loadAccessDeniedListener(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
97
    {
98 43
        if ($config['access_denied_listener']['enabled'] && !empty($config['access_denied_listener']['formats'])) {
99
            $loader->load('access_denied_listener.xml');
100
101
            $service = $container->getDefinition('fos_rest.access_denied_listener');
102
103
            if (!empty($config['access_denied_listener']['service'])) {
104
                $service->clearTag('kernel.event_subscriber');
105
            }
106
107
            $service->replaceArgument(0, $config['access_denied_listener']['formats']);
108
            $service->replaceArgument(1, $config['unauthorized_challenge']);
109
        }
110 43
    }
111
112 43
    private function loadAllowedMethodsListener(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
113
    {
114 43
        if ($config['allowed_methods_listener']['enabled']) {
115 1
            if (!empty($config['allowed_methods_listener']['service'])) {
116
                $service = $container->getDefinition('fos_rest.allowed_methods_listener');
117
                $service->clearTag('kernel.event_listener');
118
            }
119
120 1
            $loader->load('allowed_methods_listener.xml');
121
122 1
            $container->getDefinition('fos_rest.allowed_methods_loader')->replaceArgument(1, $config['cache_dir']);
123
        }
124 43
    }
125
126 43
    private function loadBodyListener(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
127
    {
128 43
        if ($config['body_listener']['enabled']) {
129 42
            $loader->load('body_listener.xml');
130
131 42
            $service = $container->getDefinition('fos_rest.body_listener');
132
133 42
            if (!empty($config['body_listener']['service'])) {
134
                $service->clearTag('kernel.event_listener');
135
            }
136
137 42
            $service->replaceArgument(1, $config['body_listener']['throw_exception_on_unsupported_content_type']);
138 42
            $service->addMethodCall('setDefaultFormat', array($config['body_listener']['default_format']));
139
140 42
            $container->getDefinition('fos_rest.decoder_provider')->replaceArgument(1, $config['body_listener']['decoders']);
141
142 42
            $decoderServicesMap = array();
143
144 42
            foreach ($config['body_listener']['decoders'] as $id) {
145 42
                $decoderServicesMap[$id] = new Reference($id);
146
            }
147
148 42
            $decodersServiceLocator = ServiceLocatorTagPass::register($container, $decoderServicesMap);
149 42
            $container->getDefinition('fos_rest.decoder_provider')->replaceArgument(0, $decodersServiceLocator);
150
151 42
            $arrayNormalizer = $config['body_listener']['array_normalizer'];
152
153 42
            if (null !== $arrayNormalizer['service']) {
154 3
                $bodyListener = $container->getDefinition('fos_rest.body_listener');
155 3
                $bodyListener->addArgument(new Reference($arrayNormalizer['service']));
156 3
                $bodyListener->addArgument($arrayNormalizer['forms']);
157
            }
158
        }
159 43
    }
160
161 43
    private function loadFormatListener(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
162
    {
163 43
        if ($config['format_listener']['enabled'] && !empty($config['format_listener']['rules'])) {
164 3
            $loader->load('format_listener.xml');
165
166 3
            if (!empty($config['format_listener']['service'])) {
167
                $service = $container->getDefinition('fos_rest.format_listener');
168
                $service->clearTag('kernel.event_listener');
169
            }
170
171 3
            $container->setParameter(
172 3
                'fos_rest.format_listener.rules',
173 3
                $config['format_listener']['rules']
174
            );
175
        }
176 43
    }
177
178 43
    private function loadVersioning(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
179
    {
180 43
        if (!empty($config['versioning']['enabled'])) {
181
            $loader->load('versioning.xml');
182
183
            $versionListener = $container->getDefinition('fos_rest.versioning.listener');
184
            $versionListener->replaceArgument(1, $config['versioning']['default_version']);
185
186
            $resolvers = [];
187
            if ($config['versioning']['resolvers']['query']['enabled']) {
188
                $resolvers['query'] = $container->getDefinition('fos_rest.versioning.query_parameter_resolver');
189
                $resolvers['query']->replaceArgument(0, $config['versioning']['resolvers']['query']['parameter_name']);
190
            }
191
            if ($config['versioning']['resolvers']['custom_header']['enabled']) {
192
                $resolvers['custom_header'] = $container->getDefinition('fos_rest.versioning.header_resolver');
193
                $resolvers['custom_header']->replaceArgument(0, $config['versioning']['resolvers']['custom_header']['header_name']);
194
            }
195
            if ($config['versioning']['resolvers']['media_type']['enabled']) {
196
                $resolvers['media_type'] = $container->getDefinition('fos_rest.versioning.media_type_resolver');
197
                $resolvers['media_type']->replaceArgument(0, $config['versioning']['resolvers']['media_type']['regex']);
198
            }
199
200
            $chainResolver = $container->getDefinition('fos_rest.versioning.chain_resolver');
201
            foreach ($config['versioning']['guessing_order'] as $resolver) {
202
                if (isset($resolvers[$resolver])) {
203
                    $chainResolver->addMethodCall('addResolver', [$resolvers[$resolver]]);
204
                }
205
            }
206
        }
207 43
    }
208
209 43
    private function loadParamFetcherListener(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
210
    {
211 43
        if ($config['param_fetcher_listener']['enabled']) {
212 3
            if (!class_exists(Constraint::class)) {
213
                throw new \LogicException('Enabling the fos_rest.param_fetcher_listener option when the Symfony Validator component is not installed is not supported. Try installing the symfony/validator package.');
214
            }
215
216 3
            $loader->load('param_fetcher_listener.xml');
217
218 3
            if (!empty($config['param_fetcher_listener']['service'])) {
219
                $service = $container->getDefinition('fos_rest.param_fetcher_listener');
220
                $service->clearTag('kernel.event_listener');
221
            }
222
223 3
            if ($config['param_fetcher_listener']['force']) {
224 1
                $container->getDefinition('fos_rest.param_fetcher_listener')->replaceArgument(1, true);
225
            }
226
        }
227 43
    }
228
229 43
    private function loadBodyConverter(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
230
    {
231 43
        if (!$this->isConfigEnabled($container, $config['body_converter'])) {
232 39
            return;
233
        }
234
235 4
        $loader->load('request_body_param_converter.xml');
236
237 4
        if (!empty($config['body_converter']['validation_errors_argument'])) {
238 4
            $container->getDefinition('fos_rest.converter.request_body')->replaceArgument(4, $config['body_converter']['validation_errors_argument']);
239
        }
240 4
    }
241
242 43
    private function loadView(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
243
    {
244 43
        if (!empty($config['view']['jsonp_handler'])) {
245 1
            $handler = new ChildDefinition($config['service']['view_handler']);
246 1
            $handler->setPublic(true);
247
248 1
            $jsonpHandler = new Reference('fos_rest.view_handler.jsonp');
249 1
            $handler->addMethodCall('registerHandler', ['jsonp', [$jsonpHandler, 'createResponse']]);
250 1
            $container->setDefinition('fos_rest.view_handler', $handler);
251
252 1
            $container->getDefinition('fos_rest.view_handler.jsonp')->replaceArgument(0, $config['view']['jsonp_handler']['callback_param']);
253
254 1
            if (empty($config['view']['mime_types']['jsonp'])) {
255 1
                $config['view']['mime_types']['jsonp'] = $config['view']['jsonp_handler']['mime_type'];
256
            }
257
        }
258
259 43
        if ($config['view']['mime_types']['enabled']) {
260 1
            $loader->load('mime_type_listener.xml');
261
262 1
            if (!empty($config['mime_type_listener']['service'])) {
263
                $service = $container->getDefinition('fos_rest.mime_type_listener');
264
                $service->clearTag('kernel.event_listener');
265
            }
266
267 1
            $container->getDefinition('fos_rest.mime_type_listener')->replaceArgument(0, $config['view']['mime_types']['formats']);
268
        }
269
270 43
        if ($config['view']['view_response_listener']['enabled']) {
271 5
            $loader->load('view_response_listener.xml');
272 5
            $service = $container->getDefinition('fos_rest.view_response_listener');
273
274 5
            if (!empty($config['view_response_listener']['service'])) {
275
                $service->clearTag('kernel.event_listener');
276
            }
277
278 5
            $service->replaceArgument(1, $config['view']['view_response_listener']['force']);
279
        }
280
281 43
        $formats = [];
282 43
        foreach ($config['view']['formats'] as $format => $enabled) {
283 43
            if ($enabled) {
284 43
                $formats[$format] = false;
285
            }
286
        }
287
288 43
        if (!is_numeric($config['view']['failed_validation'])) {
289
            $config['view']['failed_validation'] = constant(sprintf('%s::%s', Response::class, $config['view']['failed_validation']));
290
        }
291
292 43
        if (!is_numeric($config['view']['empty_content'])) {
293
            $config['view']['empty_content'] = constant(sprintf('%s::%s', Response::class, $config['view']['empty_content']));
294
        }
295
296 43
        $defaultViewHandler = $container->getDefinition('fos_rest.view_handler.default');
297 43
        $defaultViewHandler->setFactory([ViewHandler::class, 'create']);
298 43
        $defaultViewHandler->setArguments([
299 43
            new Reference('fos_rest.router'),
300 43
            new Reference('fos_rest.serializer'),
301 43
            new Reference('request_stack'),
302 43
            $formats,
303 43
            $config['view']['failed_validation'],
304 43
            $config['view']['empty_content'],
305 43
            $config['view']['serialize_null'],
306
        ]);
307 43
    }
308
309 43
    private function loadException(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
310
    {
311 43
        if ($config['exception']['enabled']) {
312 12
            $loader->load('exception_listener.xml');
313
314 12
            if ($config['exception']['map_exception_codes']) {
315 1
                $container->register('fos_rest.exception.response_status_code_listener', ResponseStatusCodeListener::class)
316 1
                    ->setArguments([
317 1
                        new Reference('fos_rest.exception.codes_map'),
318
                    ])
319 1
                    ->addTag('kernel.event_subscriber');
320
            }
321
322 12
            $container->getDefinition('fos_rest.exception.codes_map')
323 12
                ->replaceArgument(0, $config['exception']['codes']);
324 12
            $container->getDefinition('fos_rest.exception.messages_map')
325 12
                ->replaceArgument(0, $config['exception']['messages']);
326
327 12
            $container->getDefinition('fos_rest.serializer.flatten_exception_handler')
328 12
                ->replaceArgument(1, $config['exception']['debug']);
329 12
            $container->getDefinition('fos_rest.serializer.flatten_exception_handler')
330 12
                ->replaceArgument(2, 'rfc7807' === $config['exception']['flatten_exception_format']);
331 12
            $container->getDefinition('fos_rest.serializer.flatten_exception_normalizer')
332 12
                ->replaceArgument(1, $config['exception']['debug']);
333 12
            $container->getDefinition('fos_rest.serializer.flatten_exception_normalizer')
334 12
                ->replaceArgument(2, 'rfc7807' === $config['exception']['flatten_exception_format']);
335
336 12
            if ($config['exception']['serializer_error_renderer']) {
337 3
                $format = new Definition();
338 3
                $format->setFactory([SerializerErrorRenderer::class, 'getPreferredFormat']);
339 3
                $format->setArguments([
340 3
                    new Reference('request_stack'),
341
                ]);
342 3
                $debug = new Definition();
343 3
                $debug->setFactory([SerializerErrorRenderer::class, 'isDebug']);
344 3
                $debug->setArguments([
345 3
                    new Reference('request_stack'),
346 3
                    '%kernel.debug%',
347
                ]);
348 3
                $container->register('fos_rest.error_renderer.serializer', SerializerErrorRenderer::class)
349 3
                    ->setArguments([
350 3
                        new Reference('fos_rest.serializer'),
351 3
                        $format,
352 3
                        new Reference('error_renderer.html', ContainerInterface::NULL_ON_INVALID_REFERENCE),
353 3
                        $debug,
354
                    ]);
355 3
                $container->setAlias('error_renderer.serializer', 'fos_rest.error_renderer.serializer');
356
            }
357
        }
358 43
    }
359
360 43
    private function loadSerializer(array $config, ContainerBuilder $container): void
361
    {
362 43
        $bodyConverter = $container->hasDefinition('fos_rest.converter.request_body') ? $container->getDefinition('fos_rest.converter.request_body') : null;
363 43
        $viewHandler = $container->getDefinition('fos_rest.view_handler.default');
364 43
        $options = array();
365
366 43
        if (!empty($config['serializer']['version'])) {
367
            if ($bodyConverter) {
368
                $bodyConverter->replaceArgument(2, $config['serializer']['version']);
369
            }
370
            $options['exclusionStrategyVersion'] = $config['serializer']['version'];
371
        }
372
373 43
        if (!empty($config['serializer']['groups'])) {
374
            if ($bodyConverter) {
375
                $bodyConverter->replaceArgument(1, $config['serializer']['groups']);
376
            }
377
            $options['exclusionStrategyGroups'] = $config['serializer']['groups'];
378
        }
379
380 43
        $options['serializeNullStrategy'] = $config['serializer']['serialize_null'];
381 43
        $viewHandler->addArgument($options);
382 43
    }
383
384 43
    private function loadZoneMatcherListener(array $config, XmlFileLoader $loader, ContainerBuilder $container): void
385
    {
386 43
        if (!empty($config['zone'])) {
387 1
            $loader->load('zone_matcher_listener.xml');
388 1
            $zoneMatcherListener = $container->getDefinition('fos_rest.zone_matcher_listener');
389
390 1
            foreach ($config['zone'] as $zone) {
391 1
                $matcher = $this->createZoneRequestMatcher(
392 1
                    $container,
393 1
                    $zone['path'],
394 1
                    $zone['host'],
395 1
                    $zone['methods'],
396 1
                    $zone['ips']
397
                );
398
399 1
                $zoneMatcherListener->addMethodCall('addRequestMatcher', array($matcher));
400
            }
401
        }
402 43
    }
403
404 1
    private function createZoneRequestMatcher(ContainerBuilder $container, ?string $path = null, ?string $host = null, array $methods = array(), array $ips = null): Reference
405
    {
406 1
        if ($methods) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $methods of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
407
            $methods = array_map('strtoupper', (array) $methods);
408
        }
409
410 1
        $serialized = serialize(array($path, $host, $methods, $ips));
411 1
        $id = 'fos_rest.zone_request_matcher.'.md5($serialized).sha1($serialized);
412
413
        // only add arguments that are necessary
414 1
        $arguments = array($path, $host, $methods, $ips);
415 1
        while (count($arguments) > 0 && !end($arguments)) {
416 1
            array_pop($arguments);
417
        }
418
419
        $container
420 1
            ->setDefinition($id, new ChildDefinition('fos_rest.zone_request_matcher'))
421 1
            ->setArguments($arguments)
422
        ;
423
424 1
        return new Reference($id);
425
    }
426
}
427