FOS\RestBundle\Serializer\Normalizer\FlattenExceptionHandler

Complexity

Total Complexity

19

Size/Duplication

Total Lines	107
Duplicated Lines	15.89 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

94.23%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	getSubscribingMethods()	0	17	1
A	serializeToJson()	0	8	2
B	serializeToXml()	0	33	7
B	convertToArray()	10	30	8

<?php

namespace FOS\RestBundle\Serializer\Normalizer;

use FOS\RestBundle\Util\ExceptionValueMap;
use JMS\Serializer\Context;
use JMS\Serializer\GraphNavigatorInterface;
use JMS\Serializer\Handler\SubscribingHandlerInterface;
use JMS\Serializer\JsonSerializationVisitor;
use JMS\Serializer\XmlSerializationVisitor;
use Symfony\Component\ErrorHandler\Exception\FlattenException;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author Christian Flothmann <christian.flothmann@sensiolabs.de>
 *
 * @internal
 */
class FlattenExceptionHandler implements SubscribingHandlerInterface
{
    private $statusCodeMap;
    private $messagesMap;
    private $debug;
    private $rfc7807;

    public function __construct(ExceptionValueMap $statusCodeMap, ExceptionValueMap $messagesMap, bool $debug, bool $rfc7807)

This method seems to be duplicated in your project.

    {
        $this->statusCodeMap = $statusCodeMap;
        $this->messagesMap = $messagesMap;
        $this->debug = $debug;
        $this->rfc7807 = $rfc7807;
    }

    public static function getSubscribingMethods(): array
    {
        return [
            [
                'direction' => GraphNavigatorInterface::DIRECTION_SERIALIZATION,
                'format' => 'json',
                'type' => FlattenException::class,
                'method' => 'serializeToJson',
            ],
            [
                'direction' => GraphNavigatorInterface::DIRECTION_SERIALIZATION,
                'format' => 'xml',
                'type' => FlattenException::class,
                'method' => 'serializeToXml',
            ],
        ];
    }

    public function serializeToJson(JsonSerializationVisitor $visitor, FlattenException $exception, array $type, Context $context)
    {
        if ($this->rfc7807) {
            $exception->setHeaders($exception->getHeaders() + ['Content-Type' => 'application/problem+json']);
        }

        return $visitor->visitArray($this->convertToArray($exception, $context), $type, $context);

The call to JsonSerializationVisitor::visitArray() has too many arguments starting with $context.

    }

    public function serializeToXml(XmlSerializationVisitor $visitor, FlattenException $exception, array $type, Context $context)

The parameter $type is not used and could be removed.

    {
        if ($this->rfc7807) {
            $exception->setHeaders($exception->getHeaders() + ['Content-Type' => 'application/problem+xml']);
        }

        $rootName = $this->rfc7807 ? 'response' : 'result';

        $data = $this->convertToArray($exception, $context);

        if (method_exists($visitor, 'setDefaultRootName')) {
            $visitor->setDefaultRootName($rootName);

The method setDefaultRootName() does not seem to exist on object<JMS\Serializer\XmlSerializationVisitor>.

        }

        $document = $visitor->getDocument(true);

The call to XmlSerializationVisitor::getDocument() has too many arguments starting with true.

        if (!$visitor->getCurrentNode()) {
            $visitor->createRoot(null, $rootName);
        }

        foreach ($data as $key => $value) {
            $entryNode = $document->createElement($key);
            $visitor->getCurrentNode()->appendChild($entryNode);
            $visitor->setCurrentNode($entryNode);

            $node = $context->getNavigator()->accept($value, null, $context);

The call to GraphNavigatorInterface::accept() has too many arguments starting with $context.

            if (null !== $node) {
                $visitor->getCurrentNode()->appendChild($node);
            }

            $visitor->revertCurrentNode();
        }
    }

    private function convertToArray(FlattenException $exception, Context $context): array
    {
        if ($context->hasAttribute('status_code')) {
            $statusCode = $context->getAttribute('status_code');
        } elseif (false === $statusCode = $this->statusCodeMap->resolveFromClassName($exception->getClass())) {
            $statusCode = $exception->getStatusCode();
        }

        $showMessage = $this->messagesMap->resolveFromClassName($exception->getClass());

        if ($showMessage || $this->debug) {
            $message = $exception->getMessage();
        } else {
            $message = Response::$statusTexts[$statusCode] ?? 'error';
        }

        if ($this->rfc7807) {
            return [
                'type' => $context->hasAttribute('type') ? $context->getAttribute('type') : 'https://tools.ietf.org/html/rfc2616#section-10',
                'title' => $context->hasAttribute('title') ? $context->getAttribute('title') : 'An error occurred',
                'status' => $statusCode,
                'detail' => $message,
            ];
        } else {
            return [
                'code' => $statusCode,
                'message' => $message,
            ];
        }
    }
}