Issues in RuleMatcher.php - All Issues - Inspection of "Merge pull request #461 from FriendsOfSymfony/fix-..." - FriendsOfSymfony/FOSHttpCacheBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 849954...8f1795 )

by David

created 2018-06-14 06:16 UTC

src/Http/RuleMatcher.php (2 issues)

Showing only issues like (Show All)

Look for PHPDoc comments for non-existent parameters and make alternative suggestion.

Documentation Minor

David de Boer 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the FOSHttpCacheBundle package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\HttpCacheBundle\Http;

use FOS\HttpCacheBundle\Http\ResponseMatcher\ResponseMatcherInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestMatcherInterface;
use Symfony\Component\HttpFoundation\Response;

/**
 * Combines a RequestMatcherInterface and a ResponseMatcherInterface.
 *
 * Both must match for the RuleMatcher to match.
 *
 * @author David Buchmann <[email protected]>
 */
class RuleMatcher implements RuleMatcherInterface
{
    /**
     * @var RequestMatcherInterface
     */
    private $requestMatcher;

    /**
     * @var ResponseMatcherInterface
     */
    private $responseMatcher;

    /**
     * @param RequestMatcherInterface  $requestMatcher|null  Request matcher
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param ResponseMatcherInterface $responseMatcher|null Response matcher
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(
        RequestMatcherInterface $requestMatcher = null,
        ResponseMatcherInterface $responseMatcher = null
    ) {
        $this->requestMatcher = $requestMatcher;
        $this->responseMatcher = $responseMatcher;
    }

    /**
     * {@inheritdoc}
     */
    public function matches(Request $request, Response $response)
    {
        if ($this->requestMatcher && !$this->requestMatcher->matches($request)) {
            return false;
        }

        if ($this->responseMatcher && !$this->responseMatcher->matches($response)) {
            return false;
        }

        return true;
    }
}


1		<?php
2
3		/*
4		* This file is part of the FOSHttpCacheBundle package.
5		*
6		* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace FOS\HttpCacheBundle\Http;
13
14		use FOS\HttpCacheBundle\Http\ResponseMatcher\ResponseMatcherInterface;
15		use Symfony\Component\HttpFoundation\Request;
16		use Symfony\Component\HttpFoundation\RequestMatcherInterface;
17		use Symfony\Component\HttpFoundation\Response;
18
19		/**
20		* Combines a RequestMatcherInterface and a ResponseMatcherInterface.
21		*
22		* Both must match for the RuleMatcher to match.
23		*
24		* @author David Buchmann <[email protected]>
25		*/
26		class RuleMatcher implements RuleMatcherInterface
27		{
28		/**
29		* @var RequestMatcherInterface
30		*/
31		private $requestMatcher;
32
33		/**
34		* @var ResponseMatcherInterface
35		*/
36		private $responseMatcher;
37
38		/**
39		* @param RequestMatcherInterface $requestMatcher\|null Request matcher
		0 ignored issues – show Documentation introduced 2017-02-09 11:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$requestMatcher\|null`. Did you maybe mean `$requestMatcher`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
40		* @param ResponseMatcherInterface $responseMatcher\|null Response matcher
		0 ignored issues – show Documentation introduced 2017-02-09 11:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$responseMatcher\|null`. Did you maybe mean `$responseMatcher`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
41		*/
42	30	public function __construct(
43		RequestMatcherInterface $requestMatcher = null,
44		ResponseMatcherInterface $responseMatcher = null
45		) {
46	30	$this->requestMatcher = $requestMatcher;
47	30	$this->responseMatcher = $responseMatcher;
48	30	}
49
50		/**
51		* {@inheritdoc}
52		*/
53	25	public function matches(Request $request, Response $response)
54		{
55	25	if ($this->requestMatcher && !$this->requestMatcher->matches($request)) {
56	20	return false;
57		}
58
59	24	if ($this->responseMatcher && !$this->responseMatcher->matches($response)) {
60	4	return false;
61		}
62
63	21	return true;
64		}
65		}
66

FriendsOfSymfony / FOSHttpCacheBundle

Push — master ( 849954...8f1795 )

src/Http/RuleMatcher.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like