Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class SymfonyResponseTagger extends ResponseTagger |
||
18 | { |
||
19 | /** |
||
20 | * Tag a symfony response with the previously added tags. |
||
21 | * |
||
22 | * @param Response $response |
||
23 | * @param bool $replace Whether to replace the current tags on the |
||
24 | * response. If false, parses the header to merge |
||
25 | * tags |
||
26 | * |
||
27 | * @return $this |
||
28 | */ |
||
29 | 7 | public function tagSymfonyResponse(Response $response, $replace = false) |
|
46 | } |
||
47 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.