ContextInvalidationLogoutHandler::__construct() - Code Metrics - Inspection of "Support Symfony 5.1, fix CI Build and update PHPUn..." - FriendsOfSymfony/FOSHttpCacheBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 396eea...74cb0e )

by David

created 2020-08-19 14:59 UTC

ContextInvalidationLogoutHandler::__construct() A

↳ Parent: ContextInvalidationLogoutHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
nc	1
nop	1
crap	2

<?php

/*
 * This file is part of the FOSHttpCacheBundle package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\HttpCacheBundle\Security\Http\Logout;

use FOS\HttpCacheBundle\UserContextInvalidator;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Http\Event\LogoutEvent;
use Symfony\Component\Security\Http\Logout\LogoutHandlerInterface;

/**
 * @deprecated use ContextInvalidationSessionLogoutHandler in this same namespace as a replacement
 *
 * This handler is deprecated because it never did what it was supposed to do. The session is already invalidated by the SessionLogoutHandler
 * which is always the first logout handler executed
 */
final class ContextInvalidationLogoutHandler implements LogoutHandlerInterface

{
    private $invalidator;

    public function __construct(UserContextInvalidator $invalidator)
    {
        $this->invalidator = $invalidator;
    }

    /**
     * {@inheritdoc}
     */
    public function logout(Request $request, Response $response, TokenInterface $token)
    {
        @trigger_error('Using the ContextInvalidationLogoutHandler is deprecated', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        if (class_exists(LogoutEvent::class)) {
            // This class no longer works at all with Symfony 5.1, force usage of ContextInvalidationSessionLogoutHandler instead
            // See also: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/545#discussion_r465089219
            throw new \LogicException(__CLASS__.'::'.__METHOD__.' no longer works with Symfony 5.1. Remove fos_http_cache.user_context.logout_handler from your firewall configuration. See the changelog for version 2.2. for more information.');
        }

        $this->invalidator->invalidateContext($request->getSession()->getId());
    }
}


1			<?php
2
3			/*
4			* This file is part of the FOSHttpCacheBundle package.
5			*
6			* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace FOS\HttpCacheBundle\Security\Http\Logout;
13
14			use FOS\HttpCacheBundle\UserContextInvalidator;
15			use Symfony\Component\HttpFoundation\Request;
16			use Symfony\Component\HttpFoundation\Response;
17			use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
18			use Symfony\Component\Security\Http\Event\LogoutEvent;
19			use Symfony\Component\Security\Http\Logout\LogoutHandlerInterface;
20
21			/**
22			* @deprecated use ContextInvalidationSessionLogoutHandler in this same namespace as a replacement
23			*
24			* This handler is deprecated because it never did what it was supposed to do. The session is already invalidated by the SessionLogoutHandler
25			* which is always the first logout handler executed
26			*/
27			final class ContextInvalidationLogoutHandler implements LogoutHandlerInterface
			0 ignored issues – show Deprecated Code introduced 2020-07-22 09:54 UTC by Report Bug Copy Issue Report The interface `Symfony\Component\Securi...\LogoutHandlerInterface` has been deprecated with message: since Symfony 5.1 This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
28			{
29			private $invalidator;
30
31			public function __construct(UserContextInvalidator $invalidator)
32			{
33			$this->invalidator = $invalidator;
34			}
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function logout(Request $request, Response $response, TokenInterface $token)
40			{
41			@trigger_error('Using the ContextInvalidationLogoutHandler is deprecated', E_USER_DEPRECATED);
			0 ignored issues – show Security Best Practice introduced 2017-11-08 14:44 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
42
43			if (class_exists(LogoutEvent::class)) {
44			// This class no longer works at all with Symfony 5.1, force usage of ContextInvalidationSessionLogoutHandler instead
45			// See also: https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/545#discussion_r465089219
46			throw new \LogicException(__CLASS__.'::'.__METHOD__.' no longer works with Symfony 5.1. Remove fos_http_cache.user_context.logout_handler from your firewall configuration. See the changelog for version 2.2. for more information.');
47			}
48
49			$this->invalidator->invalidateContext($request->getSession()->getId());
50			}
51			}
52

FriendsOfSymfony / FOSHttpCacheBundle

Push — master ( 396eea...74cb0e )

ContextInvalidationLogoutHandler::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like