HttpClient::getResponse() - Code Metrics - Inspection of "feat(client): adds a noop client which implements..." - FriendsOfSymfony/FOSHttpCache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#289)

by Gavin

created 2016-06-29 15:00 UTC

HttpClient::getResponse() A

↳ Parent: HttpClient

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1.0156

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
ccs	3
cts	4
cp	0.75
rs	9.6666
cc	1
eloc	4
nc	1
nop	3
crap	1.0156

<?php

/*
 * This file is part of the FOSHttpCache package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\HttpCache\Test;

use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\UriFactoryDiscovery;
use Http\Client\HttpClient as PhpHttpClient;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;

/**
 * Provides a very simple way to fetch HTTP responses, auto-creating a client.
 */
class HttpClient
{
    /**
     * HTTP client for requests to the application
     *
     * @var HttpClient
     */
    private $httpClient;

    /**
     * @var string
     */
    private $hostname;

    /**
     * @var string
     */
    private $port;

    /**
     * @param string $hostname Default hostname if not specified in the URL
     * @param string $port     Default port if not specified in the URL
     */
    public function __construct($hostname, $port)
    {
        $this->hostname = $hostname;
        $this->port = $port;
    }

    /**
     * Get HTTP response from your application
     *
     * @param string $uri     HTTP URI
     * @param array  $headers HTTP headers
     * @param string $method  HTTP method
     *
     * @return ResponseInterface
     */
    public function getResponse($uri, array $headers, $method)
    {
        // Close connections to make sure invalidation (PURGE/BAN) requests will
        // not interfere with content (GET) requests.
        $headers['Connection'] = 'Close';
        $request = $this->createRequest($method, $uri, $headers);

        return $this->getHttpClient()->sendRequest($request);
    }

    /**
     * Get HTTP adapter for your application
     *
     * @return PhpHttpClient
     */
    private function getHttpClient()
    {
        if ($this->httpClient === null) {
            $this->httpClient = HttpClientDiscovery::find();

        }

        return $this->httpClient;
    }

    /**
     * Create a request
     *
     * @param string $method
     * @param string $uri
     * @param array  $headers
     *
     * @return RequestInterface
     * @throws \Exception
     */
    private function createRequest($method, $uri, $headers)
    {
        $uri = $this->createUri($uri);
        if ($uri->getHost() === '') {
            // Add base URI host
            $uri = $uri->withHost($this->hostname);
        }

        if (!$uri->getPort()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $uri = $uri->withPort($this->port);
        }

        if ($uri->getScheme() === '') {
            $uri = $uri->withScheme('http');
        }

        return MessageFactoryDiscovery::find()->createRequest(
            $method,
            $uri,
            $headers
        );
    }

    /**
     * Create PSR-7 URI object from URI string
     *
     * @param string $uriString
     *
     * @return UriInterface
     */
    private function createUri($uriString)
    {
        return UriFactoryDiscovery::find()->createUri($uriString);
    }
}


1		<?php
2
3		/*
4		* This file is part of the FOSHttpCache package.
5		*
6		* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace FOS\HttpCache\Test;
13
14		use Http\Discovery\HttpClientDiscovery;
15		use Http\Discovery\MessageFactoryDiscovery;
16		use Http\Discovery\UriFactoryDiscovery;
17		use Http\Client\HttpClient as PhpHttpClient;
18		use Psr\Http\Message\RequestInterface;
19		use Psr\Http\Message\ResponseInterface;
20		use Psr\Http\Message\UriInterface;
21
22		/**
23		* Provides a very simple way to fetch HTTP responses, auto-creating a client.
24		*/
25		class HttpClient
26		{
27		/**
28		* HTTP client for requests to the application
29		*
30		* @var HttpClient
31		*/
32		private $httpClient;
33
34		/**
35		* @var string
36		*/
37		private $hostname;
38
39		/**
40		* @var string
41		*/
42		private $port;
43
44		/**
45		* @param string $hostname Default hostname if not specified in the URL
46		* @param string $port Default port if not specified in the URL
47		*/
48	29	public function __construct($hostname, $port)
49		{
50	29	$this->hostname = $hostname;
51	29	$this->port = $port;
52	29	}
53
54		/**
55		* Get HTTP response from your application
56		*
57		* @param string $uri HTTP URI
58		* @param array $headers HTTP headers
59		* @param string $method HTTP method
60		*
61		* @return ResponseInterface
62		*/
63	29	public function getResponse($uri, array $headers, $method)
64		{
65		// Close connections to make sure invalidation (PURGE/BAN) requests will
66		// not interfere with content (GET) requests.
67	29	$headers['Connection'] = 'Close';
68	29	$request = $this->createRequest($method, $uri, $headers);
69
70		return $this->getHttpClient()->sendRequest($request);
71		}
72
73		/**
74		* Get HTTP adapter for your application
75		*
76		* @return PhpHttpClient
77		*/
78		private function getHttpClient()
79		{
80		if ($this->httpClient === null) {
81		$this->httpClient = HttpClientDiscovery::find();
		0 ignored issues – show Documentation Bug introduced 2015-12-07 13:45 UTC by Report Bug Copy Issue Report It seems like `\Http\Discovery\HttpClientDiscovery::find()` of type `object<Http\Client\HttpClient>` is incompatible with the declared type `object<FOS\HttpCache\Test\HttpClient>` of property `$httpClient`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
82		}
83
84		return $this->httpClient;
85		}
86
87		/**
88		* Create a request
89		*
90		* @param string $method
91		* @param string $uri
92		* @param array $headers
93		*
94		* @return RequestInterface
95		* @throws \Exception
96		*/
97	29	private function createRequest($method, $uri, $headers)
98		{
99	29	$uri = $this->createUri($uri);
100		if ($uri->getHost() === '') {
101		// Add base URI host
102		$uri = $uri->withHost($this->hostname);
103		}
104
105		if (!$uri->getPort()) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-23 22:08 UTC by Report Bug Copy Issue Report The expression `$uri->getPort()` of type `null\|integer` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
106		$uri = $uri->withPort($this->port);
107		}
108
109		if ($uri->getScheme() === '') {
110		$uri = $uri->withScheme('http');
111		}
112
113		return MessageFactoryDiscovery::find()->createRequest(
114		$method,
115		$uri,
116		$headers
117		);
118		}
119
120		/**
121		* Create PSR-7 URI object from URI string
122		*
123		* @param string $uriString
124		*
125		* @return UriInterface
126		*/
127	29	private function createUri($uriString)
128		{
129	29	return UriFactoryDiscovery::find()->createUri($uriString);
130		}
131		}
132

FriendsOfSymfony / FOSHttpCache

Pull Request — master (#289)

HttpClient::getResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like