Completed
Pull Request — master (#289)
by Gavin
16:24 queued 13:47
created

Varnish   A

Complexity

Total Complexity 22

Size/Duplication

Total Lines 193
Duplicated Lines 3.63 %

Coupling/Cohesion

Components 1
Dependencies 7

Test Coverage

Coverage 0%

Importance

Changes 7
Bugs 0 Features 1
Metric Value
wmc 22
c 7
b 0
f 1
lcom 1
cbo 7
dl 7
loc 193
ccs 0
cts 66
cp 0
rs 10

12 Methods

Rating   Name   Duplication   Size   Complexity  
A getTagsHeaderValue() 0 4 1
A setDefaultBanHeaders() 0 4 1
A setDefaultBanHeader() 0 4 1
B invalidateTags() 0 22 4
A getTagsHeaderName() 0 4 1
A getHeaderLength() 0 4 1
A ban() 0 11 1
B banPath() 0 22 5
A purge() 0 6 1
A refresh() 7 7 1
A getDefaultOptions() 0 8 1
A queueRequest() 0 13 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
/*
4
 * This file is part of the FOSHttpCache package.
5
 *
6
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace FOS\HttpCache\ProxyClient;
13
14
use FOS\HttpCache\Exception\InvalidArgumentException;
15
use FOS\HttpCache\Exception\MissingHostException;
16
use FOS\HttpCache\ProxyClient\Invalidation\BanInterface;
17
use FOS\HttpCache\ProxyClient\Invalidation\PurgeInterface;
18
use FOS\HttpCache\ProxyClient\Invalidation\RefreshInterface;
19
use FOS\HttpCache\ProxyClient\Invalidation\TagsInterface;
20
use Http\Message\MessageFactory;
21
22
/**
23
 * Varnish HTTP cache invalidator.
24
 *
25
 * Additional constructor options:
26
 * - tags_header   Header for tagging responses, defaults to X-Cache-Tags
27
 * - header_length Maximum header length, defaults to 7500 bytes
28
 *
29
 * @author David de Boer <[email protected]>
30
 */
31
class Varnish extends AbstractProxyClient implements BanInterface, PurgeInterface, RefreshInterface, TagsInterface
32
{
33
    const HTTP_METHOD_BAN          = 'BAN';
34
    const HTTP_METHOD_PURGE        = 'PURGE';
35
    const HTTP_METHOD_REFRESH      = 'GET';
36
    const HTTP_HEADER_HOST         = 'X-Host';
37
    const HTTP_HEADER_URL          = 'X-Url';
38
    const HTTP_HEADER_CONTENT_TYPE = 'X-Content-Type';
39
40
    /**
41
     * Map of default headers for ban requests with their default values.
42
     *
43
     * @var array
44
     */
45
    private $defaultBanHeaders = [
46
        self::HTTP_HEADER_HOST         => self::REGEX_MATCH_ALL,
47
        self::HTTP_HEADER_URL          => self::REGEX_MATCH_ALL,
48
        self::HTTP_HEADER_CONTENT_TYPE => self::REGEX_MATCH_ALL
49
    ];
50
51
    /**
52
     * Set the default headers that get merged with the provided headers in self::ban().
53
     *
54
     * @param array $headers Hashmap with keys being the header names, values
55
     *                       the header values.
56
     */
57
    public function setDefaultBanHeaders(array $headers)
58
    {
59
        $this->defaultBanHeaders = $headers;
60
    }
61
62
    /**
63
     * Add or overwrite a default ban header.
64
     *
65
     * @param string $name  The name of that header
66
     * @param string $value The content of that header
67
     */
68
    public function setDefaultBanHeader($name, $value)
69
    {
70
        $this->defaultBanHeaders[$name] = $value;
71
    }
72
73
    /**
74
     * {@inheritdoc}
75
     */
76
    public function invalidateTags(array $tags)
77
    {
78
        $escapedTags = array_map('preg_quote', $this->escapeTags($tags));
79
80
        if (mb_strlen(implode('|', $escapedTags)) >= $this->options['header_length']) {
81
            /*
82
             * estimate the amount of tags to invalidate by dividing the max
83
             * header length by the largest tag (minus 1 for the implode character)
84
             */
85
            $tagsize = max(array_map('mb_strlen', $escapedTags));
86
            $elems = floor($this->options['header_length'] / ($tagsize - 1)) ? : 1;
87
        } else {
88
            $elems = count($escapedTags);
89
        }
90
91
        foreach (array_chunk($escapedTags, $elems) as $tagchunk) {
92
            $tagExpression = sprintf('(%s)(,.+)?$', implode('|', $tagchunk));
93
            $this->ban([$this->options['tags_header'] => $tagExpression]);
94
        }
95
96
        return $this;
97
    }
98
99
    /**
100
     * {@inheritdoc}
101
     */
102
    public function getTagsHeaderValue(array $tags)
103
    {
104
        return array_unique($this->escapeTags($tags));
105
    }
106
107
    /**
108
     * Get the HTTP header name that will hold cache tags.
109
     *
110
     * @return string
111
     */
112
    public function getTagsHeaderName()
113
    {
114
        return $this->options['tags_header'];
115
    }
116
117
    /**
118
     * Get the maximum HTTP header length.
119
     *
120
     * @return int
121
     */
122
    public function getHeaderLength()
123
    {
124
        return $this->options['header_length'];
125
    }
126
127
    /**
128
     * {@inheritdoc}
129
     */
130
    public function ban(array $headers)
131
    {
132
        $headers = array_merge(
133
            $this->defaultBanHeaders,
134
            $headers
135
        );
136
137
        $this->queueRequest(self::HTTP_METHOD_BAN, '/', $headers);
138
139
        return $this;
140
    }
141
142
    /**
143
     * {@inheritdoc}
144
     */
145
    public function banPath($path, $contentType = null, $hosts = null)
146
    {
147
        if (is_array($hosts)) {
148
            if (!count($hosts)) {
149
                throw new InvalidArgumentException('Either supply a list of hosts or null, but not an empty array.');
150
            }
151
            $hosts = '^('.join('|', $hosts).')$';
152
        }
153
154
        $headers = [
155
            self::HTTP_HEADER_URL => $path,
156
        ];
157
158
        if ($contentType) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $contentType of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
159
            $headers[self::HTTP_HEADER_CONTENT_TYPE] = $contentType;
160
        }
161
        if ($hosts) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $hosts of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

In PHP, under loose comparison (like ==, or !=, or switch conditions), values of different types might be equal.

For string values, the empty string '' is a special case, in particular the following results might be unexpected:

''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
Loading history...
162
            $headers[self::HTTP_HEADER_HOST] = $hosts;
163
        }
164
165
        return $this->ban($headers);
166
    }
167
168
    /**
169
     * {@inheritdoc}
170
     */
171
    public function purge($url, array $headers = [])
172
    {
173
        $this->queueRequest(self::HTTP_METHOD_PURGE, $url, $headers);
174
175
        return $this;
176
    }
177
178
    /**
179
     * {@inheritdoc}
180
     */
181 View Code Duplication
    public function refresh($url, array $headers = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
182
    {
183
        $headers = array_merge($headers, ['Cache-Control' => 'no-cache']);
184
        $this->queueRequest(self::HTTP_METHOD_REFRESH, $url, $headers);
185
186
        return $this;
187
    }
188
189
    /**
190
     * {@inheritdoc}
191
     */
192
    protected function getDefaultOptions()
193
    {
194
        $resolver = parent::getDefaultOptions();
195
        $resolver->setDefaults(['tags_header' => 'X-Cache-Tags']);
196
        $resolver->setDefaults(['header_length' => 7500]);
197
198
        return $resolver;
199
    }
200
201
    /**
202
     * Build the invalidation request and validate it.
203
     *
204
     * {@inheritdoc}
205
     *
206
     * @throws MissingHostException If a relative path is queued for purge/
207
     *                              refresh and no base URL is set
208
     *
209
     */
210
    protected function queueRequest($method, $url, array $headers = [])
211
    {
212
        $request = $this->messageFactory->createRequest($method, $url, $headers);
213
214
        if (self::HTTP_METHOD_BAN !== $method
215
            && null === $this->options['base_uri']
216
            && !$request->getHeaderLine('Host')
217
        ) {
218
            throw MissingHostException::missingHost($url);
219
        }
220
221
        $this->httpAdapter->invalidate($request);
222
    }
223
}
224