Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 31 | class Varnish extends HttpProxyClient implements BanInterface, PurgeInterface, RefreshInterface, TagsInterface |
||
| 32 | { |
||
| 33 | const HTTP_METHOD_BAN = 'BAN'; |
||
| 34 | const HTTP_METHOD_PURGE = 'PURGE'; |
||
| 35 | const HTTP_METHOD_REFRESH = 'GET'; |
||
| 36 | const HTTP_HEADER_HOST = 'X-Host'; |
||
| 37 | const HTTP_HEADER_URL = 'X-Url'; |
||
| 38 | const HTTP_HEADER_CONTENT_TYPE = 'X-Content-Type'; |
||
| 39 | const DEFAULT_HTTP_HEADER_CACHE_TAGS = 'X-Cache-Tags'; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * {@inheritdoc} |
||
| 43 | */ |
||
| 44 | 4 | public function invalidateTags(array $tags) |
|
| 45 | { |
||
| 46 | 4 | if ($this->options['tags_invalidation_by_purge']) { |
|
| 47 | // Varnish xkey (and Fastly) is limited to purge one tag at a time |
||
| 48 | foreach (array_unique($this->escapeTags($tags)) as $tag) { |
||
| 49 | $this->purge('/', [$this->options['tags_header'] => $tag]); |
||
| 50 | } |
||
| 51 | |||
| 52 | return $this; |
||
| 53 | } |
||
| 54 | |||
| 55 | 4 | $escapedTags = array_map('preg_quote', $this->escapeTags($tags)); |
|
| 56 | |||
| 57 | 4 | if (mb_strlen(implode('|', $escapedTags)) >= $this->options['header_length']) { |
|
| 58 | /* |
||
| 59 | * estimate the amount of tags to invalidate by dividing the max |
||
| 60 | * header length by the largest tag (minus 1 for the implode character) |
||
| 61 | */ |
||
| 62 | 1 | $tagsize = max(array_map('mb_strlen', $escapedTags)); |
|
| 63 | 1 | $elems = floor($this->options['header_length'] / ($tagsize - 1)) ?: 1; |
|
| 64 | 1 | } else { |
|
| 65 | 3 | $elems = count($escapedTags); |
|
| 66 | } |
||
| 67 | |||
| 68 | 4 | foreach (array_chunk($escapedTags, $elems) as $tagchunk) { |
|
| 69 | 4 | $tagExpression = sprintf('(%s)(,.+)?$', implode('|', $tagchunk)); |
|
| 70 | 4 | $this->ban([$this->options['tags_header'] => $tagExpression]); |
|
| 71 | 4 | } |
|
| 72 | |||
| 73 | 4 | return $this; |
|
| 74 | } |
||
| 75 | |||
| 76 | /** |
||
| 77 | * {@inheritdoc} |
||
| 78 | */ |
||
| 79 | 1 | public function getTagsHeaderValue(array $tags) |
|
| 80 | { |
||
| 81 | 1 | return implode($this->options['tags_separator'], array_unique($this->escapeTags($tags))); |
|
| 82 | } |
||
| 83 | |||
| 84 | /** |
||
| 85 | * {@inheritdoc} |
||
| 86 | */ |
||
| 87 | 1 | public function getTagsHeaderName() |
|
| 91 | |||
| 92 | /** |
||
| 93 | * {@inheritdoc} |
||
| 94 | */ |
||
| 95 | 10 | public function ban(array $headers) |
|
| 96 | { |
||
| 97 | 10 | $headers = array_merge( |
|
| 98 | 10 | $this->options['default_ban_headers'], |
|
| 99 | $headers |
||
| 100 | 10 | ); |
|
| 101 | |||
| 102 | 10 | $this->queueRequest(self::HTTP_METHOD_BAN, '/', $headers); |
|
| 103 | |||
| 104 | 10 | return $this; |
|
| 105 | } |
||
| 106 | |||
| 107 | /** |
||
| 108 | * {@inheritdoc} |
||
| 109 | */ |
||
| 110 | 4 | public function banPath($path, $contentType = null, $hosts = null) |
|
| 111 | { |
||
| 112 | 4 | if (is_array($hosts)) { |
|
| 113 | 2 | if (!count($hosts)) { |
|
| 114 | 1 | throw new InvalidArgumentException('Either supply a list of hosts or null, but not an empty array.'); |
|
| 115 | } |
||
| 116 | 1 | $hosts = '^('.implode('|', $hosts).')$'; |
|
| 117 | 1 | } |
|
| 118 | |||
| 119 | $headers = [ |
||
| 120 | 3 | self::HTTP_HEADER_URL => $path, |
|
| 121 | 3 | ]; |
|
| 122 | |||
| 123 | 3 | if ($contentType) { |
|
|
|
|||
| 124 | 2 | $headers[self::HTTP_HEADER_CONTENT_TYPE] = $contentType; |
|
| 125 | 2 | } |
|
| 126 | 3 | if ($hosts) { |
|
| 127 | 1 | $headers[self::HTTP_HEADER_HOST] = $hosts; |
|
| 128 | 1 | } |
|
| 129 | |||
| 130 | 3 | return $this->ban($headers); |
|
| 131 | } |
||
| 132 | |||
| 133 | /** |
||
| 134 | * {@inheritdoc} |
||
| 135 | */ |
||
| 136 | 4 | public function purge($url, array $headers = []) |
|
| 142 | |||
| 143 | /** |
||
| 144 | * {@inheritdoc} |
||
| 145 | */ |
||
| 146 | 3 | View Code Duplication | public function refresh($url, array $headers = []) |
| 153 | |||
| 154 | /** |
||
| 155 | * {@inheritdoc} |
||
| 156 | */ |
||
| 157 | 22 | protected function configureOptions() |
|
| 180 | } |
||
| 181 |
In PHP, under loose comparison (like
==, or!=, orswitchconditions), values of different types might be equal.For
stringvalues, the empty string''is a special case, in particular the following results might be unexpected: