Varnish::configureOptions() - Code Metrics - Inspection of "refactor http abstraction" - FriendsOfSymfony/FOSHttpCache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#312)

by David

created 2016-10-15 14:16 UTC

Varnish::configureOptions() A

↳ Parent: Varnish

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	16
cts	16
cp	1
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	13
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the FOSHttpCache package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\HttpCache\ProxyClient;

use FOS\HttpCache\Exception\InvalidArgumentException;
use FOS\HttpCache\ProxyClient\Invalidation\BanInterface;
use FOS\HttpCache\ProxyClient\Invalidation\PurgeInterface;
use FOS\HttpCache\ProxyClient\Invalidation\RefreshInterface;
use FOS\HttpCache\ProxyClient\Invalidation\TagsInterface;

/**
 * Varnish HTTP cache invalidator.
 *
 * Additional constructor options:
 * - tags_header         Header for tagging responses, defaults to X-Cache-Tags
 * - header_length       Maximum header length, defaults to 7500 bytes
 * - default_ban_headers Map of headers that are set on each ban request,
 *                       merged with the built-in headers
 *
 * @author David de Boer <[email protected]>
 */
class Varnish extends HttpProxyClient implements BanInterface, PurgeInterface, RefreshInterface, TagsInterface
{
    const HTTP_METHOD_BAN = 'BAN';
    const HTTP_METHOD_PURGE = 'PURGE';
    const HTTP_METHOD_REFRESH = 'GET';
    const HTTP_HEADER_HOST = 'X-Host';
    const HTTP_HEADER_URL = 'X-Url';
    const HTTP_HEADER_CONTENT_TYPE = 'X-Content-Type';
    const DEFAULT_HTTP_HEADER_CACHE_TAGS = 'X-Cache-Tags';

    /**
     * {@inheritdoc}
     */
    public function invalidateTags(array $tags)
    {
        $escapedTags = array_map('preg_quote', $this->escapeTags($tags));

        if (mb_strlen(implode('|', $escapedTags)) >= $this->options['header_length']) {
            /*
             * estimate the amount of tags to invalidate by dividing the max
             * header length by the largest tag (minus 1 for the implode character)
             */
            $tagsize = max(array_map('mb_strlen', $escapedTags));
            $elems = floor($this->options['header_length'] / ($tagsize - 1)) ?: 1;
        } else {
            $elems = count($escapedTags);
        }

        foreach (array_chunk($escapedTags, $elems) as $tagchunk) {
            $tagExpression = sprintf('(%s)(,.+)?$', implode('|', $tagchunk));
            $this->ban([$this->options['tags_header'] => $tagExpression]);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getTagsHeaderValue(array $tags)
    {
        return implode(',', array_unique($this->escapeTags($tags)));
    }

    /**
     * {@inheritdoc}
     */
    public function getTagsHeaderName()
    {
        return $this->options['tags_header'];
    }

    /**
     * {@inheritdoc}
     */
    public function ban(array $headers)
    {
        $headers = array_merge(
            $this->options['default_ban_headers'],
            $headers
        );

        $this->queueRequest(self::HTTP_METHOD_BAN, '/', $headers);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function banPath($path, $contentType = null, $hosts = null)
    {
        if (is_array($hosts)) {
            if (!count($hosts)) {
                throw new InvalidArgumentException('Either supply a list of hosts or null, but not an empty array.');
            }
            $hosts = '^('.implode('|', $hosts).')$';
        }

        $headers = [
            self::HTTP_HEADER_URL => $path,
        ];

        if ($contentType) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $headers[self::HTTP_HEADER_CONTENT_TYPE] = $contentType;
        }
        if ($hosts) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $headers[self::HTTP_HEADER_HOST] = $hosts;
        }

        return $this->ban($headers);
    }

    /**
     * {@inheritdoc}
     */
    public function purge($url, array $headers = [])
    {
        $this->queueRequest(self::HTTP_METHOD_PURGE, $url, $headers);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function refresh($url, array $headers = [])

    {
        $headers = array_merge($headers, ['Cache-Control' => 'no-cache']);
        $this->queueRequest(self::HTTP_METHOD_REFRESH, $url, $headers);

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    protected function configureOptions()
    {
        $resolver = parent::configureOptions();
        $resolver->setDefaults([
            'tags_header' => self::DEFAULT_HTTP_HEADER_CACHE_TAGS,
            'header_length' => 7500,
            'default_ban_headers' => [],
        ]);
        $resolver->setNormalizer('default_ban_headers', function ($resolver, $specified) {
            return array_merge(
                [
                    self::HTTP_HEADER_HOST => self::REGEX_MATCH_ALL,
                    self::HTTP_HEADER_URL => self::REGEX_MATCH_ALL,
                    self::HTTP_HEADER_CONTENT_TYPE => self::REGEX_MATCH_ALL,
                ],
                $specified
            );
        });

        return $resolver;
    }
}


1			<?php
2
3			/*
4			* This file is part of the FOSHttpCache package.
5			*
6			* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace FOS\HttpCache\ProxyClient;
13
14			use FOS\HttpCache\Exception\InvalidArgumentException;
15			use FOS\HttpCache\ProxyClient\Invalidation\BanInterface;
16			use FOS\HttpCache\ProxyClient\Invalidation\PurgeInterface;
17			use FOS\HttpCache\ProxyClient\Invalidation\RefreshInterface;
18			use FOS\HttpCache\ProxyClient\Invalidation\TagsInterface;
19
20			/**
21			* Varnish HTTP cache invalidator.
22			*
23			* Additional constructor options:
24			* - tags_header Header for tagging responses, defaults to X-Cache-Tags
25			* - header_length Maximum header length, defaults to 7500 bytes
26			* - default_ban_headers Map of headers that are set on each ban request,
27			* merged with the built-in headers
28			*
29			* @author David de Boer <[email protected]>
30			*/
31			class Varnish extends HttpProxyClient implements BanInterface, PurgeInterface, RefreshInterface, TagsInterface
32			{
33			const HTTP_METHOD_BAN = 'BAN';
34			const HTTP_METHOD_PURGE = 'PURGE';
35			const HTTP_METHOD_REFRESH = 'GET';
36			const HTTP_HEADER_HOST = 'X-Host';
37			const HTTP_HEADER_URL = 'X-Url';
38			const HTTP_HEADER_CONTENT_TYPE = 'X-Content-Type';
39			const DEFAULT_HTTP_HEADER_CACHE_TAGS = 'X-Cache-Tags';
40
41			/**
42			* {@inheritdoc}
43			*/
44	4		public function invalidateTags(array $tags)
45			{
46	4		$escapedTags = array_map('preg_quote', $this->escapeTags($tags));
47
48	4		if (mb_strlen(implode('\|', $escapedTags)) >= $this->options['header_length']) {
49			/*
50			* estimate the amount of tags to invalidate by dividing the max
51			* header length by the largest tag (minus 1 for the implode character)
52			*/
53	1		$tagsize = max(array_map('mb_strlen', $escapedTags));
54	1		$elems = floor($this->options['header_length'] / ($tagsize - 1)) ?: 1;
55	1		} else {
56	3		$elems = count($escapedTags);
57			}
58
59	4		foreach (array_chunk($escapedTags, $elems) as $tagchunk) {
60	4		$tagExpression = sprintf('(%s)(,.+)?$', implode('\|', $tagchunk));
61	4		$this->ban([$this->options['tags_header'] => $tagExpression]);
62	4		}
63
64	4		return $this;
65			}
66
67			/**
68			* {@inheritdoc}
69			*/
70	1		public function getTagsHeaderValue(array $tags)
71			{
72	1		return implode(',', array_unique($this->escapeTags($tags)));
73			}
74
75			/**
76			* {@inheritdoc}
77			*/
78	1		public function getTagsHeaderName()
79			{
80	1		return $this->options['tags_header'];
81			}
82
83			/**
84			* {@inheritdoc}
85			*/
86	10		public function ban(array $headers)
87			{
88	10		$headers = array_merge(
89	10		$this->options['default_ban_headers'],
90			$headers
91	10		);
92
93	10		$this->queueRequest(self::HTTP_METHOD_BAN, '/', $headers);
94
95	10		return $this;
96			}
97
98			/**
99			* {@inheritdoc}
100			*/
101	4		public function banPath($path, $contentType = null, $hosts = null)
102			{
103	4		if (is_array($hosts)) {
104	2		if (!count($hosts)) {
105	1		throw new InvalidArgumentException('Either supply a list of hosts or null, but not an empty array.');
106			}
107	1		$hosts = '^('.implode('\|', $hosts).')$';
108	1		}
109
110			$headers = [
111	3		self::HTTP_HEADER_URL => $path,
112	3		];
113
114	3		if ($contentType) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-23 22:08 UTC by Report Bug Copy Issue Report The expression `$contentType` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
115	2		$headers[self::HTTP_HEADER_CONTENT_TYPE] = $contentType;
116	2		}
117	3		if ($hosts) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-23 22:08 UTC by Report Bug Copy Issue Report The expression `$hosts` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
118	1		$headers[self::HTTP_HEADER_HOST] = $hosts;
119	1		}
120
121	3		return $this->ban($headers);
122			}
123
124			/**
125			* {@inheritdoc}
126			*/
127	4		public function purge($url, array $headers = [])
128			{
129	4		$this->queueRequest(self::HTTP_METHOD_PURGE, $url, $headers);
130
131	4		return $this;
132			}
133
134			/**
135			* {@inheritdoc}
136			*/
137	3	View Code Duplication	public function refresh($url, array $headers = [])
			0 ignored issues – show Duplication introduced 2015-11-23 22:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
138			{
139	3		$headers = array_merge($headers, ['Cache-Control' => 'no-cache']);
140	3		$this->queueRequest(self::HTTP_METHOD_REFRESH, $url, $headers);
141
142	3		return $this;
143			}
144
145			/**
146			* {@inheritdoc}
147			*/
148	22		protected function configureOptions()
149			{
150	22		$resolver = parent::configureOptions();
151	22		$resolver->setDefaults([
152	22		'tags_header' => self::DEFAULT_HTTP_HEADER_CACHE_TAGS,
153	22		'header_length' => 7500,
154	22		'default_ban_headers' => [],
155	22		]);
156	22		$resolver->setNormalizer('default_ban_headers', function ($resolver, $specified) {
157	22		return array_merge(
158			[
159	22		self::HTTP_HEADER_HOST => self::REGEX_MATCH_ALL,
160	22		self::HTTP_HEADER_URL => self::REGEX_MATCH_ALL,
161	22		self::HTTP_HEADER_CONTENT_TYPE => self::REGEX_MATCH_ALL,
162	22		],
163			$specified
164	22		);
165	22		});
166
167	22		return $resolver;
168			}
169			}
170

FriendsOfSymfony / FOSHttpCache

Pull Request — master (#312)

Varnish::configureOptions() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like