FOS\HttpCache\Test\HttpClient

Complexity

Total Complexity

9

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

100%

Importance

Changes	2
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getResponse()	0	9	1
A	getHttpClient()	0	8	2
A	createUri()	0	4	1
B	createRequest()	0	22	4

<?php

/*
 * This file is part of the FOSHttpCache package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\HttpCache\Test;

use Http\Discovery\HttpClientDiscovery;
use Http\Discovery\MessageFactoryDiscovery;
use Http\Discovery\UriFactoryDiscovery;
use Http\Client\HttpClient as PhpHttpClient;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\UriInterface;

/**
 * Provides a very simple way to fetch HTTP responses, auto-creating a client.
 */
class HttpClient
{
    /**
     * HTTP client for requests to the application
     *
     * @var HttpClient
     */
    private $httpClient;

    /**
     * @var string
     */
    private $hostname;

    /**
     * @var string
     */
    private $port;

    /**
     * @param string $hostname Default hostname if not specified in the URL
     * @param string $port     Default port if not specified in the URL
     */
    public function __construct($hostname, $port)
    {
        $this->hostname = $hostname;
        $this->port = $port;
    }

    /**
     * Get HTTP response from your application
     *
     * @param string $uri     HTTP URI
     * @param array  $headers HTTP headers
     * @param string $method  HTTP method
     *
     * @return ResponseInterface
     */
    public function getResponse($uri, array $headers, $method)
    {
        // Close connections to make sure invalidation (PURGE/BAN) requests will
        // not interfere with content (GET) requests.
        $headers['Connection'] = 'Close';
        $request = $this->createRequest($method, $uri, $headers);

        return $this->getHttpClient()->sendRequest($request);
    }

    /**
     * Get HTTP adapter for your application
     *
     * @return PhpHttpClient
     */
    private function getHttpClient()
    {
        if ($this->httpClient === null) {
            $this->httpClient = HttpClientDiscovery::find();

It seems like \Http\Discovery\HttpClientDiscovery::find() of type object<Http\Client\HttpClient> is incompatible with the declared type object<FOS\HttpCache\Test\HttpClient> of property $httpClient.

        }

        return $this->httpClient;

The expression $this->httpClient; of type Http\Client\HttpClient|FOS\HttpCache\Test\HttpClient adds the type FOS\HttpCache\Test\HttpClient to the return on line 84 which is incompatible with the return type documented by FOS\HttpCache\Test\HttpClient::getHttpClient of type Http\Client\HttpClient.

    }

    /**
     * Create a request
     *
     * @param string $method
     * @param string $uri
     * @param array  $headers
     *
     * @return RequestInterface
     * @throws \Exception
     */
    private function createRequest($method, $uri, $headers)
    {
        $uri = $this->createUri($uri);
        if ($uri->getHost() === '') {
            // Add base URI host
            $uri = $uri->withHost($this->hostname);
        }

        if (!$uri->getPort()) {

The expression $uri->getPort() of type null|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            $uri = $uri->withPort($this->port);
        }

        if ($uri->getScheme() === '') {
            $uri = $uri->withScheme('http');
        }

        return MessageFactoryDiscovery::find()->createRequest(
            $method,
            $uri,
            $headers
        );
    }

    /**
     * Create PSR-7 URI object from URI string
     *
     * @param string $uriString
     *
     * @return UriInterface
     */
    private function createUri($uriString)
    {
        return UriFactoryDiscovery::find()->createUri($uriString);
    }
}