Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | class Varnish extends AbstractProxyClient implements BanInterface, PurgeInterface, RefreshInterface, TagsInterface |
||
31 | { |
||
32 | const HTTP_METHOD_BAN = 'BAN'; |
||
33 | const HTTP_METHOD_PURGE = 'PURGE'; |
||
34 | const HTTP_METHOD_REFRESH = 'GET'; |
||
35 | const HTTP_HEADER_HOST = 'X-Host'; |
||
36 | const HTTP_HEADER_URL = 'X-Url'; |
||
37 | const HTTP_HEADER_CONTENT_TYPE = 'X-Content-Type'; |
||
38 | |||
39 | /** |
||
40 | * Map of default headers for ban requests with their default values. |
||
41 | * |
||
42 | * @var array |
||
43 | */ |
||
44 | private $defaultBanHeaders = [ |
||
45 | self::HTTP_HEADER_HOST => self::REGEX_MATCH_ALL, |
||
46 | self::HTTP_HEADER_URL => self::REGEX_MATCH_ALL, |
||
47 | self::HTTP_HEADER_CONTENT_TYPE => self::REGEX_MATCH_ALL |
||
48 | ]; |
||
49 | |||
50 | /** |
||
51 | * Set the default headers that get merged with the provided headers in self::ban(). |
||
52 | * |
||
53 | * @param array $headers Hashmap with keys being the header names, values |
||
54 | * the header values. |
||
55 | */ |
||
56 | 2 | public function setDefaultBanHeaders(array $headers) |
|
57 | { |
||
58 | 2 | $this->defaultBanHeaders = $headers; |
|
59 | 2 | } |
|
60 | |||
61 | /** |
||
62 | * Add or overwrite a default ban header. |
||
63 | * |
||
64 | * @param string $name The name of that header |
||
65 | * @param string $value The content of that header |
||
66 | */ |
||
67 | 2 | public function setDefaultBanHeader($name, $value) |
|
68 | { |
||
69 | 2 | $this->defaultBanHeaders[$name] = $value; |
|
70 | 2 | } |
|
71 | |||
72 | /** |
||
73 | * {@inheritdoc} |
||
74 | */ |
||
75 | 3 | public function invalidateTags(array $tags) |
|
76 | { |
||
77 | 3 | $tagExpression = sprintf('(%s)(,.+)?$', implode('|', array_map('preg_quote', $this->escapeTags($tags)))); |
|
78 | |||
79 | 3 | return $this->ban([$this->options['tags_header'] => $tagExpression]); |
|
80 | } |
||
81 | |||
82 | /** |
||
83 | * {@inheritdoc} |
||
84 | */ |
||
85 | public function getTagsHeaderValue(array $tags) |
||
86 | { |
||
87 | return implode(',', array_unique($this->escapeTags($tags))); |
||
88 | } |
||
89 | |||
90 | /** |
||
91 | * Get the HTTP header name that will hold cache tags. |
||
92 | * |
||
93 | * @return string |
||
94 | */ |
||
95 | public function getTagsHeaderName() |
||
96 | { |
||
97 | return $this->options['tags_header']; |
||
98 | } |
||
99 | |||
100 | /** |
||
101 | * {@inheritdoc} |
||
102 | */ |
||
103 | 11 | public function ban(array $headers) |
|
104 | { |
||
105 | 11 | $headers = array_merge( |
|
106 | 11 | $this->defaultBanHeaders, |
|
107 | $headers |
||
108 | 11 | ); |
|
109 | |||
110 | 11 | $this->queueRequest(self::HTTP_METHOD_BAN, '/', $headers); |
|
111 | |||
112 | 11 | return $this; |
|
113 | } |
||
114 | |||
115 | /** |
||
116 | * {@inheritdoc} |
||
117 | */ |
||
118 | 4 | public function banPath($path, $contentType = null, $hosts = null) |
|
119 | { |
||
120 | 4 | if (is_array($hosts)) { |
|
121 | 2 | if (!count($hosts)) { |
|
122 | 1 | throw new InvalidArgumentException('Either supply a list of hosts or null, but not an empty array.'); |
|
123 | } |
||
124 | 1 | $hosts = '^('.join('|', $hosts).')$'; |
|
125 | 1 | } |
|
126 | |||
127 | $headers = [ |
||
128 | 3 | self::HTTP_HEADER_URL => $path, |
|
129 | 3 | ]; |
|
130 | |||
131 | 3 | if ($contentType) { |
|
|
|||
132 | 2 | $headers[self::HTTP_HEADER_CONTENT_TYPE] = $contentType; |
|
133 | 2 | } |
|
134 | 3 | if ($hosts) { |
|
135 | 1 | $headers[self::HTTP_HEADER_HOST] = $hosts; |
|
136 | 1 | } |
|
137 | |||
138 | 3 | return $this->ban($headers); |
|
139 | } |
||
140 | |||
141 | /** |
||
142 | * {@inheritdoc} |
||
143 | */ |
||
144 | 11 | public function purge($url, array $headers = []) |
|
145 | { |
||
146 | 11 | $this->queueRequest(self::HTTP_METHOD_PURGE, $url, $headers); |
|
147 | |||
148 | 10 | return $this; |
|
149 | } |
||
150 | |||
151 | /** |
||
152 | * {@inheritdoc} |
||
153 | */ |
||
154 | 3 | View Code Duplication | public function refresh($url, array $headers = []) |
161 | |||
162 | /** |
||
163 | * {@inheritdoc} |
||
164 | */ |
||
165 | 32 | protected function getDefaultOptions() |
|
172 | |||
173 | /** |
||
174 | * Build the invalidation request and validate it. |
||
175 | * |
||
176 | * {@inheritdoc} |
||
177 | * |
||
178 | * @throws MissingHostException If a relative path is queued for purge/ |
||
179 | * refresh and no base URL is set |
||
180 | * |
||
181 | */ |
||
182 | 25 | protected function queueRequest($method, $url, array $headers = []) |
|
195 | } |
||
196 |
In PHP, under loose comparison (like
==
, or!=
, orswitch
conditions), values of different types might be equal.For
string
values, the empty string''
is a special case, in particular the following results might be unexpected: