WebServerListener::startTest() - Code Metrics - Inspection of "Update to PHPUnit 5.4+/6.x" - FriendsOfSymfony/FOSHttpCache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#365)

by Alessandro

created 2017-08-09 13:52 UTC

WebServerListener::startTest() A

↳ Parent: WebServerListener

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	3
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	3
loc	3
ccs	0
cts	3
cp	0
rs	10
c	1
b	0
f	0
cc	1
eloc	1
nc	1
nop	1
crap	2

<?php

/*
 * This file is part of the FOSHttpCache package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\HttpCache\Test\Legacy;

use FOS\HttpCache\Test\WebServerListenerTrait;
use PHPUnit\Framework\TestListener;

/**
 * A PHPUnit test listener that starts and stops the PHP built-in web server.
 *
 * This listener is configured with a couple of constants from the phpunit.xml
 * file. To define constants in the phpunit file, use this syntax:
 * <php>
 *     <const name="WEB_SERVER_HOSTNAME" value="localhost" />
 * </php>
 *
 * WEB_SERVER_HOSTNAME host name of the web server (required)
 * WEB_SERVER_PORT     port to listen on (required)
 * WEB_SERVER_DOCROOT  path to the document root for the server (required)
 */
class WebServerListener implements TestListener

{
    /** @var WebServerListenerTrait */
    private $trait;

    public function __construct()
    {
        $this->trait = new WebServerListenerTrait();
    }

    /**
     * Make sure the PHP built-in web server is running for tests with group
     * 'webserver'.
     */
    public function startTestSuite(\PHPUnit_Framework_TestSuite $suite)
    {
        $this->trait->startTestSuite($suite);
    }

    /**
     *  We don't need these.
     */
    public function endTestSuite(\PHPUnit_Framework_TestSuite $suite)
    {
    }

    public function addError(\PHPUnit_Framework_Test $test, \Exception $e, $time)
    {
    }

    public function addFailure(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_AssertionFailedError $e, $time)
    {
    }

    public function addIncompleteTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
    {
    }

    public function addSkippedTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
    {
    }

    public function startTest(\PHPUnit_Framework_Test $test)
    {
    }

    public function endTest(\PHPUnit_Framework_Test $test, $time)
    {
    }

    public function addRiskyTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
    {
    }

    /**
     * Get web server hostname.
     *
     * @throws \Exception
     *
     * @return string
     */
    protected function getHostName()
    {
        return $this->trait->getHostName();
    }

    /**
     * Get web server port.
     *
     * @throws \Exception
     *
     * @return int
     */
    protected function getPort()
    {
        return $this->trait->getPort();
    }

    /**
     * Get web server port.
     *
     * @throws \Exception
     *
     * @return int
     */
    protected function getDocRoot()
    {
        return $this->trait->getDocRoot();
    }

    /**
     * Start PHP built-in web server.
     *
     * @return int PID
     */
    protected function startPhpWebServer()
    {
        return $this->trait->startPhpWebServer();
    }

    /**
     * Wait for caching proxy to be started up and reachable.
     *
     * @param string $ip
     * @param int    $port
     * @param int    $timeout Timeout in milliseconds
     *
     * @throws \RuntimeException If proxy is not reachable within timeout
     */
    protected function waitFor($ip, $port, $timeout)
    {
        $this->trait->waitFor($ip, $port, $timeout);
    }
}


1		<?php
2
3		/*
4		* This file is part of the FOSHttpCache package.
5		*
6		* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace FOS\HttpCache\Test\Legacy;
13
14		use FOS\HttpCache\Test\WebServerListenerTrait;
15		use PHPUnit\Framework\TestListener;
16
17		/**
18		* A PHPUnit test listener that starts and stops the PHP built-in web server.
19		*
20		* This listener is configured with a couple of constants from the phpunit.xml
21		* file. To define constants in the phpunit file, use this syntax:
22		* <php>
23		* <const name="WEB_SERVER_HOSTNAME" value="localhost" />
24		* </php>
25		*
26		* WEB_SERVER_HOSTNAME host name of the web server (required)
27		* WEB_SERVER_PORT port to listen on (required)
28		* WEB_SERVER_DOCROOT path to the document root for the server (required)
29		*/
30	View Code Duplication	class WebServerListener implements TestListener
		0 ignored issues – show Bug introduced 2017-08-09 11:03 UTC by Report Bug Copy Issue Report There is one abstract method `addWarning` in this class; you could implement it, or declare this class as abstract. Loading history... Duplication introduced 2017-08-09 11:03 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		/** @var WebServerListenerTrait */
33		private $trait;
34
35		public function __construct()
36		{
37		$this->trait = new WebServerListenerTrait();
38		}
39
40		/**
41		* Make sure the PHP built-in web server is running for tests with group
42		* 'webserver'.
43		*/
44		public function startTestSuite(\PHPUnit_Framework_TestSuite $suite)
45		{
46		$this->trait->startTestSuite($suite);
47		}
48
49		/**
50		* We don't need these.
51		*/
52		public function endTestSuite(\PHPUnit_Framework_TestSuite $suite)
53		{
54		}
55
56		public function addError(\PHPUnit_Framework_Test $test, \Exception $e, $time)
57		{
58		}
59
60		public function addFailure(\PHPUnit_Framework_Test $test, \PHPUnit_Framework_AssertionFailedError $e, $time)
61		{
62		}
63
64		public function addIncompleteTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
65		{
66		}
67
68		public function addSkippedTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
69		{
70		}
71
72		public function startTest(\PHPUnit_Framework_Test $test)
73		{
74		}
75
76		public function endTest(\PHPUnit_Framework_Test $test, $time)
77		{
78		}
79
80		public function addRiskyTest(\PHPUnit_Framework_Test $test, \Exception $e, $time)
81		{
82		}
83
84		/**
85		* Get web server hostname.
86		*
87		* @throws \Exception
88		*
89		* @return string
90		*/
91		protected function getHostName()
92		{
93		return $this->trait->getHostName();
94		}
95
96		/**
97		* Get web server port.
98		*
99		* @throws \Exception
100		*
101		* @return int
102		*/
103		protected function getPort()
104		{
105		return $this->trait->getPort();
106		}
107
108		/**
109		* Get web server port.
110		*
111		* @throws \Exception
112		*
113		* @return int
114		*/
115		protected function getDocRoot()
116		{
117		return $this->trait->getDocRoot();
118		}
119
120		/**
121		* Start PHP built-in web server.
122		*
123		* @return int PID
124		*/
125		protected function startPhpWebServer()
126		{
127		return $this->trait->startPhpWebServer();
128		}
129
130		/**
131		* Wait for caching proxy to be started up and reachable.
132		*
133		* @param string $ip
134		* @param int $port
135		* @param int $timeout Timeout in milliseconds
136		*
137		* @throws \RuntimeException If proxy is not reachable within timeout
138		*/
139		protected function waitFor($ip, $port, $timeout)
140		{
141		$this->trait->waitFor($ip, $port, $timeout);
142		}
143		}
144

FriendsOfSymfony / FOSHttpCache

Pull Request — master (#365)

WebServerListener::startTest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like