FOS\HttpCache\SymfonyCache\RefreshListener::handleRefresh()

Complexity

Conditions	5
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes

0

<?php
    public function handleRefresh(CacheEvent $event)
    {
        $request = $event->getRequest();
        // BC - we can drop this check when we only support Symfony 3.1 and newer
        $cacheable = method_exists(Request::class, 'isMethodCacheable')
            ? $request->isMethodCacheable()
            : $request->isMethodSafe(false);

The call to Symfony\Component\HttpFoundation\Request::isMethodSafe() has too many arguments starting with false.

        if (!$cacheable
            || !$request->isNoCache()
            || !$this->isRequestAllowed($request)
        ) {
            return;
        }

        $event->setResponse(
            $event->getKernel()->fetch($request)

The method fetch() does not exist on FOS\HttpCache\SymfonyCache\CacheInvalidation. Since it exists in all sub-types, consider adding an abstract or default implementation to FOS\HttpCache\SymfonyCache\CacheInvalidation.

        );