InPlacePagerPersister::insert() - Code Metrics - Inspection of "4x to master" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1320)

by Maksim

created 2017-12-06 21:06 UTC

InPlacePagerPersister::insert() B

↳ Parent: InPlacePagerPersister

Complexity

Conditions	6
Paths	59

Size

Total Lines	57
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	57
rs	8.7433
c	0
b	0
f	0
cc	6
eloc	36
nc	59
nop	2

How to fix Long Method

<?php

namespace FOS\ElasticaBundle\Persister;

use FOS\ElasticaBundle\Persister\Event\Events;
use FOS\ElasticaBundle\Persister\Event\OnExceptionEvent;
use FOS\ElasticaBundle\Persister\Event\PostInsertObjectsEvent;
use FOS\ElasticaBundle\Persister\Event\PostPersistEvent;
use FOS\ElasticaBundle\Persister\Event\PreFetchObjectsEvent;
use FOS\ElasticaBundle\Persister\Event\PreInsertObjectsEvent;
use FOS\ElasticaBundle\Persister\Event\PrePersistEvent;
use FOS\ElasticaBundle\Provider\PagerInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

final class InPlacePagerPersister implements PagerPersisterInterface
{
    /**
     * @var PersisterRegistry
     */
    private $registry;
    
    /**
     * @var EventDispatcherInterface
     */
    private $dispatcher;

    /**
     * @param PersisterRegistry $registry
     * @param EventDispatcherInterface $dispatcher
     */
    public function __construct(PersisterRegistry $registry, EventDispatcherInterface $dispatcher)
    {
        $this->registry = $registry;
        $this->dispatcher = $dispatcher;
    }

    /**
     * {@inheritdoc}
     */
    public function insert(PagerInterface $pager, array $options = array())
    {
        $objectPersister = $this->registry->getPersister($options['indexName'], $options['typeName']);

        $event = new PrePersistEvent($pager, $objectPersister, $options);
        $this->dispatcher->dispatch(Events::PRE_PERSIST, $event);
        $pager = $event->getPager();
        $options = $event->getOptions();

        $pager->setMaxPerPage($options['batch_size']);

        $page = $pager->getCurrentPage();
        while ($page <= $pager->getNbPages()) {
            try {
                $pager->setCurrentPage($page);

                $event = new PreFetchObjectsEvent($pager, $objectPersister, $options);
                $this->dispatcher->dispatch(Events::PRE_FETCH_OBJECTS, $event);
                $pager = $event->getPager();
                $options = $event->getOptions();

                $objects = $pager->getCurrentPageResults();

                if ($objects instanceof \Traversable) {
                    $objects = iterator_to_array($objects);
                }

                $event = new PreInsertObjectsEvent($pager, $objectPersister, $objects, $options);
                $this->dispatcher->dispatch(Events::PRE_INSERT_OBJECTS, $event);
                $pager = $event->getPager();
                $options = $event->getOptions();
                $objects = $event->getObjects();

                if (!empty($objects)) {
                    $objectPersister->insertMany($objects);
                }

                $event = new PostInsertObjectsEvent($pager, $objectPersister, $objects, $options);
                $this->dispatcher->dispatch(Events::POST_INSERT_OBJECTS, $event);
            } catch (\Exception $e) {
                $event = new OnExceptionEvent($pager, $objectPersister, $e, $options);
                $this->dispatcher->dispatch(Events::ON_EXCEPTION, $event);

                if (false == $event->isIgnored()) {

                    $e = $event->getException();

                    throw $e;
                }
            }

            $pager->setCurrentPage($page++);
        }

        $event = new PostPersistEvent($pager, $objectPersister, $options);
        $this->dispatcher->dispatch(Events::POST_PERSIST, $event);

    }
}


1			<?php
2
3			namespace FOS\ElasticaBundle\Persister;
4
5			use FOS\ElasticaBundle\Persister\Event\Events;
6			use FOS\ElasticaBundle\Persister\Event\OnExceptionEvent;
7			use FOS\ElasticaBundle\Persister\Event\PostInsertObjectsEvent;
8			use FOS\ElasticaBundle\Persister\Event\PostPersistEvent;
9			use FOS\ElasticaBundle\Persister\Event\PreFetchObjectsEvent;
10			use FOS\ElasticaBundle\Persister\Event\PreInsertObjectsEvent;
11			use FOS\ElasticaBundle\Persister\Event\PrePersistEvent;
12			use FOS\ElasticaBundle\Provider\PagerInterface;
13			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
14
15			final class InPlacePagerPersister implements PagerPersisterInterface
16			{
17			/**
18			* @var PersisterRegistry
19			*/
20			private $registry;
21
22			/**
23			* @var EventDispatcherInterface
24			*/
25			private $dispatcher;
26
27			/**
28			* @param PersisterRegistry $registry
29			* @param EventDispatcherInterface $dispatcher
30			*/
31			public function __construct(PersisterRegistry $registry, EventDispatcherInterface $dispatcher)
32			{
33			$this->registry = $registry;
34			$this->dispatcher = $dispatcher;
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			public function insert(PagerInterface $pager, array $options = array())
41			{
42			$objectPersister = $this->registry->getPersister($options['indexName'], $options['typeName']);
43
44			$event = new PrePersistEvent($pager, $objectPersister, $options);
45			$this->dispatcher->dispatch(Events::PRE_PERSIST, $event);
46			$pager = $event->getPager();
47			$options = $event->getOptions();
48
49			$pager->setMaxPerPage($options['batch_size']);
50
51			$page = $pager->getCurrentPage();
52			while ($page <= $pager->getNbPages()) {
53			try {
54			$pager->setCurrentPage($page);
55
56			$event = new PreFetchObjectsEvent($pager, $objectPersister, $options);
57			$this->dispatcher->dispatch(Events::PRE_FETCH_OBJECTS, $event);
58			$pager = $event->getPager();
59			$options = $event->getOptions();
60
61			$objects = $pager->getCurrentPageResults();
62
63			if ($objects instanceof \Traversable) {
64			$objects = iterator_to_array($objects);
65			}
66
67			$event = new PreInsertObjectsEvent($pager, $objectPersister, $objects, $options);
68			$this->dispatcher->dispatch(Events::PRE_INSERT_OBJECTS, $event);
69			$pager = $event->getPager();
70			$options = $event->getOptions();
71			$objects = $event->getObjects();
72
73			if (!empty($objects)) {
74			$objectPersister->insertMany($objects);
75			}
76
77			$event = new PostInsertObjectsEvent($pager, $objectPersister, $objects, $options);
78			$this->dispatcher->dispatch(Events::POST_INSERT_OBJECTS, $event);
79			} catch (\Exception $e) {
80			$event = new OnExceptionEvent($pager, $objectPersister, $e, $options);
81			$this->dispatcher->dispatch(Events::ON_EXCEPTION, $event);
82
83			if (false == $event->isIgnored()) {
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
84			$e = $event->getException();
85
86			throw $e;
87			}
88			}
89
90			$pager->setCurrentPage($page++);
91			}
92
93			$event = new PostPersistEvent($pager, $objectPersister, $options);
94			$this->dispatcher->dispatch(Events::POST_PERSIST, $event);
95
96			}
97			}
98

FriendsOfSymfony / FOSElasticaBundle

Pull Request — master (#1320)

InPlacePagerPersister::insert() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like