PropertyPathTest::testContainerSource() - Code Metrics - Inspection of "Unused dependencies" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1339)

by Maksim

created 2017-12-12 16:13 UTC

PropertyPathTest::testContainerSource() A

↳ Parent: PropertyPathTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	12
nc	1
nop	0

<?php

/*
 * This file is part of the FOSElasticaBundle package.
 *
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

/**
 * This file is part of the FOSElasticaBundle project.
 *
 * (c) Tim Nagel <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace FOS\ElasticaBundle\Tests\Functional;

use Elastica\Query\Match;

/**
 * @group functional
 */
class PropertyPathTest extends WebTestCase
{
    public function testContainerSource()
    {
        static::bootKernel(['test_case' => 'ORM']);
        /** @var \FOS\ElasticaBundle\Persister\ObjectPersister $persister */
        $persister = static::$kernel->getContainer()->get('fos_elastica.object_persister.index.property_paths_type');
        $obj = new TypeObj();
        $obj->coll = 'Hello';
        $persister->insertOne($obj);

        /** @var \Elastica\Index $index */
        $index = static::$kernel->getContainer()->get('fos_elastica.index.index');
        $index->refresh();

        $query = new Match();
        $query->setField('something', 'Hello');
        $search = $index->createSearch($query);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertSame(1, $search->count());
    }
}


1			<?php
2
3			/*
4			* This file is part of the FOSElasticaBundle package.
5			*
6			* (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			/**
13			* This file is part of the FOSElasticaBundle project.
14			*
15			* (c) Tim Nagel <[email protected]>
16			*
17			* This source file is subject to the MIT license that is bundled
18			* with this source code in the file LICENSE.
19			*/
20
21			namespace FOS\ElasticaBundle\Tests\Functional;
22
23			use Elastica\Query\Match;
24
25			/**
26			* @group functional
27			*/
28			class PropertyPathTest extends WebTestCase
29			{
30			public function testContainerSource()
31			{
32			static::bootKernel(['test_case' => 'ORM']);
33			/** @var \FOS\ElasticaBundle\Persister\ObjectPersister $persister */
34			$persister = static::$kernel->getContainer()->get('fos_elastica.object_persister.index.property_paths_type');
35			$obj = new TypeObj();
36			$obj->coll = 'Hello';
37			$persister->insertOne($obj);
38
39			/** @var \Elastica\Index $index */
40			$index = static::$kernel->getContainer()->get('fos_elastica.index.index');
41			$index->refresh();
42
43			$query = new Match();
44			$query->setField('something', 'Hello');
45			$search = $index->createSearch($query);
			0 ignored issues – show Documentation introduced 2017-01-26 15:08 UTC by Report Bug Copy Issue Report `$query` is of type `object<Elastica\Query\Match>`, but the function expects a `string\|array\|object<Elastica\Query>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46
47			$this->assertSame(1, $search->count());
48			}
49			}
50

FriendsOfSymfony / FOSElasticaBundle

Pull Request — master (#1339)

PropertyPathTest::testContainerSource() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like