Completed
Pull Request — master (#1569)
by
unknown
03:13
created

Configuration::getTypesNode()   A

Complexity

Conditions 3
Paths 1

Size

Total Lines 52

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 36
CRAP Score 3.0001

Importance

Changes 0
Metric Value
dl 0
loc 52
c 0
b 0
f 0
ccs 36
cts 37
cp 0.973
rs 9.0472
cc 3
nc 1
nop 0
crap 3.0001

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
/*
4
 * This file is part of the FOSElasticaBundle package.
5
 *
6
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace FOS\ElasticaBundle\DependencyInjection;
13
14
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
15
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
16
use Symfony\Component\Config\Definition\ConfigurationInterface;
17
18
class Configuration implements ConfigurationInterface
19
{
20
    private const SUPPORTED_DRIVERS = ['orm', 'mongodb', 'phpcr'];
21
22
    /**
23
     * If the kernel is running in debug mode.
24
     *
25
     * @var bool
26
     */
27
    private $debug;
28
29 34
    public function __construct($debug)
30
    {
31 34
        $this->debug = $debug;
32 34
    }
33
34
    /**
35
     * Generates the configuration tree.
36
     *
37
     * @return TreeBuilder
38
     */
39 34
    public function getConfigTreeBuilder()
40
    {
41 34
        $treeBuilder = new TreeBuilder('fos_elastica');
42 34
        $rootNode = $treeBuilder->getRootNode();
43
44 34
        $this->addClientsSection($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
45 34
        $this->addIndexesSection($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
46 34
        $this->addIndexTemplatesSection($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
47
48
        $rootNode
49 34
            ->children()
50 34
                ->scalarNode('default_client')
51 34
                    ->info('Defaults to the first client defined')
52 34
                ->end()
53 34
                ->scalarNode('default_index')
54 34
                    ->info('Defaults to the first index defined')
55 34
                ->end()
56 34
                ->scalarNode('default_manager')->defaultValue('orm')->end()
57 34
                ->arrayNode('serializer')
58 34
                    ->treatNullLike([])
59 34
                    ->children()
60 34
                        ->scalarNode('callback_class')->defaultValue('FOS\ElasticaBundle\Serializer\Callback')->end()
61 34
                        ->scalarNode('serializer')->defaultValue('serializer')->end()
62 34
                    ->end()
63 34
                ->end()
64 34
            ->end()
65
        ;
66
67 34
        return $treeBuilder;
68
    }
69
70
    /**
71
     * Returns the array node used for "dynamic_templates".
72
     */
73 34
    private function getDynamicTemplateNode()
74
    {
75 34
        $node = $this->createTreeBuilderNode('dynamic_templates');
76
77
        $node
78 34
            ->prototype('array')
79 34
                ->prototype('array')
80 34
                    ->children()
81 34
                        ->scalarNode('match')->end()
82 34
                        ->scalarNode('unmatch')->end()
83 34
                        ->scalarNode('match_mapping_type')->end()
84 34
                        ->scalarNode('path_match')->end()
85 34
                        ->scalarNode('path_unmatch')->end()
86 34
                        ->scalarNode('match_pattern')->end()
87 34
                        ->arrayNode('mapping')
88 34
                            ->prototype('variable')
89 34
                                ->treatNullLike([])
90 34
                            ->end()
91 34
                        ->end()
92 34
                    ->end()
93 34
                ->end()
94 34
            ->end()
95
        ;
96
97 34
        return $node;
98
    }
99
100
    /**
101
     * Returns the array node used for "types".
102
     */
103 34
    private function getTypesNode()
104
    {
105 34
        $node = $this->createTreeBuilderNode('types');
106
107
        $node
0 ignored issues
show
Bug introduced by
The method useAttributeAsKey() does not exist on Symfony\Component\Config...\Builder\NodeDefinition. Did you maybe mean attribute()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
108 34
            ->useAttributeAsKey('name')
109 34
            ->prototype('array')
110 34
                ->treatNullLike([])
111 34
                ->beforeNormalization()
112 34
                ->ifNull()
113 34
                    ->thenEmptyArray()
114 34
                ->end()
115
                // Support multiple dynamic_template formats to match the old bundle style
116
                // and the way ElasticSearch expects them
117 34
                ->beforeNormalization()
118
                ->ifTrue(function ($v) {
119 24
                    return isset($v['dynamic_templates']);
120 34
                })
121
                ->then(function ($v) {
122 5
                    $dt = [];
123 5
                    foreach ($v['dynamic_templates'] as $key => $type) {
124 5
                        if (is_int($key)) {
125 5
                            $dt[] = $type;
126
                        } else {
127
                            $dt[][$key] = $type;
128
                        }
129
                    }
130
131 5
                    $v['dynamic_templates'] = $dt;
132
133 5
                    return $v;
134 34
                })
135 34
                ->end()
136 34
                ->children()
137 34
                    ->booleanNode('date_detection')->end()
138 34
                    ->arrayNode('dynamic_date_formats')->prototype('scalar')->end()->end()
139 34
                    ->scalarNode('analyzer')->end()
140 34
                    ->booleanNode('numeric_detection')->end()
141 34
                    ->scalarNode('dynamic')->end()
142 34
                    ->append($this->getSerializerNode())
143 34
                ->end()
144 34
                ->append($this->getIdNode())
145 34
                ->append($this->getPropertiesNode())
146 34
                ->append($this->getDynamicTemplateNode())
147 34
                ->append($this->getSourceNode())
148 34
                ->append($this->getRoutingNode())
149 34
                ->append($this->getAllNode())
150 34
            ->end()
151
        ;
152
153 34
        return $node;
154
    }
155
156
    /**
157
     * Returns the array node used for "properties".
158
     */
159 34
    private function getPropertiesNode()
160
    {
161 34
        $node = $this->createTreeBuilderNode('properties');
162
163
        $node
0 ignored issues
show
Bug introduced by
The method useAttributeAsKey() does not exist on Symfony\Component\Config...\Builder\NodeDefinition. Did you maybe mean attribute()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
164 34
            ->useAttributeAsKey('name')
165 34
            ->prototype('variable')
166 34
                ->treatNullLike([]);
167
168 34
        return $node;
169
    }
170
171
    /**
172
     * Returns the array node used for "_id".
173
     */
174 34
    private function getIdNode()
175
    {
176 34
        $node = $this->createTreeBuilderNode('_id');
177
178
        $node
179 34
            ->children()
180 34
            ->scalarNode('path')->end()
181 34
            ->end()
182
        ;
183
184 34
        return $node;
185
    }
186
187
    /**
188
     * Returns the array node used for "_source".
189
     */
190 34
    private function getSourceNode()
191
    {
192 34
        $node = $this->createTreeBuilderNode('_source');
193
194
        $node
195 34
            ->children()
196 34
                ->arrayNode('excludes')
197 34
                    ->useAttributeAsKey('name')
198 34
                    ->prototype('scalar')->end()
199 34
                ->end()
200 34
                ->arrayNode('includes')
201 34
                    ->useAttributeAsKey('name')
202 34
                    ->prototype('scalar')->end()
203 34
                ->end()
204 34
                ->scalarNode('compress')->end()
205 34
                ->scalarNode('compress_threshold')->end()
206 34
                ->scalarNode('enabled')->defaultTrue()->end()
207 34
            ->end()
208
        ;
209
210 34
        return $node;
211
    }
212
213
    /**
214
     * Returns the array node used for "_routing".
215
     */
216 34
    private function getRoutingNode()
217
    {
218 34
        $node = $this->createTreeBuilderNode('_routing');
219
220
        $node
221 34
            ->children()
222 34
                ->scalarNode('required')->end()
223 34
                ->scalarNode('path')->end()
224 34
            ->end()
225
        ;
226
227 34
        return $node;
228
    }
229
230
    /**
231
     * Returns the array node used for "_all".
232
     */
233 34
    private function getAllNode()
234
    {
235 34
        $node = $this->createTreeBuilderNode('_all');
236
237
        $node
238 34
            ->children()
239 34
            ->scalarNode('enabled')->defaultValue(true)->end()
240 34
            ->scalarNode('analyzer')->end()
241 34
            ->end()
242
        ;
243
244 34
        return $node;
245
    }
246
247
    /**
248
     * @return ArrayNodeDefinition|\Symfony\Component\Config\Definition\Builder\NodeDefinition
249
     */
250 34
    private function getPersistenceNode()
251
    {
252 34
        $node = $this->createTreeBuilderNode('persistence');
253
254
        $node
255 34
            ->validate()
256
                ->ifTrue(function ($v) {
257 16
                    return isset($v['driver']) && 'orm' !== $v['driver'] && !empty($v['elastica_to_model_transformer']['hints']);
258 34
                })
259 34
                    ->thenInvalid('Hints are only supported by the "orm" driver')
260 34
            ->end()
261 34
            ->children()
262 34
                ->scalarNode('driver')
263 34
                    ->defaultValue('orm')
264 34
                    ->validate()
265 34
                    ->ifNotInArray(self::SUPPORTED_DRIVERS)
266 34
                        ->thenInvalid('The driver %s is not supported. Please choose one of '.json_encode(self::SUPPORTED_DRIVERS))
267 34
                    ->end()
268 34
                ->end()
269 34
                ->scalarNode('model')->defaultValue(null)->end()
270 34
                ->scalarNode('repository')->end()
271 34
                ->scalarNode('identifier')->defaultValue('id')->end()
272 34
                ->arrayNode('provider')
273 34
                    ->addDefaultsIfNotSet()
274 34
                    ->children()
275 34
                        ->scalarNode('batch_size')->defaultValue(100)->end()
276 34
                        ->scalarNode('clear_object_manager')->defaultTrue()->end()
277 34
                        ->scalarNode('debug_logging')
278 34
                            ->defaultValue($this->debug)
279 34
                            ->treatNullLike(true)
280 34
                        ->end()
281 34
                        ->scalarNode('query_builder_method')->defaultValue('createQueryBuilder')->end()
282 34
                        ->scalarNode('service')->end()
283 34
                    ->end()
284 34
                ->end()
285 34
                ->arrayNode('listener')
286 34
                    ->addDefaultsIfNotSet()
287 34
                    ->children()
288 34
                        ->booleanNode('enabled')->defaultTrue()->end()
289 34
                        ->scalarNode('insert')->defaultTrue()->end()
290 34
                        ->scalarNode('update')->defaultTrue()->end()
291 34
                        ->scalarNode('delete')->defaultTrue()->end()
292 34
                        ->scalarNode('flush')->defaultTrue()->end()
293 34
                        ->booleanNode('defer')->defaultFalse()->end()
294 34
                        ->scalarNode('logger')
295 34
                            ->defaultFalse()
296 34
                            ->treatNullLike('fos_elastica.logger')
297 34
                            ->treatTrueLike('fos_elastica.logger')
298 34
                        ->end()
299 34
                        ->scalarNode('service')->end()
300 34
                    ->end()
301 34
                ->end()
302 34
                ->arrayNode('finder')
303 34
                    ->addDefaultsIfNotSet()
304 34
                    ->children()
305 34
                        ->scalarNode('service')->end()
306 34
                    ->end()
307 34
                ->end()
308 34
                ->arrayNode('elastica_to_model_transformer')
309 34
                    ->addDefaultsIfNotSet()
310 34
                    ->children()
311 34
                        ->arrayNode('hints')
312 34
                            ->prototype('array')
313 34
                                ->children()
314 34
                                    ->scalarNode('name')->end()
315 34
                                    ->scalarNode('value')->end()
316 34
                                ->end()
317 34
                            ->end()
318 34
                        ->end()
319 34
                        ->booleanNode('hydrate')->defaultTrue()->end()
320 34
                        ->booleanNode('ignore_missing')
321 34
                            ->defaultFalse()
322 34
                            ->info('Silently ignore results returned from Elasticsearch without corresponding persistent object.')
323 34
                        ->end()
324 34
                        ->scalarNode('query_builder_method')->defaultValue('createQueryBuilder')->end()
325 34
                        ->scalarNode('service')->end()
326 34
                    ->end()
327 34
                ->end()
328 34
                ->arrayNode('model_to_elastica_transformer')
329 34
                    ->addDefaultsIfNotSet()
330 34
                    ->children()
331 34
                        ->scalarNode('service')->end()
332 34
                    ->end()
333 34
                ->end()
334 34
                ->arrayNode('persister')
335 34
                    ->addDefaultsIfNotSet()
336 34
                    ->children()
337 34
                        ->enumNode('refresh')
338 34
                            ->treatTrueLike('true')
339 34
                            ->treatFalseLike('false')
340 34
                            ->values(['true', 'wait_for', 'false'])
341 34
                        ->end()
342 34
                        ->scalarNode('service')->end()
343 34
                    ->end()
344 34
                ->end()
345 34
            ->end();
346
347 34
        return $node;
348
    }
349
350
    /**
351
     * @return ArrayNodeDefinition|\Symfony\Component\Config\Definition\Builder\NodeDefinition
352
     */
353 34
    private function getSerializerNode()
354
    {
355 34
        $node = $this->createTreeBuilderNode('serializer');
356
357
        $node
358 34
            ->addDefaultsIfNotSet()
359 34
            ->children()
360 34
                ->arrayNode('groups')
361 34
                    ->treatNullLike([])
362 34
                    ->prototype('scalar')->end()
363 34
                ->end()
364 34
                ->scalarNode('version')->end()
365 34
                ->booleanNode('serialize_null')
366 34
                    ->defaultFalse()
367 34
                ->end()
368 34
            ->end();
369
370 34
        return $node;
371
    }
372
373
    /**
374
     * Adds the configuration for the "clients" key.
375
     */
376 34
    private function addClientsSection(ArrayNodeDefinition $rootNode)
377
    {
378
        $rootNode
379 34
            ->fixXmlConfig('client')
380 34
            ->children()
381 34
                ->arrayNode('clients')
382 34
                    ->useAttributeAsKey('id')
383 34
                    ->prototype('array')
384 34
                        ->performNoDeepMerging()
385
                        // Elastica names its properties with camel case, support both
386 34
                        ->beforeNormalization()
387
                        ->ifTrue(function ($v) {
388 32
                            return isset($v['connection_strategy']);
389 34
                        })
390
                        ->then(function ($v) {
391 5
                            $v['connectionStrategy'] = $v['connection_strategy'];
392 5
                            unset($v['connection_strategy']);
393
394 5
                            return $v;
395 34
                        })
396 34
                        ->end()
397
                        // If there is no connections array key defined, assume a single connection.
398 34
                        ->beforeNormalization()
399
                        ->ifTrue(function ($v) {
400 32
                            return is_array($v) && !array_key_exists('connections', $v);
401 34
                        })
402
                        ->then(function ($v) {
403
                            return [
404 32
                                'connections' => [$v],
405
                            ];
406 34
                        })
407 34
                        ->end()
408 34
                        ->children()
409 34
                            ->arrayNode('connections')
410 34
                                ->requiresAtLeastOneElement()
411 34
                                ->prototype('array')
412 34
                                    ->fixXmlConfig('header')
413 34
                                    ->children()
414 34
                                        ->scalarNode('url')
415 34
                                            ->validate()
416
                                                ->ifTrue(function ($url) {
417 18
                                                    return $url && '/' !== substr($url, -1);
418 34
                                                })
419
                                                ->then(function ($url) {
420 18
                                                    return $url.'/';
421 34
                                                })
422 34
                                            ->end()
423 34
                                        ->end()
424 34
                                        ->scalarNode('username')->end()
425 34
                                        ->scalarNode('password')->end()
426 34
                                        ->scalarNode('host')->end()
427 34
                                        ->scalarNode('port')->end()
428 34
                                        ->scalarNode('proxy')->end()
429 34
                                        ->arrayNode('http_error_codes')
430 34
                                            ->beforeNormalization()
431
                                                ->ifTrue(function ($v) { return !is_array($v); })
432
                                                ->then(function ($v) { return array($v); })
433 34
                                            ->end()
434 34
                                            ->requiresAtLeastOneElement()
435 34
                                            ->defaultValue([400, 403, 404])
436 34
                                            ->prototype('scalar')->end()
437 34
                                        ->end()
438 34
                                        ->scalarNode('aws_access_key_id')->end()
439 34
                                        ->scalarNode('aws_secret_access_key')->end()
440 34
                                        ->scalarNode('aws_region')->end()
441 34
                                        ->scalarNode('aws_session_token')->end()
442 34
                                        ->booleanNode('ssl')->defaultValue(false)->end()
443 34
                                        ->scalarNode('logger')
444 34
                                            ->defaultValue($this->debug ? 'fos_elastica.logger' : false)
445 34
                                            ->treatNullLike('fos_elastica.logger')
446 34
                                            ->treatTrueLike('fos_elastica.logger')
447 34
                                        ->end()
448 34
                                        ->booleanNode('compression')->defaultValue(false)->end()
449 34
                                        ->arrayNode('headers')
450 34
                                            ->normalizeKeys(false)
451 34
                                            ->useAttributeAsKey('name')
452 34
                                            ->prototype('scalar')->end()
453 34
                                        ->end()
454 34
                                        ->arrayNode('curl')
455 34
                                            ->useAttributeAsKey(CURLOPT_SSL_VERIFYPEER)
456 34
                                            ->prototype('boolean')->end()
457 34
                                        ->end()
458 34
                                        ->scalarNode('transport')->end()
459 34
                                        ->scalarNode('timeout')->end()
460 34
                                        ->scalarNode('connectTimeout')->end()
461 34
                                        ->scalarNode('retryOnConflict')
462 34
                                            ->defaultValue(0)
463 34
                                        ->end()
464 34
                                        ->booleanNode('persistent')->defaultValue(true)->end()
465 34
                                    ->end()
466 34
                                ->end()
467 34
                            ->end()
468 34
                            ->scalarNode('timeout')->end()
469 34
                            ->scalarNode('connectTimeout')->end()
470 34
                            ->scalarNode('headers')->end()
471 34
                            ->scalarNode('connectionStrategy')->defaultValue('Simple')->end()
472 34
                        ->end()
473 34
                    ->end()
474 34
                ->end()
475 34
            ->end()
476
        ;
477 34
    }
478
479
    /**
480
     * Adds the configuration for the "indexes" key.
481
     */
482 34
    private function addIndexesSection(ArrayNodeDefinition $rootNode)
483
    {
484
        $rootNode
485 34
            ->fixXmlConfig('index')
486 34
            ->children()
487 34
                ->arrayNode('indexes')
488 34
                    ->useAttributeAsKey('name')
489 34
                    ->prototype('array')
490 34
                        ->children()
491 34
                            ->scalarNode('index_name')
492 34
                                ->info('Defaults to the name of the index, but can be modified if the index name is different in ElasticSearch')
493 34
                            ->end()
494 34
                            ->variableNode('indexable_callback')->end()
495 34
                            ->booleanNode('use_alias')->defaultValue(false)->end()
496 34
                            ->scalarNode('client')->end()
497 34
                            ->scalarNode('finder')
498 34
                                ->treatNullLike(true)
499 34
                                ->defaultFalse()
500 34
                            ->end()
501 34
                            ->append($this->getPersistenceNode())
502 34
                            ->arrayNode('type_prototype')
503 34
                                ->children()
504 34
                                    ->scalarNode('analyzer')->end()
505 34
                                    ->append($this->getPersistenceNode())
506 34
                                    ->append($this->getSerializerNode())
507 34
                                ->end()
508 34
                            ->end()
509 34
                            ->variableNode('settings')->defaultValue([])->end()
510 34
                        ->end()
511 34
                        ->append($this->getTypesNode())
512 34
                    ->end()
513 34
                ->end()
514 34
            ->end()
515
        ;
516 34
    }
517
518
    /**
519
     * @return ArrayNodeDefinition|\Symfony\Component\Config\Definition\Builder\NodeDefinition
520
     */
521 34
    private function createTreeBuilderNode($name)
522
    {
523 34
        return (new TreeBuilder($name))->getRootNode();
524
    }
525
526
    /**
527
     * Adds the configuration for the "index_templates" key.
528
     *
529
     * @param ArrayNodeDefinition $rootNode
530
     *
531
     * @return void
532
     */
533 34
    private function addIndexTemplatesSection(ArrayNodeDefinition $rootNode)
534
    {
535
        $rootNode
536 34
            ->fixXmlConfig('index_template')
537 34
            ->children()
538 34
                ->arrayNode('index_templates')
539 34
                    ->useAttributeAsKey('name')
540 34
                    ->prototype('array')
541 34
                        ->children()
542 34
                            ->scalarNode('template_name')
543 34
                                ->info('Defaults to the name of the index template, but can be modified if the index name is different in ElasticSearch')
544 34
                            ->end()
545 34
                            ->scalarNode('template')->isRequired()->end()
546 34
                            ->scalarNode('client')->end()
547 34
                            ->variableNode('settings')->defaultValue([])->end()
548 34
                        ->end()
549 34
                        ->append($this->getTypesNode())
550 34
                    ->end()
551 34
                ->end()
552 34
            ->end()
553
        ;
554 34
    }
555
}
556