MappingBuilder::fixProperties() - Code Metrics - Inspection of "Fix some tests" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 05c57d...e1240a )

by Tim

created 2016-01-07 04:56 UTC

MappingBuilder::fixProperties() B

↳ Parent: MappingBuilder

Complexity

Conditions	7
Paths	17

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	7.0368

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	19
ccs	10
cts	11
cp	0.9091
rs	8.2222
cc	7
eloc	11
nc	17
nop	1
crap	7.0368

<?php

/**
 * This file is part of the FOSElasticaBundle project.
 *
 * (c) Infinite Networks Pty Ltd <http://www.infinite.net.au>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\ElasticaBundle\Index;

use FOS\ElasticaBundle\Configuration\IndexConfig;
use FOS\ElasticaBundle\Configuration\TypeConfig;

class MappingBuilder
{
    /**
     * Skip adding default information to certain fields.
     *
     * @var array
     */
    private $skipTypes = array('completion');

    /**
     * Builds mappings for an entire index.
     *
     * @param IndexConfig $indexConfig
     *
     * @return array
     */
    public function buildIndexMapping(IndexConfig $indexConfig)
    {
        $typeMappings = array();
        foreach ($indexConfig->getTypes() as $typeConfig) {
            $typeMappings[$typeConfig->getName()] = $this->buildTypeMapping($typeConfig);
        }

        $mapping = array();
        if (!empty($typeMappings)) {
            $mapping['mappings'] = $typeMappings;
        }
        // 'warmers' => $indexConfig->getWarmers(),

        $settings = $indexConfig->getSettings();
        if (!empty($settings)) {
            $mapping['settings'] = $settings;
        }

        return $mapping;
    }

    /**
     * Builds mappings for a single type.
     *
     * @param TypeConfig $typeConfig
     *
     * @return array
     */
    public function buildTypeMapping(TypeConfig $typeConfig)
    {
        $mapping = $typeConfig->getMapping();

        if (null !== $typeConfig->getDynamicDateFormats()) {
            $mapping['dynamic_date_formats'] = $typeConfig->getDynamicDateFormats();
        }

        if (null !== $typeConfig->getDateDetection()) {
            $mapping['date_detection'] = $typeConfig->getDateDetection();
        }

        if (null !== $typeConfig->getNumericDetection()) {
            $mapping['numeric_detection'] = $typeConfig->getNumericDetection();
        }

        if ($typeConfig->getIndexAnalyzer()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $mapping['index_analyzer'] = $typeConfig->getIndexAnalyzer();
        }

        if ($typeConfig->getSearchAnalyzer()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $mapping['search_analyzer'] = $typeConfig->getSearchAnalyzer();
        }

        if ($typeConfig->getDynamic() !== null) {
            $mapping['dynamic'] = $typeConfig->getDynamic();
        }

        if (isset($mapping['dynamic_templates']) and empty($mapping['dynamic_templates'])) {
            unset($mapping['dynamic_templates']);
        }

        $this->fixProperties($mapping['properties']);
        if (!$mapping['properties']) {
            unset($mapping['properties']);
        }

        if ($typeConfig->getModel()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $mapping['_meta']['model'] = $typeConfig->getModel();
        }

        if (empty($mapping)) {
            // Empty mapping, we want it encoded as a {} instead of a []
            $mapping = new \stdClass();
        }

        return $mapping;
    }

    /**
     * Fixes any properties and applies basic defaults for any field that does not have
     * required options.
     *
     * @param $properties
     */
    private function fixProperties(&$properties)
    {
        foreach ($properties as $name => &$property) {
            unset($property['property_path']);

            if (!isset($property['type'])) {
                $property['type'] = 'string';
            }
            if ($property['type'] == 'multi_field' && isset($property['fields'])) {
                $this->fixProperties($property['fields']);
            }
            if (isset($property['properties'])) {
                $this->fixProperties($property['properties']);
            }
            if (in_array($property['type'], $this->skipTypes)) {
                continue;
            }
        }
    }
}


1		<?php
2
3		/**
4		* This file is part of the FOSElasticaBundle project.
5		*
6		* (c) Infinite Networks Pty Ltd <http://www.infinite.net.au>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace FOS\ElasticaBundle\Index;
13
14		use FOS\ElasticaBundle\Configuration\IndexConfig;
15		use FOS\ElasticaBundle\Configuration\TypeConfig;
16
17		class MappingBuilder
18		{
19		/**
20		* Skip adding default information to certain fields.
21		*
22		* @var array
23		*/
24		private $skipTypes = array('completion');
25
26		/**
27		* Builds mappings for an entire index.
28		*
29		* @param IndexConfig $indexConfig
30		*
31		* @return array
32		*/
33	2	public function buildIndexMapping(IndexConfig $indexConfig)
34		{
35	2	$typeMappings = array();
36	2	foreach ($indexConfig->getTypes() as $typeConfig) {
37	2	$typeMappings[$typeConfig->getName()] = $this->buildTypeMapping($typeConfig);
38		}
39
40	2	$mapping = array();
41	2	if (!empty($typeMappings)) {
42	2	$mapping['mappings'] = $typeMappings;
43		}
44		// 'warmers' => $indexConfig->getWarmers(),
45
46	2	$settings = $indexConfig->getSettings();
47	2	if (!empty($settings)) {
48	1	$mapping['settings'] = $settings;
49		}
50
51	2	return $mapping;
52		}
53
54		/**
55		* Builds mappings for a single type.
56		*
57		* @param TypeConfig $typeConfig
58		*
59		* @return array
60		*/
61	3	public function buildTypeMapping(TypeConfig $typeConfig)
62		{
63	3	$mapping = $typeConfig->getMapping();
64
65	3	if (null !== $typeConfig->getDynamicDateFormats()) {
66	3	$mapping['dynamic_date_formats'] = $typeConfig->getDynamicDateFormats();
67		}
68
69	3	if (null !== $typeConfig->getDateDetection()) {
70	2	$mapping['date_detection'] = $typeConfig->getDateDetection();
71		}
72
73	3	if (null !== $typeConfig->getNumericDetection()) {
74	2	$mapping['numeric_detection'] = $typeConfig->getNumericDetection();
75		}
76
77	3	if ($typeConfig->getIndexAnalyzer()) {
		0 ignored issues – show Bug Best Practice introduced 2016-01-07 03:50 UTC by Report Bug Copy Issue Report The expression `$typeConfig->getIndexAnalyzer()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
78	1	$mapping['index_analyzer'] = $typeConfig->getIndexAnalyzer();
79		}
80
81	3	if ($typeConfig->getSearchAnalyzer()) {
		0 ignored issues – show Bug Best Practice introduced 2016-01-07 03:50 UTC by Report Bug Copy Issue Report The expression `$typeConfig->getSearchAnalyzer()` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
82	2	$mapping['search_analyzer'] = $typeConfig->getSearchAnalyzer();
83		}
84
85	3	if ($typeConfig->getDynamic() !== null) {
86	2	$mapping['dynamic'] = $typeConfig->getDynamic();
87		}
88
89	3	if (isset($mapping['dynamic_templates']) and empty($mapping['dynamic_templates'])) {
90	3	unset($mapping['dynamic_templates']);
91	2	}
92
93		$this->fixProperties($mapping['properties']);
94	3	if (!$mapping['properties']) {
95	1	unset($mapping['properties']);
96		}
97
98	3	if ($typeConfig->getModel()) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-24 05:06 UTC by Report Bug Copy Issue Report The expression `$typeConfig->getModel()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
99		$mapping['_meta']['model'] = $typeConfig->getModel();
100		}
101
102		if (empty($mapping)) {
103	3	// Empty mapping, we want it encoded as a {} instead of a []
104		$mapping = new \stdClass();
105		}
106
107		return $mapping;
108		}
109
110		/**
111		* Fixes any properties and applies basic defaults for any field that does not have
112	3	* required options.
113		*
114	3	* @param $properties
115	3	*/
116		private function fixProperties(&$properties)
117	3	{
118	3	foreach ($properties as $name => &$property) {
119		unset($property['property_path']);
120	3
121		if (!isset($property['type'])) {
122		$property['type'] = 'string';
123	3	}
124	2	if ($property['type'] == 'multi_field' && isset($property['fields'])) {
125		$this->fixProperties($property['fields']);
126	3	}
127	2	if (isset($property['properties'])) {
128		$this->fixProperties($property['properties']);
129	3	}
130	3	if (in_array($property['type'], $this->skipTypes)) {
131		continue;
132		}
133	3	}
134		}
135		}
136

FriendsOfSymfony / FOSElasticaBundle

Push — master ( 05c57d...e1240a )

MappingBuilder::fixProperties() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like