RegisterListenersServiceTest::testShouldIgnoreDebugLoggingOptionForPHPCRManager() - Code Metrics - Inspection of "Merge branch '4.0.x'" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0aa154...6fc129 )

by Maksim

created 2017-12-08 11:16 UTC

testShouldIgnoreDebugLoggingOptionForPHPCRManager() B

↳ Parent: RegisterListenersServiceTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	29
rs	8.8571
c	1
b	1
f	0
cc	2
eloc	17
nc	2
nop	0

<?php
namespace FOS\ElasticaBundle\Tests\Doctrine;

use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\DBAL\Connection;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManagerInterface;
use FOS\ElasticaBundle\Doctrine\RegisterListenersService;
use FOS\ElasticaBundle\Persister\Event\Events;
use FOS\ElasticaBundle\Persister\Event\PostInsertObjectsEvent;
use FOS\ElasticaBundle\Persister\ObjectPersisterInterface;
use FOS\ElasticaBundle\Provider\PagerInterface;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class RegisterListenersServiceTest extends \PHPUnit_Framework_TestCase
{
    public function testCouldBeConstructedWithDispatcherArgument()
    {
        new RegisterListenersService($this->createDispatcherMock());

    }

    public function testShouldRegisterClearObjectManagerListenerByDefaultAndDispatchOnPostPersistEvent()
    {
        $dispatcher = $this->createDispatcher();

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->createObjectManagerMock();
        $manager
            ->expects($this->once())
            ->method('clear')
        ;

        $pager = $this->createPagerMock();

        $service->register($manager, $pager, []);

        $dispatcher->dispatch(
            Events::POST_INSERT_OBJECTS,
            new PostInsertObjectsEvent($pager, $this->createObjectPersisterMock(), [], [])

        );
    }

    public function testShouldNotRegisterClearObjectManagerListenerIfOptionFalse()
    {
        $dispatcher = $this->createDispatcher();

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->createObjectManagerMock();
        $manager
            ->expects($this->never())
            ->method('clear')
        ;

        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false
        ]);

        $dispatcher->dispatch(
            Events::POST_INSERT_OBJECTS,
            new PostInsertObjectsEvent($pager, $this->createObjectPersisterMock(), [], [])

        );
    }

    public function testShouldNotCallClearObjectManagerListenerForAnotherPagers()
    {
        $dispatcher = $this->createDispatcher();

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->createObjectManagerMock();
        $manager
            ->expects($this->never())
            ->method('clear')
        ;

        $pager = $this->createPagerMock();
        $anotherPager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => true
        ]);

        $dispatcher->dispatch(
            Events::POST_INSERT_OBJECTS,
            new PostInsertObjectsEvent($anotherPager, $this->createObjectPersisterMock(), [], [])

        );
    }

    public function testShouldNotRegisterSleepListenerByDefault()
    {
        $dispatcher = $this->createDispatcherMock();
        $dispatcher
            ->expects($this->never())
            ->method('addListener')
            ->with(Events::POST_INSERT_OBJECTS, $this->isInstanceOf(\Closure::class))
        ;

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->createObjectManagerMock();

        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
        ]);
    }

    public function testShouldRegisterSleepListenerIfOptionNotZero()
    {
        $dispatcher = $this->createDispatcher();

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->createObjectManagerMock();

        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 2000000,
        ]);

        $time = microtime(true);
        $dispatcher->dispatch(
            Events::POST_INSERT_OBJECTS,
            new PostInsertObjectsEvent($pager, $this->createObjectPersisterMock(), [], [])

        );

        $this->assertGreaterThan(1.5, microtime(true) - $time);
    }

    public function testShouldNotCallSleepListenerForAnotherPagers()
    {
        $dispatcher = $this->createDispatcher();

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->createObjectManagerMock();

        $pager = $this->createPagerMock();
        $anotherPager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 2000000,
        ]);

        $time = microtime(true);
        $dispatcher->dispatch(
            Events::POST_INSERT_OBJECTS,
            new PostInsertObjectsEvent($anotherPager, $this->createObjectPersisterMock(), [], [])

        );

        $this->assertLessThan(1, microtime(true) - $time);
    }

    public function testShouldRegisterDisableDebugLoggingByDefaultForEntityManager()
    {
        $dispatcher = $this->createDispatcherMock();
        $dispatcher
            ->expects($this->at(0))
            ->method('addListener')
            ->with(Events::PRE_FETCH_OBJECTS, $this->isInstanceOf(\Closure::class));
        $dispatcher
            ->expects($this->at(1))
            ->method('addListener')
            ->with(Events::PRE_INSERT_OBJECTS, $this->isInstanceOf(\Closure::class));

        $service = new RegisterListenersService($dispatcher);

        $configuration = $this->getMock(Configuration::class);

        $connection = $this->getMock(Connection::class, [], [], '', false);

        $connection
            ->expects($this->once())
            ->method('getConfiguration')
            ->willReturn($configuration)
        ;

        $manager = $this->getMock(EntityManagerInterface::class);

        $manager
            ->expects($this->once())
            ->method('getConnection')
            ->willReturn($connection)
        ;


        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 0,
        ]);
    }

    public function testShouldNotRegisterDisableDebugLoggingIfOptionTrueForEntityManager()
    {
        $dispatcher = $this->createDispatcherMock();
        $dispatcher
            ->expects($this->never())
            ->method('addListener')
        ;

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->getMock(EntityManagerInterface::class);

        $manager
            ->expects($this->never())
            ->method('getConnection')
        ;


        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 0,
            'debug_logging' => true,
        ]);
    }

    public function testShouldRegisterDisableDebugLoggingByDefaultForMongoDBDocumentManager()
    {
        if (!class_exists(\Doctrine\ODM\MongoDB\DocumentManager::class)) {
            $this->markTestSkipped('Doctrine MongoDB ODM is not available.');
        }

        $dispatcher = $this->createDispatcherMock();
        $dispatcher
            ->expects($this->at(0))
            ->method('addListener')
            ->with(Events::PRE_FETCH_OBJECTS, $this->isInstanceOf(\Closure::class));
        $dispatcher
            ->expects($this->at(1))
            ->method('addListener')
            ->with(Events::PRE_INSERT_OBJECTS, $this->isInstanceOf(\Closure::class));

        $service = new RegisterListenersService($dispatcher);

        $configuration = $this->getMock(Configuration::class);

        $connection = $this->getMock(Connection::class, [], [], '', false);

        $connection
            ->expects($this->once())
            ->method('getConfiguration')
            ->willReturn($configuration)
        ;

        $manager = $this->getMock(Doctrine\ODM\MongoDB\DocumentManager::class, [], [], '', false);

        $manager
            ->expects($this->once())
            ->method('getConnection')
            ->willReturn($connection)
        ;


        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 0,
        ]);
    }

    public function testShouldNotRegisterDisableDebugLoggingIfOptionTrueForMongoDBDocumentManager()
    {
        if (!class_exists(\Doctrine\ODM\MongoDB\DocumentManager::class)) {
            $this->markTestSkipped('Doctrine MongoDB ODM is not available.');
        }

        $dispatcher = $this->createDispatcherMock();
        $dispatcher
            ->expects($this->never())
            ->method('addListener')
        ;

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->getMock(Doctrine\ODM\MongoDB\DocumentManager::class, [], [], '', false);

        $manager
            ->expects($this->never())
            ->method('getConnection')
        ;


        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 0,
            'debug_logging' => true,
        ]);
    }

    public function testShouldIgnoreDebugLoggingOptionForPHPCRManager()
    {
        if (!class_exists(\Doctrine\ODM\PHPCR\DocumentManagerInterface::class)) {
            $this->markTestSkipped('Doctrine PHPCR is not present');
        }

        $dispatcher = $this->createDispatcherMock();
        $dispatcher
            ->expects($this->never())
            ->method('addListener')
        ;

        $service = new RegisterListenersService($dispatcher);

        $manager = $this->getMock(\Doctrine\ODM\PHPCR\DocumentManagerInterface::class);


        $pager = $this->createPagerMock();

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 0,
        ]);

        $service->register($manager, $pager, [
            'clear_object_manager' => false,
            'sleep' => 0,
            'debug_logging' => false,
        ]);
    }

    private function createPagerMock()
    {
        return $this->getMock(PagerInterface::class, [], [], '', false);

    }

    /**
     * @return ObjectPersisterInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createObjectPersisterMock()
    {
        return $this->getMock(ObjectPersisterInterface::class, [], [], '', false);

    }

    /**
     * @return ObjectManager|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createObjectManagerMock()
    {
        return $this->getMock(ObjectManager::class, [], [], '', false);

    }

    /**
     * @return EventDispatcher
     */
    private function createDispatcher()
    {
        return new EventDispatcher();
    }

    /**
     * @return \PHPUnit_Framework_MockObject_MockObject|EventDispatcherInterface
     */
    private function createDispatcherMock()
    {
        return $this->getMock(EventDispatcherInterface::class, [], [], '', false);

    }
}


1		<?php
2		namespace FOS\ElasticaBundle\Tests\Doctrine;
3
4		use Doctrine\Common\Persistence\ObjectManager;
5		use Doctrine\DBAL\Connection;
6		use Doctrine\ORM\Configuration;
7		use Doctrine\ORM\EntityManagerInterface;
8		use FOS\ElasticaBundle\Doctrine\RegisterListenersService;
9		use FOS\ElasticaBundle\Persister\Event\Events;
10		use FOS\ElasticaBundle\Persister\Event\PostInsertObjectsEvent;
11		use FOS\ElasticaBundle\Persister\ObjectPersisterInterface;
12		use FOS\ElasticaBundle\Provider\PagerInterface;
13		use Symfony\Component\EventDispatcher\EventDispatcher;
14		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
15
16		class RegisterListenersServiceTest extends \PHPUnit_Framework_TestCase
17		{
18		public function testCouldBeConstructedWithDispatcherArgument()
19		{
20		new RegisterListenersService($this->createDispatcherMock());
		0 ignored issues – show Bug introduced 2017-12-08 11:22 UTC by Report Bug Copy Issue Report It seems like `$this->createDispatcherMock()` targeting `FOS\ElasticaBundle\Tests...:createDispatcherMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Doctr...sService::__construct()` does only seem to accept `object<Symfony\Component...entDispatcherInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
21		}
22
23	View Code Duplication	public function testShouldRegisterClearObjectManagerListenerByDefaultAndDispatchOnPostPersistEvent()
24		{
25		$dispatcher = $this->createDispatcher();
26
27		$service = new RegisterListenersService($dispatcher);
28
29		$manager = $this->createObjectManagerMock();
30		$manager
31		->expects($this->once())
32		->method('clear')
33		;
34
35		$pager = $this->createPagerMock();
36
37		$service->register($manager, $pager, []);
38
39		$dispatcher->dispatch(

FriendsOfSymfony / FOSElasticaBundle

Push — master ( 0aa154...6fc129 )

testShouldIgnoreDebugLoggingOptionForPHPCRManager() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like