Completed
Pull Request — master (#1569)
by
unknown
15:31
created

Configuration::getTypesNode()   A

Complexity

Conditions 3
Paths 1

Size

Total Lines 54

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 38
CRAP Score 3.0001

Importance

Changes 0
Metric Value
dl 0
loc 54
ccs 38
cts 39
cp 0.9744
rs 9.0036
c 0
b 0
f 0
cc 3
nc 1
nop 0
crap 3.0001

How to fix   Long Method   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
/*
4
 * This file is part of the FOSElasticaBundle package.
5
 *
6
 * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace FOS\ElasticaBundle\DependencyInjection;
13
14
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
15
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
16
use Symfony\Component\Config\Definition\ConfigurationInterface;
17
18
class Configuration implements ConfigurationInterface
19
{
20
    private const SUPPORTED_DRIVERS = ['orm', 'mongodb', 'phpcr'];
21
22
    /**
23
     * If the kernel is running in debug mode.
24
     *
25
     * @var bool
26
     */
27
    private $debug;
28
29 34
    public function __construct($debug)
30
    {
31 34
        $this->debug = $debug;
32 34
    }
33
34
    /**
35
     * Generates the configuration tree.
36
     *
37
     * @return TreeBuilder
38
     */
39 34
    public function getConfigTreeBuilder()
40
    {
41 34
        $treeBuilder = new TreeBuilder('fos_elastica');
42 34
        $rootNode = $treeBuilder->getRootNode();
43
44 34
        $this->addClientsSection($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
45 34
        $this->addIndexesSection($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
46 34
        $this->addIndexTemplatesSection($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
47
48
        $rootNode
49 34
            ->children()
50 34
                ->scalarNode('default_client')
51 34
                    ->info('Defaults to the first client defined')
52 34
                ->end()
53 34
                ->scalarNode('default_index')
54 34
                    ->info('Defaults to the first index defined')
55 34
                ->end()
56 34
                ->scalarNode('default_manager')->defaultValue('orm')->end()
57 34
                ->arrayNode('serializer')
58 34
                    ->treatNullLike([])
59 34
                    ->children()
60 34
                        ->scalarNode('callback_class')->defaultValue('FOS\ElasticaBundle\Serializer\Callback')->end()
61 34
                        ->scalarNode('serializer')->defaultValue('serializer')->end()
62 34
                    ->end()
63 34
                ->end()
64 34
            ->end()
65
        ;
66
67 34
        return $treeBuilder;
68
    }
69
70
    /**
71
     * Returns the array node used for "dynamic_templates".
72
     */
73 34
    private function getDynamicTemplateNode()
74
    {
75 34
        $node = $this->createTreeBuilderNode('dynamic_templates');
76
77
        $node
78 34
            ->prototype('array')
79 34
                ->prototype('array')
80 34
                    ->children()
81 34
                        ->scalarNode('match')->end()
82 34
                        ->scalarNode('unmatch')->end()
83 34
                        ->scalarNode('match_mapping_type')->end()
84 34
                        ->scalarNode('path_match')->end()
85 34
                        ->scalarNode('path_unmatch')->end()
86 34
                        ->scalarNode('match_pattern')->end()
87 34
                        ->arrayNode('mapping')
88 34
                            ->prototype('variable')
89 34
                                ->treatNullLike([])
90 34
                            ->end()
91 34
                        ->end()
92 34
                    ->end()
93 34
                ->end()
94 34
            ->end()
95
        ;
96
97 34
        return $node;
98
    }
99
100
    /**
101
     * Returns the array node used for "types".
102
     */
103 34
    private function getTypesNode()
104
    {
105 34
        $node = $this->createTreeBuilderNode('types');
106
107
        $node
0 ignored issues
show
Bug introduced by
The method useAttributeAsKey() does not exist on Symfony\Component\Config...\Builder\NodeDefinition. Did you maybe mean attribute()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
108 34
            ->useAttributeAsKey('name')
109 34
            ->prototype('array')
110 34
                ->treatNullLike([])
111 34
                ->beforeNormalization()
112 34
                ->ifNull()
113 34
                    ->thenEmptyArray()
114 34
                ->end()
115
                // Support multiple dynamic_template formats to match the old bundle style
116
                // and the way ElasticSearch expects them
117 34
                ->beforeNormalization()
118
                ->ifTrue(function ($v) {
119 24
                    return isset($v['dynamic_templates']);
120 34
                })
121
                ->then(function ($v) {
122 5
                    $dt = [];
123 5
                    foreach ($v['dynamic_templates'] as $key => $type) {
124 5
                        if (is_int($key)) {
125 5
                            $dt[] = $type;
126
                        } else {
127
                            $dt[][$key] = $type;
128
                        }
129
                    }
130
131 5
                    $v['dynamic_templates'] = $dt;
132
133 5
                    return $v;
134 34
                })
135 34
                ->end()
136 34
                ->children()
137 34
                    ->booleanNode('date_detection')->end()
138 34
                    ->arrayNode('dynamic_date_formats')->prototype('scalar')->end()->end()
139 34
                    ->scalarNode('analyzer')->end()
140 34
                    ->booleanNode('numeric_detection')->end()
141 34
                    ->scalarNode('dynamic')->end()
142 34
                    ->variableNode('indexable_callback')->end()
143 34
                    ->append($this->getPersistenceNode())
144 34
                    ->append($this->getSerializerNode())
145 34
                ->end()
146 34
                ->append($this->getIdNode())
147 34
                ->append($this->getPropertiesNode())
148 34
                ->append($this->getDynamicTemplateNode())
149 34
                ->append($this->getSourceNode())
150 34
                ->append($this->getRoutingNode())
151 34
                ->append($this->getAllNode())
152 34
            ->end()
153
        ;
154
155 34
        return $node;
156
    }
157
158
    /**
159
     * Returns the array node used for "properties".
160
     */
161 34
    private function getPropertiesNode()
162
    {
163 34
        $node = $this->createTreeBuilderNode('properties');
164
165
        $node
0 ignored issues
show
Bug introduced by
The method useAttributeAsKey() does not exist on Symfony\Component\Config...\Builder\NodeDefinition. Did you maybe mean attribute()?

This check marks calls to methods that do not seem to exist on an object.

This is most likely the result of a method being renamed without all references to it being renamed likewise.

Loading history...
166 34
            ->useAttributeAsKey('name')
167 34
            ->prototype('variable')
168 34
                ->treatNullLike([]);
169
170 34
        return $node;
171
    }
172
173
    /**
174
     * Returns the array node used for "_id".
175
     */
176 34
    private function getIdNode()
177
    {
178 34
        $node = $this->createTreeBuilderNode('_id');
179
180
        $node
181 34
            ->children()
182 34
            ->scalarNode('path')->end()
183 34
            ->end()
184
        ;
185
186 34
        return $node;
187
    }
188
189
    /**
190
     * Returns the array node used for "_source".
191
     */
192 34
    private function getSourceNode()
193
    {
194 34
        $node = $this->createTreeBuilderNode('_source');
195
196
        $node
197 34
            ->children()
198 34
                ->arrayNode('excludes')
199 34
                    ->useAttributeAsKey('name')
200 34
                    ->prototype('scalar')->end()
201 34
                ->end()
202 34
                ->arrayNode('includes')
203 34
                    ->useAttributeAsKey('name')
204 34
                    ->prototype('scalar')->end()
205 34
                ->end()
206 34
                ->scalarNode('compress')->end()
207 34
                ->scalarNode('compress_threshold')->end()
208 34
                ->scalarNode('enabled')->defaultTrue()->end()
209 34
            ->end()
210
        ;
211
212 34
        return $node;
213
    }
214
215
    /**
216
     * Returns the array node used for "_routing".
217
     */
218 34
    private function getRoutingNode()
219
    {
220 34
        $node = $this->createTreeBuilderNode('_routing');
221
222
        $node
223 34
            ->children()
224 34
                ->scalarNode('required')->end()
225 34
                ->scalarNode('path')->end()
226 34
            ->end()
227
        ;
228
229 34
        return $node;
230
    }
231
232
    /**
233
     * Returns the array node used for "_all".
234
     */
235 34
    private function getAllNode()
236
    {
237 34
        $node = $this->createTreeBuilderNode('_all');
238
239
        $node
240 34
            ->children()
241 34
            ->scalarNode('enabled')->defaultValue(true)->end()
242 34
            ->scalarNode('analyzer')->end()
243 34
            ->end()
244
        ;
245
246 34
        return $node;
247
    }
248
249
    /**
250
     * @return ArrayNodeDefinition|\Symfony\Component\Config\Definition\Builder\NodeDefinition
251
     */
252 34
    private function getPersistenceNode()
253
    {
254 34
        $node = $this->createTreeBuilderNode('persistence');
255
256
        $node
257 34
            ->validate()
258
                ->ifTrue(function ($v) {
259 16
                    return isset($v['driver']) && 'orm' !== $v['driver'] && !empty($v['elastica_to_model_transformer']['hints']);
260 34
                })
261 34
                    ->thenInvalid('Hints are only supported by the "orm" driver')
262 34
            ->end()
263 34
            ->children()
264 34
                ->scalarNode('driver')
265 34
                    ->defaultValue('orm')
266 34
                    ->validate()
267 34
                    ->ifNotInArray(self::SUPPORTED_DRIVERS)
268 34
                        ->thenInvalid('The driver %s is not supported. Please choose one of '.json_encode(self::SUPPORTED_DRIVERS))
269 34
                    ->end()
270 34
                ->end()
271 34
                ->scalarNode('model')->defaultValue(null)->end()
272 34
                ->scalarNode('repository')->end()
273 34
                ->scalarNode('identifier')->defaultValue('id')->end()
274 34
                ->arrayNode('provider')
275 34
                    ->addDefaultsIfNotSet()
276 34
                    ->children()
277 34
                        ->scalarNode('batch_size')->defaultValue(100)->end()
278 34
                        ->scalarNode('clear_object_manager')->defaultTrue()->end()
279 34
                        ->scalarNode('debug_logging')
280 34
                            ->defaultValue($this->debug)
281 34
                            ->treatNullLike(true)
282 34
                        ->end()
283 34
                        ->scalarNode('query_builder_method')->defaultValue('createQueryBuilder')->end()
284 34
                        ->scalarNode('service')->end()
285 34
                    ->end()
286 34
                ->end()
287 34
                ->arrayNode('listener')
288 34
                    ->addDefaultsIfNotSet()
289 34
                    ->children()
290 34
                        ->booleanNode('enabled')->defaultTrue()->end()
291 34
                        ->scalarNode('insert')->defaultTrue()->end()
292 34
                        ->scalarNode('update')->defaultTrue()->end()
293 34
                        ->scalarNode('delete')->defaultTrue()->end()
294 34
                        ->scalarNode('flush')->defaultTrue()->end()
295 34
                        ->booleanNode('defer')->defaultFalse()->end()
296 34
                        ->scalarNode('logger')
297 34
                            ->defaultFalse()
298 34
                            ->treatNullLike('fos_elastica.logger')
299 34
                            ->treatTrueLike('fos_elastica.logger')
300 34
                        ->end()
301 34
                        ->scalarNode('service')->end()
302 34
                    ->end()
303 34
                ->end()
304 34
                ->arrayNode('finder')
305 34
                    ->addDefaultsIfNotSet()
306 34
                    ->children()
307 34
                        ->scalarNode('service')->end()
308 34
                    ->end()
309 34
                ->end()
310 34
                ->arrayNode('elastica_to_model_transformer')
311 34
                    ->addDefaultsIfNotSet()
312 34
                    ->children()
313 34
                        ->arrayNode('hints')
314 34
                            ->prototype('array')
315 34
                                ->children()
316 34
                                    ->scalarNode('name')->end()
317 34
                                    ->scalarNode('value')->end()
318 34
                                ->end()
319 34
                            ->end()
320 34
                        ->end()
321 34
                        ->booleanNode('hydrate')->defaultTrue()->end()
322 34
                        ->booleanNode('ignore_missing')
323 34
                            ->defaultFalse()
324 34
                            ->info('Silently ignore results returned from Elasticsearch without corresponding persistent object.')
325 34
                        ->end()
326 34
                        ->scalarNode('query_builder_method')->defaultValue('createQueryBuilder')->end()
327 34
                        ->scalarNode('service')->end()
328 34
                    ->end()
329 34
                ->end()
330 34
                ->arrayNode('model_to_elastica_transformer')
331 34
                    ->addDefaultsIfNotSet()
332 34
                    ->children()
333 34
                        ->scalarNode('service')->end()
334 34
                    ->end()
335 34
                ->end()
336 34
                ->arrayNode('persister')
337 34
                    ->addDefaultsIfNotSet()
338 34
                    ->children()
339 34
                        ->enumNode('refresh')
340 34
                            ->treatTrueLike('true')
341 34
                            ->treatFalseLike('false')
342 34
                            ->values(['true', 'wait_for', 'false'])
343 34
                        ->end()
344 34
                        ->scalarNode('service')->end()
345 34
                    ->end()
346 34
                ->end()
347 34
            ->end();
348
349 34
        return $node;
350
    }
351
352
    /**
353
     * @return ArrayNodeDefinition|\Symfony\Component\Config\Definition\Builder\NodeDefinition
354
     */
355 34
    private function getSerializerNode()
356
    {
357 34
        $node = $this->createTreeBuilderNode('serializer');
358
359
        $node
360 34
            ->addDefaultsIfNotSet()
361 34
            ->children()
362 34
                ->arrayNode('groups')
363 34
                    ->treatNullLike([])
364 34
                    ->prototype('scalar')->end()
365 34
                ->end()
366 34
                ->scalarNode('version')->end()
367 34
                ->booleanNode('serialize_null')
368 34
                    ->defaultFalse()
369 34
                ->end()
370 34
            ->end();
371
372 34
        return $node;
373
    }
374
375
    /**
376
     * Adds the configuration for the "clients" key.
377
     */
378 34
    private function addClientsSection(ArrayNodeDefinition $rootNode)
379
    {
380
        $rootNode
381 34
            ->fixXmlConfig('client')
382 34
            ->children()
383 34
                ->arrayNode('clients')
384 34
                    ->useAttributeAsKey('id')
385 34
                    ->prototype('array')
386 34
                        ->performNoDeepMerging()
387
                        // Elastica names its properties with camel case, support both
388 34
                        ->beforeNormalization()
389
                        ->ifTrue(function ($v) {
390 32
                            return isset($v['connection_strategy']);
391 34
                        })
392
                        ->then(function ($v) {
393 5
                            $v['connectionStrategy'] = $v['connection_strategy'];
394 5
                            unset($v['connection_strategy']);
395
396 5
                            return $v;
397 34
                        })
398 34
                        ->end()
399
                        // If there is no connections array key defined, assume a single connection.
400 34
                        ->beforeNormalization()
401
                        ->ifTrue(function ($v) {
402 32
                            return is_array($v) && !array_key_exists('connections', $v);
403 34
                        })
404
                        ->then(function ($v) {
405
                            return [
406 32
                                'connections' => [$v],
407
                            ];
408 34
                        })
409 34
                        ->end()
410 34
                        ->children()
411 34
                            ->arrayNode('connections')
412 34
                                ->requiresAtLeastOneElement()
413 34
                                ->prototype('array')
414 34
                                    ->fixXmlConfig('header')
415 34
                                    ->children()
416 34
                                        ->scalarNode('url')
417 34
                                            ->validate()
418
                                                ->ifTrue(function ($url) {
419 18
                                                    return $url && '/' !== substr($url, -1);
420 34
                                                })
421
                                                ->then(function ($url) {
422 18
                                                    return $url.'/';
423 34
                                                })
424 34
                                            ->end()
425 34
                                        ->end()
426 34
                                        ->scalarNode('username')->end()
427 34
                                        ->scalarNode('password')->end()
428 34
                                        ->scalarNode('host')->end()
429 34
                                        ->scalarNode('port')->end()
430 34
                                        ->scalarNode('proxy')->end()
431 34
                                        ->arrayNode('http_error_codes')
432 34
                                            ->beforeNormalization()
433
                                                ->ifTrue(function ($v) { return !is_array($v); })
434
                                                ->then(function ($v) { return array($v); })
435 34
                                            ->end()
436 34
                                            ->requiresAtLeastOneElement()
437 34
                                            ->defaultValue([400, 403, 404])
438 34
                                            ->prototype('scalar')->end()
439 34
                                        ->end()
440 34
                                        ->scalarNode('aws_access_key_id')->end()
441 34
                                        ->scalarNode('aws_secret_access_key')->end()
442 34
                                        ->scalarNode('aws_region')->end()
443 34
                                        ->scalarNode('aws_session_token')->end()
444 34
                                        ->booleanNode('ssl')->defaultValue(false)->end()
445 34
                                        ->scalarNode('logger')
446 34
                                            ->defaultValue($this->debug ? 'fos_elastica.logger' : false)
447 34
                                            ->treatNullLike('fos_elastica.logger')
448 34
                                            ->treatTrueLike('fos_elastica.logger')
449 34
                                        ->end()
450 34
                                        ->booleanNode('compression')->defaultValue(false)->end()
451 34
                                        ->arrayNode('headers')
452 34
                                            ->normalizeKeys(false)
453 34
                                            ->useAttributeAsKey('name')
454 34
                                            ->prototype('scalar')->end()
455 34
                                        ->end()
456 34
                                        ->arrayNode('curl')
457 34
                                            ->useAttributeAsKey(CURLOPT_SSL_VERIFYPEER)
458 34
                                            ->prototype('boolean')->end()
459 34
                                        ->end()
460 34
                                        ->scalarNode('transport')->end()
461 34
                                        ->scalarNode('timeout')->end()
462 34
                                        ->scalarNode('connectTimeout')->end()
463 34
                                        ->scalarNode('retryOnConflict')
464 34
                                            ->defaultValue(0)
465 34
                                        ->end()
466 34
                                        ->booleanNode('persistent')->defaultValue(true)->end()
467 34
                                    ->end()
468 34
                                ->end()
469 34
                            ->end()
470 34
                            ->scalarNode('timeout')->end()
471 34
                            ->scalarNode('connectTimeout')->end()
472 34
                            ->scalarNode('headers')->end()
473 34
                            ->scalarNode('connectionStrategy')->defaultValue('Simple')->end()
474 34
                        ->end()
475 34
                    ->end()
476 34
                ->end()
477 34
            ->end()
478
        ;
479 34
    }
480
481
    /**
482
     * Adds the configuration for the "indexes" key.
483
     */
484 34
    private function addIndexesSection(ArrayNodeDefinition $rootNode)
485
    {
486
        $rootNode
487 34
            ->fixXmlConfig('index')
488 34
            ->children()
489 34
                ->arrayNode('indexes')
490 34
                    ->useAttributeAsKey('name')
491 34
                    ->prototype('array')
492 34
                        ->children()
493 34
                            ->scalarNode('index_name')
494 34
                                ->info('Defaults to the name of the index, but can be modified if the index name is different in ElasticSearch')
495 34
                            ->end()
496 34
                            ->booleanNode('use_alias')->defaultValue(false)->end()
497 34
                            ->scalarNode('client')->end()
498 34
                            ->scalarNode('finder')
499 34
                                ->treatNullLike(true)
500 34
                                ->defaultFalse()
501 34
                            ->end()
502 34
                            ->arrayNode('type_prototype')
503 34
                                ->children()
504 34
                                    ->scalarNode('analyzer')->end()
505 34
                                    ->append($this->getPersistenceNode())
506 34
                                    ->append($this->getSerializerNode())
507 34
                                ->end()
508 34
                            ->end()
509 34
                            ->variableNode('settings')->defaultValue([])->end()
510 34
                        ->end()
511 34
                        ->append($this->getTypesNode())
512 34
                    ->end()
513 34
                ->end()
514 34
            ->end()
515
        ;
516 34
    }
517
518
    /**
519
     * @return ArrayNodeDefinition|\Symfony\Component\Config\Definition\Builder\NodeDefinition
520
     */
521 34
    private function createTreeBuilderNode($name)
522
    {
523 34
        return (new TreeBuilder($name))->getRootNode();
524
    }
525
526
    /**
527
     * Adds the configuration for the "index_templates" key.
528
     *
529
     * @param ArrayNodeDefinition $rootNode
530
     *
531
     * @return void
532
     */
533 34
    private function addIndexTemplatesSection(ArrayNodeDefinition $rootNode)
534
    {
535
        $rootNode
536 34
            ->fixXmlConfig('index_template')
537 34
            ->children()
538 34
                ->arrayNode('index_templates')
539 34
                    ->useAttributeAsKey('name')
540 34
                    ->prototype('array')
541 34
                        ->children()
542 34
                            ->scalarNode('template_name')
543 34
                                ->info('Defaults to the name of the index template, but can be modified if the index name is different in ElasticSearch')
544 34
                            ->end()
545 34
                            ->scalarNode('template')->isRequired()->end()
546 34
                            ->scalarNode('client')->end()
547 34
                            ->variableNode('settings')->defaultValue([])->end()
548 34
                        ->end()
549 34
                        ->append($this->getTypesNode())
550 34
                    ->end()
551 34
                ->end()
552 34
            ->end()
553
        ;
554 34
    }
555
}
556