TransformedFinder::__construct() - Code Metrics - Inspection of "Fixed tests" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1109)

by Karel

created 2016-08-04 10:58 UTC

TransformedFinder::__construct() A

↳ Parent: TransformedFinder

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	3
nc	1
nop	2
crap	1

<?php

namespace FOS\ElasticaBundle\Finder;

use Elastica\Document;
use FOS\ElasticaBundle\Transformer\ElasticaToModelTransformerInterface;
use FOS\ElasticaBundle\Paginator\TransformedPaginatorAdapter;
use FOS\ElasticaBundle\Paginator\FantaPaginatorAdapter;
use Pagerfanta\Pagerfanta;
use Elastica\SearchableInterface;
use Elastica\Query;

/**
 * Finds elastica documents and map them to persisted objects.
 */
class TransformedFinder implements PaginatedFinderInterface
{
    protected $searchable;
    protected $transformer;

    /**
     * @param SearchableInterface                 $searchable
     * @param ElasticaToModelTransformerInterface $transformer
     */
    public function __construct(SearchableInterface $searchable, ElasticaToModelTransformerInterface $transformer)
    {
        $this->searchable  = $searchable;
        $this->transformer = $transformer;
    }

    /**
     * {@inheritdoc}
     */
    public function find($query, $limit = null, $options = array())
    {
        $results = $this->search($query, $limit, $options);

        return $this->transformer->transform($results);
    }

    public function findHybrid($query, $limit = null, $options = array())
    {
        $results = $this->search($query, $limit, $options);

        return $this->transformer->hybridTransform($results);
    }

    /**
     * Find documents similar to one with passed id.
     *
     * @param integer $id
     * @param array   $params
     * @param array   $query
     *
     * @return array of model objects
     **/
    public function moreLikeThis($id, $params = array(), $query = array())
    {
        $doc = new Document($id);
        $results = $this->searchable->moreLikeThis($doc, $params, $query)->getResults();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return $this->transformer->transform($results);
    }

    /**
     * @param $query
     * @param null|int $limit
     * @param array    $options
     *
     * @return array
     */
    protected function search($query, $limit = null, $options = array())
    {
        $queryObject = Query::create($query);
        if (null !== $limit) {
            $queryObject->setSize($limit);
        }
        $results = $this->searchable->search($queryObject, $options)->getResults();

        return $results;
    }

    /**
     * {@inheritdoc}
     */
    public function findPaginated($query, $options = array())
    {
        $queryObject = Query::create($query);
        $paginatorAdapter = $this->createPaginatorAdapter($queryObject, $options);

        return new Pagerfanta(new FantaPaginatorAdapter($paginatorAdapter));
    }

    /**
     * {@inheritdoc}
     */
    public function createPaginatorAdapter($query, $options = array())
    {
        $query = Query::create($query);

        return new TransformedPaginatorAdapter($this->searchable, $query, $options, $this->transformer);
    }
}


1		<?php
2
3		namespace FOS\ElasticaBundle\Finder;
4
5		use Elastica\Document;
6		use FOS\ElasticaBundle\Transformer\ElasticaToModelTransformerInterface;
7		use FOS\ElasticaBundle\Paginator\TransformedPaginatorAdapter;
8		use FOS\ElasticaBundle\Paginator\FantaPaginatorAdapter;
9		use Pagerfanta\Pagerfanta;
10		use Elastica\SearchableInterface;
11		use Elastica\Query;
12
13		/**
14		* Finds elastica documents and map them to persisted objects.
15		*/
16		class TransformedFinder implements PaginatedFinderInterface
17		{
18		protected $searchable;
19		protected $transformer;
20
21		/**
22		* @param SearchableInterface $searchable
23		* @param ElasticaToModelTransformerInterface $transformer
24		*/
25	5	public function __construct(SearchableInterface $searchable, ElasticaToModelTransformerInterface $transformer)
26		{
27	5	$this->searchable = $searchable;
28	5	$this->transformer = $transformer;
29	5	}
30
31		/**
32		* {@inheritdoc}
33		*/
34	1	public function find($query, $limit = null, $options = array())
35		{
36	1	$results = $this->search($query, $limit, $options);
37
38	1	return $this->transformer->transform($results);
39		}
40
41	1	public function findHybrid($query, $limit = null, $options = array())
42		{
43	1	$results = $this->search($query, $limit, $options);
44
45	1	return $this->transformer->hybridTransform($results);
46		}
47
48		/**
49		* Find documents similar to one with passed id.
50		*
51		* @param integer $id
52		* @param array $params
53		* @param array $query
54		*
55		* @return array of model objects
56		**/
57	1	public function moreLikeThis($id, $params = array(), $query = array())
58		{
59	1	$doc = new Document($id);
60	1	$results = $this->searchable->moreLikeThis($doc, $params, $query)->getResults();
		0 ignored issues – show Bug introduced 2015-11-24 05:06 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Elastica\SearchableInterface` as the method `moreLikeThis()` does only exist in the following implementations of said interface: `Elastica\Type`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
61
62	1	return $this->transformer->transform($results);
63		}
64
65		/**
66		* @param $query
67		* @param null\|int $limit
68		* @param array $options
69		*
70		* @return array
71		*/
72	1	protected function search($query, $limit = null, $options = array())
73		{
74	1	$queryObject = Query::create($query);
75	1	if (null !== $limit) {
76	1	$queryObject->setSize($limit);
77		}
78	1	$results = $this->searchable->search($queryObject, $options)->getResults();
79
80	1	return $results;
81		}
82
83		/**
84		* {@inheritdoc}
85		*/
86	1	public function findPaginated($query, $options = array())
87		{
88	1	$queryObject = Query::create($query);
89	1	$paginatorAdapter = $this->createPaginatorAdapter($queryObject, $options);
90
91	1	return new Pagerfanta(new FantaPaginatorAdapter($paginatorAdapter));
92		}
93
94		/**
95		* {@inheritdoc}
96		*/
97	1	public function createPaginatorAdapter($query, $options = array())
98		{
99	1	$query = Query::create($query);
100
101	1	return new TransformedPaginatorAdapter($this->searchable, $query, $options, $this->transformer);
102		}
103		}
104

FriendsOfSymfony / FOSElasticaBundle

Pull Request — master (#1109)

TransformedFinder::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like