RepositoryManagerTest::createFinderMock() - Code Metrics - Inspection of "Repository Manager refactoring" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1119)

by Alessandro

created 2016-08-12 14:14 UTC

RepositoryManagerTest::createFinderMock() A

↳ Parent: RepositoryManagerTest::testThatGetRepositoryReturnsDefaultRepository()

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

namespace FOS\ElasticaBundle\Tests\Manager;

use FOS\ElasticaBundle\Manager\RepositoryManager;

class CustomRepository
{
}

class Entity
{
}

/**
 * @author Richard Miller <[email protected]>
 */
class RepositoryManagerTest extends \PHPUnit_Framework_TestCase
{
    public function testThatGetRepositoryReturnsDefaultRepository()

    {
        /** @var $finderMock \PHPUnit_Framework_MockObject_MockObject|\FOS\ElasticaBundle\Finder\TransformedFinder */
        $finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
            ->disableOriginalConstructor()
            ->getMock();

        /** @var $readerMock \PHPUnit_Framework_MockObject_MockObject|\Doctrine\Common\Annotations\Reader */
        $readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
            ->disableOriginalConstructor()
            ->getMock();

        $typeName = 'index/type';

        $manager = new RepositoryManager($readerMock);

        $manager->addType($typeName, $finderMock);
        $repository = $manager->getRepository($typeName);
        $this->assertInstanceOf('FOS\ElasticaBundle\Repository', $repository);
    }

    public function testThatGetRepositoryReturnsCustomRepository()

    {
        /** @var $finderMock \PHPUnit_Framework_MockObject_MockObject|\FOS\ElasticaBundle\Finder\TransformedFinder */
        $finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
            ->disableOriginalConstructor()
            ->getMock();

        /** @var $readerMock \PHPUnit_Framework_MockObject_MockObject|\Doctrine\Common\Annotations\Reader */
        $readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
            ->disableOriginalConstructor()
            ->getMock();

        $typeName = 'index/type';

        $manager = new RepositoryManager($readerMock);

        $manager->addType($typeName, $finderMock, 'FOS\ElasticaBundle\Tests\Manager\CustomRepository');
        $repository = $manager->getRepository($typeName);
        $this->assertInstanceOf('FOS\ElasticaBundle\Tests\Manager\CustomRepository', $repository);
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testThatGetRepositoryThrowsExceptionIfEntityNotConfigured()

    {
        /** @var $finderMock \PHPUnit_Framework_MockObject_MockObject|\FOS\ElasticaBundle\Finder\TransformedFinder */
        $finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
            ->disableOriginalConstructor()
            ->getMock();

        /** @var $readerMock \PHPUnit_Framework_MockObject_MockObject|\Doctrine\Common\Annotations\Reader */
        $readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
            ->disableOriginalConstructor()
            ->getMock();

        $typeName = 'index/type';

        $manager = new RepositoryManager($readerMock);

        $manager->addType($typeName, $finderMock);
        $manager->getRepository('Missing type');
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testThatGetRepositoryThrowsExceptionIfCustomRepositoryNotFound()

    {
        /** @var $finderMock \PHPUnit_Framework_MockObject_MockObject|\FOS\ElasticaBundle\Finder\TransformedFinder */
        $finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
            ->disableOriginalConstructor()
            ->getMock();

        /** @var $readerMock \PHPUnit_Framework_MockObject_MockObject|\Doctrine\Common\Annotations\Reader */
        $readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
            ->disableOriginalConstructor()
            ->getMock();

        $typeName = 'index/type';

        $manager = new RepositoryManager($readerMock);

        $manager->addType($typeName, $finderMock, 'FOS\ElasticaBundle\Tests\MissingRepository');
        $manager->getRepository($typeName);
    }
}


1		<?php
2
3		namespace FOS\ElasticaBundle\Tests\Manager;
4
5		use FOS\ElasticaBundle\Manager\RepositoryManager;
6
7		class CustomRepository
8		{
9		}
10
11		class Entity
12		{
13		}
14
15		/**
16		* @author Richard Miller <[email protected]>
17		*/
18		class RepositoryManagerTest extends \PHPUnit_Framework_TestCase
19		{
20	View Code Duplication	public function testThatGetRepositoryReturnsDefaultRepository()
		0 ignored issues – show Duplication introduced 2015-11-24 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		/** @var $finderMock \PHPUnit_Framework_MockObject_MockObject\|\FOS\ElasticaBundle\Finder\TransformedFinder */
23		$finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
24		->disableOriginalConstructor()
25		->getMock();
26
27		/** @var $readerMock \PHPUnit_Framework_MockObject_MockObject\|\Doctrine\Common\Annotations\Reader */
28		$readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
29		->disableOriginalConstructor()
30		->getMock();
31
32		$typeName = 'index/type';
33
34		$manager = new RepositoryManager($readerMock);
		0 ignored issues – show Unused Code introduced 2016-08-12 14:20 UTC by Report Bug Copy Issue Report The call to `RepositoryManager::__construct()` has too many arguments starting with `$readerMock`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
35		$manager->addType($typeName, $finderMock);
36		$repository = $manager->getRepository($typeName);
37		$this->assertInstanceOf('FOS\ElasticaBundle\Repository', $repository);
38		}
39
40	View Code Duplication	public function testThatGetRepositoryReturnsCustomRepository()
		0 ignored issues – show Duplication introduced 2015-11-24 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		/** @var $finderMock \PHPUnit_Framework_MockObject_MockObject\|\FOS\ElasticaBundle\Finder\TransformedFinder */
43		$finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
44		->disableOriginalConstructor()
45		->getMock();
46
47		/** @var $readerMock \PHPUnit_Framework_MockObject_MockObject\|\Doctrine\Common\Annotations\Reader */
48		$readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
49		->disableOriginalConstructor()
50		->getMock();
51
52		$typeName = 'index/type';
53
54		$manager = new RepositoryManager($readerMock);
		0 ignored issues – show Unused Code introduced 2016-08-12 14:20 UTC by Report Bug Copy Issue Report The call to `RepositoryManager::__construct()` has too many arguments starting with `$readerMock`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
55		$manager->addType($typeName, $finderMock, 'FOS\ElasticaBundle\Tests\Manager\CustomRepository');
56		$repository = $manager->getRepository($typeName);
57		$this->assertInstanceOf('FOS\ElasticaBundle\Tests\Manager\CustomRepository', $repository);
58		}
59
60		/**
61		* @expectedException \RuntimeException
62		*/
63	View Code Duplication	public function testThatGetRepositoryThrowsExceptionIfEntityNotConfigured()
		0 ignored issues – show Duplication introduced 2015-11-24 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		/** @var $finderMock \PHPUnit_Framework_MockObject_MockObject\|\FOS\ElasticaBundle\Finder\TransformedFinder */
66		$finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
67		->disableOriginalConstructor()
68		->getMock();
69
70		/** @var $readerMock \PHPUnit_Framework_MockObject_MockObject\|\Doctrine\Common\Annotations\Reader */
71		$readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
72		->disableOriginalConstructor()
73		->getMock();
74
75		$typeName = 'index/type';
76
77		$manager = new RepositoryManager($readerMock);
		0 ignored issues – show Unused Code introduced 2016-08-12 14:20 UTC by Report Bug Copy Issue Report The call to `RepositoryManager::__construct()` has too many arguments starting with `$readerMock`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
78		$manager->addType($typeName, $finderMock);
79		$manager->getRepository('Missing type');
80		}
81
82		/**
83		* @expectedException \RuntimeException
84		*/
85	View Code Duplication	public function testThatGetRepositoryThrowsExceptionIfCustomRepositoryNotFound()
		0 ignored issues – show Duplication introduced 2015-11-24 05:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		{
87		/** @var $finderMock \PHPUnit_Framework_MockObject_MockObject\|\FOS\ElasticaBundle\Finder\TransformedFinder */
88		$finderMock = $this->getMockBuilder('FOS\ElasticaBundle\Finder\TransformedFinder')
89		->disableOriginalConstructor()
90		->getMock();
91
92		/** @var $readerMock \PHPUnit_Framework_MockObject_MockObject\|\Doctrine\Common\Annotations\Reader */
93		$readerMock = $this->getMockBuilder('Doctrine\Common\Annotations\Reader')
94		->disableOriginalConstructor()
95		->getMock();
96
97		$typeName = 'index/type';
98
99		$manager = new RepositoryManager($readerMock);
		0 ignored issues – show Unused Code introduced 2016-08-12 14:20 UTC by Report Bug Copy Issue Report The call to `RepositoryManager::__construct()` has too many arguments starting with `$readerMock`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
100		$manager->addType($typeName, $finderMock, 'FOS\ElasticaBundle\Tests\MissingRepository');
101		$manager->getRepository($typeName);
102		}
103		}
104

FriendsOfSymfony / FOSElasticaBundle

Pull Request — master (#1119)

RepositoryManagerTest::createFinderMock() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like