PreFetchObjectsEventTest - Code Metrics - Inspection of "Merge pull request #1320 from formapro-forks/4x-to..." - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e4cd8...063296 )

by Maksim

created 2017-12-08 08:58 UTC

PreFetchObjectsEventTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	94
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	11
lcom	1
cbo	2
dl	94
loc	94
rs	10
c	0
b	0
f	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	testShouldBeSubClassOfEventClass()	6	6	1
A	testShouldFinal()	6	6	1
A	testCouldBeConstructedWithPagerAndObjectPersisterAndOptions()	4	4	1
A	testShouldAllowGetPagerSetInConstructor()	8	8	1
A	testShouldAllowGetPreviouslySetPager()	9	9	1
A	testShouldAllowGetObjectPersisterSetInConstructor()	8	8	1
A	testShouldAllowGetPreviouslySetObjectsPersister()	9	9	1
A	testShouldAllowGetOptionsSetInConstructor()	8	8	1
A	testShouldAllowGetPreviouslySetOptions()	9	9	1
A	createObjectPersisterMock()	4	4	1
A	createPagerMock()	4	4	1

How to fix Duplicated Code

<?php
namespace FOS\ElasticaBundle\Tests\Persister\Event;

use FOS\ElasticaBundle\Persister\Event\PreFetchObjectsEvent;
use FOS\ElasticaBundle\Persister\ObjectPersisterInterface;
use FOS\ElasticaBundle\Provider\PagerInterface;
use Symfony\Component\EventDispatcher\Event;

final class PreFetchObjectsEventTest extends \PHPUnit_Framework_TestCase

{
    public function testShouldBeSubClassOfEventClass()
    {
        $rc = new \ReflectionClass(PreFetchObjectsEvent::class);

        $this->assertTrue($rc->isSubclassOf(Event::class));
    }

    public function testShouldFinal()
    {
        $rc = new \ReflectionClass(PreFetchObjectsEvent::class);

        $this->assertTrue($rc->isFinal());
    }

    public function testCouldBeConstructedWithPagerAndObjectPersisterAndOptions()
    {
        new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), []);

    }

    public function testShouldAllowGetPagerSetInConstructor()
    {
        $expectedPager = $this->createPagerMock();

        $event = new PreFetchObjectsEvent($expectedPager, $this->createObjectPersisterMock(), []);


        $this->assertSame($expectedPager, $event->getPager());
    }

    public function testShouldAllowGetPreviouslySetPager()
    {
        $event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), []);


        $expectedPager = $this->createPagerMock();
        $event->setPager($expectedPager);

        $this->assertSame($expectedPager, $event->getPager());
    }

    public function testShouldAllowGetObjectPersisterSetInConstructor()
    {
        $expectedPersister = $this->createObjectPersisterMock();

        $event = new PreFetchObjectsEvent($this->createPagerMock(), $expectedPersister, []);


        $this->assertSame($expectedPersister, $event->getObjectPersister());
    }

    public function testShouldAllowGetPreviouslySetObjectsPersister()
    {
        $event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), []);


        $expectedPersister = $this->createObjectPersisterMock();
        $event->setObjectPersister($expectedPersister);

        $this->assertSame($expectedPersister, $event->getObjectPersister());
    }

    public function testShouldAllowGetOptionsSetInConstructor()
    {
        $expectedOptions = ['foo' => 'fooVal', 'bar' => 'barVal'];

        $event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), $expectedOptions);


        $this->assertSame($expectedOptions, $event->getOptions());
    }

    public function testShouldAllowGetPreviouslySetOptions()
    {
        $event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), ['foo' => 'fooVal', 'bar' => 'barVal']);


        $expectedOptions = ['foo' => 'fooNewVal', 'bar' => 'barnewVal'];
        $event->setOptions($expectedOptions);

        $this->assertSame($expectedOptions, $event->getOptions());
    }

    /**
     * @return ObjectPersisterInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createObjectPersisterMock()
    {
        return $this->getMock(ObjectPersisterInterface::class, [], [], '', false);

    }

    /**
     * @return PagerInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createPagerMock()
    {
        return $this->getMock(PagerInterface::class, [], [], '', false);

    }
}


1		<?php
2		namespace FOS\ElasticaBundle\Tests\Persister\Event;
3
4		use FOS\ElasticaBundle\Persister\Event\PreFetchObjectsEvent;
5		use FOS\ElasticaBundle\Persister\ObjectPersisterInterface;
6		use FOS\ElasticaBundle\Provider\PagerInterface;
7		use Symfony\Component\EventDispatcher\Event;
8
9	View Code Duplication	final class PreFetchObjectsEventTest extends \PHPUnit_Framework_TestCase
		0 ignored issues – show Duplication introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		public function testShouldBeSubClassOfEventClass()
12		{
13		$rc = new \ReflectionClass(PreFetchObjectsEvent::class);
14
15		$this->assertTrue($rc->isSubclassOf(Event::class));
16		}
17
18		public function testShouldFinal()
19		{
20		$rc = new \ReflectionClass(PreFetchObjectsEvent::class);
21
22		$this->assertTrue($rc->isFinal());
23		}
24
25		public function testCouldBeConstructedWithPagerAndObjectPersisterAndOptions()
26		{
27		new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
28		}
29
30		public function testShouldAllowGetPagerSetInConstructor()
31		{
32		$expectedPager = $this->createPagerMock();
33
34		$event = new PreFetchObjectsEvent($expectedPager, $this->createObjectPersisterMock(), []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
35
36		$this->assertSame($expectedPager, $event->getPager());
37		}
38
39		public function testShouldAllowGetPreviouslySetPager()
40		{
41		$event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
42
43		$expectedPager = $this->createPagerMock();
44		$event->setPager($expectedPager);
45
46		$this->assertSame($expectedPager, $event->getPager());
47		}
48
49		public function testShouldAllowGetObjectPersisterSetInConstructor()
50		{
51		$expectedPersister = $this->createObjectPersisterMock();
52
53		$event = new PreFetchObjectsEvent($this->createPagerMock(), $expectedPersister, []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
54
55		$this->assertSame($expectedPersister, $event->getObjectPersister());
56		}
57
58		public function testShouldAllowGetPreviouslySetObjectsPersister()
59		{
60		$event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
61
62		$expectedPersister = $this->createObjectPersisterMock();
63		$event->setObjectPersister($expectedPersister);
64
65		$this->assertSame($expectedPersister, $event->getObjectPersister());
66		}
67
68		public function testShouldAllowGetOptionsSetInConstructor()
69		{
70		$expectedOptions = ['foo' => 'fooVal', 'bar' => 'barVal'];
71
72		$event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), $expectedOptions);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
73
74		$this->assertSame($expectedOptions, $event->getOptions());
75		}
76
77		public function testShouldAllowGetPreviouslySetOptions()
78		{
79		$event = new PreFetchObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), ['foo' => 'fooVal', 'bar' => 'barVal']);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
80
81		$expectedOptions = ['foo' => 'fooNewVal', 'bar' => 'barnewVal'];
82		$event->setOptions($expectedOptions);
83
84		$this->assertSame($expectedOptions, $event->getOptions());
85		}
86
87		/**
88		* @return ObjectPersisterInterface\|\PHPUnit_Framework_MockObject_MockObject
89		*/
90		private function createObjectPersisterMock()
91		{
92		return $this->getMock(ObjectPersisterInterface::class, [], [], '', false);
		0 ignored issues – show Deprecated Code introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
93		}
94
95		/**
96		* @return PagerInterface\|\PHPUnit_Framework_MockObject_MockObject
97		*/
98		private function createPagerMock()
99		{
100		return $this->getMock(PagerInterface::class, [], [], '', false);
		0 ignored issues – show Deprecated Code introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
101		}
102		}
103

FriendsOfSymfony / FOSElasticaBundle

Push — master ( 4e4cd8...063296 )

PreFetchObjectsEventTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like