PostInsertObjectsEventTest - Code Metrics - Inspection of "4x to master" - FriendsOfSymfony/FOSElasticaBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1320)

by Maksim

created 2017-12-07 12:36 UTC

PostInsertObjectsEventTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	78
Duplicated Lines	10.26 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	2
dl	8
loc	78
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testShouldBeSubClassOfEventClass()	0	6	1
A	testShouldFinal()	0	6	1
A	testCouldBeConstructedWithPagerAndObjectPersisterAndObjectsAndOptions()	0	9	1
A	testShouldAllowGetPagerSetInConstructor()	0	8	1
A	testShouldAllowGetObjectPersisterSetInConstructor()	0	8	1
A	testShouldAllowGetOptionsSetInConstructor()	0	8	1
A	testShouldAllowGetObjectsSetInConstructor()	8	8	1
A	createObjectPersisterMock()	0	4	1
A	createPagerMock()	0	4	1

How to fix Duplicated Code

<?php
namespace FOS\ElasticaBundle\Tests\Persister\Event;

use FOS\ElasticaBundle\Persister\Event\PostInsertObjectsEvent;
use FOS\ElasticaBundle\Persister\ObjectPersisterInterface;
use FOS\ElasticaBundle\Provider\PagerInterface;
use Symfony\Component\EventDispatcher\Event;

final class PostInsertObjectsEventTest extends \PHPUnit_Framework_TestCase
{
    public function testShouldBeSubClassOfEventClass()
    {
        $rc = new \ReflectionClass(PostInsertObjectsEvent::class);

        $this->assertTrue($rc->isSubclassOf(Event::class));
    }

    public function testShouldFinal()
    {
        $rc = new \ReflectionClass(PostInsertObjectsEvent::class);

        $this->assertTrue($rc->isFinal());
    }

    public function testCouldBeConstructedWithPagerAndObjectPersisterAndObjectsAndOptions()
    {
        new PostInsertObjectsEvent(
            $this->createPagerMock(),

            $this->createObjectPersisterMock(),

            $objects = [],
            $options = []
        );
    }

    public function testShouldAllowGetPagerSetInConstructor()
    {
        $expectedPager = $this->createPagerMock();

        $event = new PostInsertObjectsEvent($expectedPager, $this->createObjectPersisterMock(), [], []);


        $this->assertSame($expectedPager, $event->getPager());
    }

    public function testShouldAllowGetObjectPersisterSetInConstructor()
    {
        $expectedPersister = $this->createObjectPersisterMock();

        $event = new PostInsertObjectsEvent($this->createPagerMock(), $expectedPersister, [], []);


        $this->assertSame($expectedPersister, $event->getObjectPersister());
    }

    public function testShouldAllowGetOptionsSetInConstructor()
    {
        $expectedOptions = ['foo' => 'fooVal', 'bar' => 'barVal'];

        $event = new PostInsertObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), [], $expectedOptions);


        $this->assertSame($expectedOptions, $event->getOptions());
    }

    public function testShouldAllowGetObjectsSetInConstructor()
    {
        $expectedObjects = [new \stdClass(), new \stdClass()];

        $event = new PostInsertObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), $expectedObjects, []);


        $this->assertSame($expectedObjects, $event->getObjects());
    }

    /**
     * @return ObjectPersisterInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createObjectPersisterMock()
    {
        return $this->getMock(ObjectPersisterInterface::class, [], [], '', false);

    }

    /**
     * @return PagerInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createPagerMock()
    {
        return $this->getMock(PagerInterface::class, [], [], '', false);

    }
}


1		<?php
2		namespace FOS\ElasticaBundle\Tests\Persister\Event;
3
4		use FOS\ElasticaBundle\Persister\Event\PostInsertObjectsEvent;
5		use FOS\ElasticaBundle\Persister\ObjectPersisterInterface;
6		use FOS\ElasticaBundle\Provider\PagerInterface;
7		use Symfony\Component\EventDispatcher\Event;
8
9		final class PostInsertObjectsEventTest extends \PHPUnit_Framework_TestCase
10		{
11		public function testShouldBeSubClassOfEventClass()
12		{
13		$rc = new \ReflectionClass(PostInsertObjectsEvent::class);
14
15		$this->assertTrue($rc->isSubclassOf(Event::class));
16		}
17
18		public function testShouldFinal()
19		{
20		$rc = new \ReflectionClass(PostInsertObjectsEvent::class);
21
22		$this->assertTrue($rc->isFinal());
23		}
24
25		public function testCouldBeConstructedWithPagerAndObjectPersisterAndObjectsAndOptions()
26		{
27		new PostInsertObjectsEvent(
28		$this->createPagerMock(),
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
29		$this->createObjectPersisterMock(),
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
30		$objects = [],
31		$options = []
32		);
33		}
34
35		public function testShouldAllowGetPagerSetInConstructor()
36		{
37		$expectedPager = $this->createPagerMock();
38
39		$event = new PostInsertObjectsEvent($expectedPager, $this->createObjectPersisterMock(), [], []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
40
41		$this->assertSame($expectedPager, $event->getPager());
42		}
43
44		public function testShouldAllowGetObjectPersisterSetInConstructor()
45		{
46		$expectedPersister = $this->createObjectPersisterMock();
47
48		$event = new PostInsertObjectsEvent($this->createPagerMock(), $expectedPersister, [], []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
49
50		$this->assertSame($expectedPersister, $event->getObjectPersister());
51		}
52
53		public function testShouldAllowGetOptionsSetInConstructor()
54		{
55		$expectedOptions = ['foo' => 'fooVal', 'bar' => 'barVal'];
56
57		$event = new PostInsertObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), [], $expectedOptions);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
58
59		$this->assertSame($expectedOptions, $event->getOptions());
60		}
61
62	View Code Duplication	public function testShouldAllowGetObjectsSetInConstructor()
63		{
64		$expectedObjects = [new \stdClass(), new \stdClass()];
65
66		$event = new PostInsertObjectsEvent($this->createPagerMock(), $this->createObjectPersisterMock(), $expectedObjects, []);
		0 ignored issues – show Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createPagerMock()` targeting `FOS\ElasticaBundle\Tests...Test::createPagerMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...rovider\PagerInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Bug introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report It seems like `$this->createObjectPersisterMock()` targeting `FOS\ElasticaBundle\Tests...teObjectPersisterMock()` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `FOS\ElasticaBundle\Persi...ctsEvent::__construct()` does only seem to accept `object<FOS\ElasticaBundl...jectPersisterInterface>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
67
68		$this->assertSame($expectedObjects, $event->getObjects());
69		}
70
71		/**
72		* @return ObjectPersisterInterface\|\PHPUnit_Framework_MockObject_MockObject
73		*/
74		private function createObjectPersisterMock()
75		{
76		return $this->getMock(ObjectPersisterInterface::class, [], [], '', false);
		0 ignored issues – show Deprecated Code introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
77		}
78
79		/**
80		* @return PagerInterface\|\PHPUnit_Framework_MockObject_MockObject
81		*/
82		private function createPagerMock()
83		{
84		return $this->getMock(PagerInterface::class, [], [], '', false);
		0 ignored issues – show Deprecated Code introduced 2017-12-06 21:20 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::getMock()` has been deprecated with message: Method deprecated since Release 5.4.0; use createMock() or getMockBuilder() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
85		}
86		}
87

FriendsOfSymfony / FOSElasticaBundle

Pull Request — master (#1320)

PostInsertObjectsEventTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like