Ivory\CKEditorBundle\Tests\DependencyInjection\Compiler\ResourceCompilerPassTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	85
Duplicated Lines	67.06 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	4	1
B	testTwigResource()	30	30	1
B	testPhpResource()	27	27	1
A	createContainerBuilderMock()	0	7	1

<?php

/*
 * This file is part of the Ivory CKEditor package.
 *
 * (c) Eric GELOEN <geloen.eric@gmail.com>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace FOS\CKEditorBundle\Tests\DependencyInjection\Compiler;

use FOS\CKEditorBundle\DependencyInjection\Compiler\ResourceCompilerPass;
use FOS\CKEditorBundle\Tests\AbstractTestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
 * @author GeLo <geloen.eric@gmail.com>
 */
class ResourceCompilerPassTest extends AbstractTestCase
{
    /**
     * @var ResourceCompilerPass
     */
    private $compilerPass;

    /**
     * {@inheritdoc}
     */
    protected function setUp()
    {
        $this->compilerPass = new ResourceCompilerPass();
    }

    public function testTwigResource()

This method seems to be duplicated in your project.

    {
        $containerBuilder = $this->createContainerBuilderMock();
        $containerBuilder

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in Symfony\Component\DependencyInjection\ContainerBuilder.

            ->expects($this->exactly(2))
            ->method('hasParameter')
            ->will($this->returnValueMap([
                ['templating.helper.form.resources', false],
                [$parameter = 'twig.form.resources', true],
            ]));

        $containerBuilder
            ->expects($this->once())
            ->method('getParameter')
            ->with($this->identicalTo($parameter))
            ->will($this->returnValue([$template = 'layout.html.twig']));

        $containerBuilder
            ->expects($this->once())
            ->method('setParameter')
            ->with(
                $this->identicalTo($parameter),
                $this->identicalTo([
                    '@FOSCKEditor/Form/ckeditor_widget.html.twig',
                    $template,
                ])
            );

        $this->compilerPass->process($containerBuilder);

It seems like $containerBuilder defined by $this->createContainerBuilderMock() on line 38 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, FOS\CKEditorBundle\DependencyInjection\Compiler\ResourceCompilerPass::process() does only seem to accept object<Symfony\Component\DependencyInjection\ContainerBuilder>, maybe add an additional type check?

    }

    public function testPhpResource()

This method seems to be duplicated in your project.

    {
        $containerBuilder = $this->createContainerBuilderMock();
        $containerBuilder

The method expects does only exist in PHPUnit_Framework_MockObject_MockObject, but not in Symfony\Component\DependencyInjection\ContainerBuilder.

            ->expects($this->exactly(2))
            ->method('hasParameter')
            ->will($this->returnValueMap([
                [$parameter = 'templating.helper.form.resources', true],
                ['twig.form.resources', false],
            ]));

        $containerBuilder
            ->expects($this->once())
            ->method('getParameter')
            ->with($this->identicalTo($parameter))
            ->will($this->returnValue([$template = 'layout.html.php']));

        $containerBuilder
            ->expects($this->once())
            ->method('setParameter')
            ->with(
                $this->identicalTo($parameter),
                $this->identicalTo(['FOSCKEditorBundle:Form', $template])
            );

        $this->compilerPass->process($containerBuilder);

It seems like $containerBuilder defined by $this->createContainerBuilderMock() on line 69 can also be of type object<PHPUnit_Framework_MockObject_MockObject>; however, FOS\CKEditorBundle\DependencyInjection\Compiler\ResourceCompilerPass::process() does only seem to accept object<Symfony\Component\DependencyInjection\ContainerBuilder>, maybe add an additional type check?

    }

    /**
     * @return ContainerBuilder|\PHPUnit_Framework_MockObject_MockObject
     */
    private function createContainerBuilderMock()
    {
        return $this->getMockBuilder(ContainerBuilder::class)
            ->disableOriginalConstructor()
            ->setMethods(['hasParameter', 'getParameter', 'setParameter'])
            ->getMock();
    }
}