MessageBoxField::FieldHolder() - Code Metrics - FriendsOfSilverStripe/backendmessages - Measure and Improve Code Quality continuously with Scrutinizer

MessageBoxField::FieldHolder() A
last analyzed 2016-10-21 20:23 UTC

↳ Parent: MessageBoxField

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1

<?php
/**
 * This field lets you put an arbitrary message box into your backend.
 *
 * <code>
 * MessageBoxField::create(
 *    $name = "yourmessageboxfield",
 *    $content = 'your message'
 * )->addCSSClass('notice');
 * </code>
 */
class MessageBoxField extends LiteralField
namespace YourVendor;

class YourClass { }
{
    /**
     * @var string
     */
    protected $classes = 'message';

    /**
     * @var string
     */
    public function addCSSClass($CSSClass)
    {
        $this->classes .= ' '.(string) $CSSClass;

        return $this;
    }

    /**
     * adjusts the return to include the required classes.
     *
     * @param array $properties
     *
     * @return string
     */
    public function FieldHolder($properties = array())
    {
        $content = $this->content;

        if ($content instanceof ViewableData) {
            if ($properties) {

                $content = $content->customise($properties);
            }

            $content = $content->forTemplate();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return '<p class="'.$this->classes.'"" name="'.$this->getName().'">'.$content.'</p>';
    }
}


1			<?php
2			/**
3			* This field lets you put an arbitrary message box into your backend.
4			*
5			* <code>
6			* MessageBoxField::create(
7			* $name = "yourmessageboxfield",
8			* $content = 'your message'
9			* )->addCSSClass('notice');
10			* </code>
11			*/
12			class MessageBoxField extends LiteralField
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-13 05:55 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
13			{
14			/**
15			* @var string
16			*/
17			protected $classes = 'message';
18
19			/**
20			* @var string
21			*/
22			public function addCSSClass($CSSClass)
23			{
24			$this->classes .= ' '.(string) $CSSClass;
25
26			return $this;
27			}
28
29			/**
30			* adjusts the return to include the required classes.
31			*
32			* @param array $properties
33			*
34			* @return string
35			*/
36			public function FieldHolder($properties = array())
37			{
38			$content = $this->content;
39
40			if ($content instanceof ViewableData) {
41			if ($properties) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-13 05:55 UTC by Report Bug Copy Issue Report The expression `$properties` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
42			$content = $content->customise($properties);
43			}
44
45			$content = $content->forTemplate();
			0 ignored issues – show Bug introduced 2015-12-13 05:55 UTC by Report Bug Copy Issue Report The method `forTemplate` does only exist in `FormField`, but not in `ViewableData_Customised`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
46			}
47
48			return '<p class="'.$this->classes.'"" name="'.$this->getName().'">'.$content.'</p>';
49			}
50			}
51

FriendsOfSilverStripe / backendmessages

MessageBoxField::FieldHolder() A last analyzed 2016-10-21 20:23 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

MessageBoxField::FieldHolder() A
last analyzed 2016-10-21 20:23 UTC