Issues in BrandColors.php (master) - Issues in master - FriendsOfSilverStripe/HandyPages - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/models/BrandColors.php (1 issue)

Labels

Documentation 1

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Just a holder for a brand color defined by the administrator. Usually done in the SiteConfig, see extension.
 *
 * @author Peter Thaleikis
 */

class BrandColors extends SubsiteSafeDataObject
{
    /**
     * @var array
     */
    private static $db = [
        'ColorName' => 'varchar(50)',
        'ColorCode' => 'varchar(50)',
        'CSSClass' => 'varchar(50)',
        'SubsiteID' => 'int',
        'Sort' => 'int',
        'BrandColor' => 'varchar(50)',
    ];

    /**
     * @var array
     */
    private static $summary_fields = [
        'ColorName' => 'Color name',
        'ColorCode' => 'Color code',
        'CSSClass' => 'CSS class',
    ];

    /**
     * saves the actual value we want to use in the db. no live calculated because it will be static anyway.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();

        $this->BrandColor = (strlen($this->CSSClass) == 0) ? $this->ColorCode : $this->CSSClass;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * make the form a bit more usable.
     *
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        // "disclaimer"
        $fields->addFieldToTab(
            'Root.Main',
            WarningMessage::create('Warning: Please be careful with the following settings. Any changes can decrease the accessibility or violate the branding guide lines.'),
            'ColorName'
        );

        // give the option to actually select a color.
        $fields->replaceField(
            'ColorCode',
            ColourPicker::create('ColorCode', 'Color code')
                ->setRightTitle('Please ensure the color is exactly the intended value.')
        );

        // add some words around this to make it more usable.
        $fields->dataFieldByName('CSSClass')
            ->setTitle('CSS class')
            ->setRightTitle('This CSS class will be return <b>instead</b> of the color code, if defined.');
        $fields->dataFieldByName('ColorName')
            ->setTitle('Color name')
            ->setRightTitle('This name will be displayed throughout the administration interface.');

        // hide some fields like the subsiteid (only if subsite module) is installed.
        $fields->replaceField('BrandColor', HiddenField::create('BrandColor', 'BrandColor', $this->BrandColor));
        if (class_exists('Subsite')) {
            $fields->replaceField(
                'SubsiteID',
                HiddenField::create('SubsiteID', 'Subsite', Subsite::currentSubsite())
            );
        }

        // no one cares about the sort order
        $fields->replaceField('Sort', HiddenField::create('Sort', 'Sort', $this->Sort));

        return $fields;
    }
}


1			<?php
2
3			/**
4			* Just a holder for a brand color defined by the administrator. Usually done in the SiteConfig, see extension.
5			*
6			* @author Peter Thaleikis
7			*/
8
9			class BrandColors extends SubsiteSafeDataObject
10			{
11			/**
12			* @var array
13			*/
14			private static $db = [
15			'ColorName' => 'varchar(50)',
16			'ColorCode' => 'varchar(50)',
17			'CSSClass' => 'varchar(50)',
18			'SubsiteID' => 'int',
19			'Sort' => 'int',
20			'BrandColor' => 'varchar(50)',
21			];
22
23			/**
24			* @var array
25			*/
26			private static $summary_fields = [
27			'ColorName' => 'Color name',
28			'ColorCode' => 'Color code',
29			'CSSClass' => 'CSS class',
30			];
31
32			/**
33			* saves the actual value we want to use in the db. no live calculated because it will be static anyway.
34			*/
35			public function onBeforeWrite()
36			{
37			parent::onBeforeWrite();
38
39			$this->BrandColor = (strlen($this->CSSClass) == 0) ? $this->ColorCode : $this->CSSClass;
			0 ignored issues – show Documentation introduced 2016-07-04 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `BrandColor` does not exist on `object<BrandColors>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			}
41
42			/**
43			* make the form a bit more usable.
44			*
45			* @return FieldList
46			*/
47			public function getCMSFields()
48			{
49			$fields = parent::getCMSFields();
50
51			// "disclaimer"
52			$fields->addFieldToTab(
53			'Root.Main',
54			WarningMessage::create('Warning: Please be careful with the following settings. Any changes can decrease the accessibility or violate the branding guide lines.'),
55			'ColorName'
56			);
57
58			// give the option to actually select a color.
59			$fields->replaceField(
60			'ColorCode',
61			ColourPicker::create('ColorCode', 'Color code')
62			->setRightTitle('Please ensure the color is exactly the intended value.')
63			);
64
65			// add some words around this to make it more usable.
66			$fields->dataFieldByName('CSSClass')
67			->setTitle('CSS class')
68			->setRightTitle('This CSS class will be return <b>instead</b> of the color code, if defined.');
69			$fields->dataFieldByName('ColorName')
70			->setTitle('Color name')
71			->setRightTitle('This name will be displayed throughout the administration interface.');
72
73			// hide some fields like the subsiteid (only if subsite module) is installed.
74			$fields->replaceField('BrandColor', HiddenField::create('BrandColor', 'BrandColor', $this->BrandColor));
75			if (class_exists('Subsite')) {
76			$fields->replaceField(
77			'SubsiteID',
78			HiddenField::create('SubsiteID', 'Subsite', Subsite::currentSubsite())
79			);
80			}
81
82			// no one cares about the sort order
83			$fields->replaceField('Sort', HiddenField::create('Sort', 'Sort', $this->Sort));
84
85			return $fields;
86			}
87			}
88

FriendsOfSilverStripe / HandyPages

Issues (13)

Security Analysis no request data

code/models/BrandColors.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like