GenericPage::getCMSFields() - Code Metrics - FriendsOfSilverStripe/HandyPages - Measure and Improve Code Quality continuously with Scrutinizer

GenericPage::getCMSFields() B
last analyzed 2020-08-21 20:11 UTC

↳ Parent: GenericPage

Complexity

Conditions	8
Paths	96

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
nc	96
nop	0
dl	0
loc	69
rs	7.4319
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * The core of HandyPages is this generic page - contains all logic and smarts.
 *
 * @author Peter Thaleikis
 */

class GenericPage extends Page
{
    /**
     * @var array
     */
    private static $db = [
        'AlternativeTitle' => 'varchar(50)',
        'Intro' => 'varchar(1000)',
        'Color' => 'varchar(50)',
    ];

    /**
     * @var array
     */
    private static $has_one = [
        'Image' => 'Image',
    ];

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $hiddenFields = $this->config()->get('hideCMSInputs');

        // short title?
        if (!in_array('AlternativeTitle', $hiddenFields)) {
            $fields->addFieldToTab(
                'Root.Main',
                TextField::create('AlternativeTitle', 'Alternative Title'),
                'URLSegment'
            );
        }

        // do we want an intro?
        if (!in_array('Intro', $hiddenFields)) {
            $fields->addFieldToTab(
                'Root.Main',
                TextareaField::create('Intro', 'Intro'),
                'Content'
            );
        }

        // add an image
        if (!in_array('Image', $hiddenFields)) {
            $fields->addFieldToTab(
                'Root.Main',
                UploadField::create('ImageID', 'Image')
                    ->setAllowedFileCategories('image')
                    ->setAllowedMaxFileNumber(1),
                'Content'
            );
        }

        // do we use a section color?
        if (!in_array('Color', $hiddenFields)) {
            // default is this brand color.
            $field = NoticeMessage::create('The brand colors have not been defined yet.');

            // usually we replace this with the color palette.
            if (BrandColors::get()->count() > 0) {
                $field = ColorPaletteField::create(
                    'Color',
                    'Color',
                    BrandColors::get()->map('BrandColor', 'ColorName')
                )->setRightTitle('Please select a brand color.');
            }

            $fields->addFieldToTab('Root.Main', $field, 'Content');
        }

        // It will repalce Content area field to notice message field, or nothing at the end.
        if ($this->config()->get('useBlocksModule')) {
            // move the block related fields over
            $fields->addFieldsToTab('Root.Main', $fields->findOrMakeTab('Root.Blocks')->Fields(), 'Content');

            // now we really don't need the content field anymore.
            $fields->removeByName('Content');

            // remove the blocks tab
            $fields->removeByName('Root.Blocks');
        }
        if ($this->config()->get('hideContentField')) {
            $fields->removebyName('Content');
        }

        return $fields;
    }

    /**
     * @return ZenValidator
     */
    public function getCMSValidator()
    {
        // create any validation contrain we need
        $validator = ZenValidator::create();

        foreach ($this->config()->get('validation') as $field => $validation) {
            // protection against misconfiguration: is this field actually shown? no? okay, don't validate.
            if (in_array($field, $this->config()->hideCMSInputs)) {
                // just required?
                if (array_key_exists('required', $validation)) {
                    $validator->setConstraint(
                        $field,
                        Constraint_require::create()->setMessage('This field is required.')
                    );
                }

                // min length?
                if (array_key_exists('minLength', $validation)) {

                    $validator->setConstraint(
                        $field,
                        Constraint_length::create('min', $validation['minLength'])
                            ->setMessage(sprintf('Please enter at least %d characters.', $validation['minLength']))
                    );
                }

                // max length?
                if (array_key_exists('maxLength', $validation)) {

                    $validator->setConstraint(
                        $field,
                        Constraint_length::create('max', $validation['maxLength'])
                            ->setMessage(sprintf('Please enter maximal %d characters.', $validation['maxLength']))
                    );
                }

                // width?
                if (array_key_exists('width', $validation)) {

                    $validator->setConstraint(
                        $field,
                        Constraint_dimension::create('width', $validation['width'])
                            ->setMessage(sprintf(
                                'Please upload an image with an width of %s pixel.',
                                $validation['width']
                            )
                        )
                    );
                }

                // height?
                if (array_key_exists('height', $validation)) {

                    $validator->setConstraint(
                        $field,
                        Constraint_dimension::create('height', $validation['height'])
                            ->setMessage(sprintf(
                                'Please upload an image with an height of %s pixel.',
                                $validation['height']
                            )
                        )
                    );
                }
            }
        }

        $this->extend('updateCMSValidator', $validator);

        return $validator;
    }
}

class GenericPage_Controller extends Page_Controller
{
}


1		<?php
2
3		/**
4		* The core of HandyPages is this generic page - contains all logic and smarts.
5		*
6		* @author Peter Thaleikis
7		*/
8
9		class GenericPage extends Page
10		{
11		/**
12		* @var array
13		*/
14		private static $db = [
15		'AlternativeTitle' => 'varchar(50)',
16		'Intro' => 'varchar(1000)',
17		'Color' => 'varchar(50)',
18		];
19
20		/**
21		* @var array
22		*/
23		private static $has_one = [
24		'Image' => 'Image',
25		];
26
27		/**
28		* @return FieldList
29		*/
30		public function getCMSFields()
31		{
32		$fields = parent::getCMSFields();
33
34		$hiddenFields = $this->config()->get('hideCMSInputs');
35
36		// short title?
37		if (!in_array('AlternativeTitle', $hiddenFields)) {
38		$fields->addFieldToTab(
39		'Root.Main',
40		TextField::create('AlternativeTitle', 'Alternative Title'),
41		'URLSegment'
42		);
43		}
44
45		// do we want an intro?
46		if (!in_array('Intro', $hiddenFields)) {
47		$fields->addFieldToTab(
48		'Root.Main',
49		TextareaField::create('Intro', 'Intro'),
50		'Content'
51		);
52		}
53
54		// add an image
55		if (!in_array('Image', $hiddenFields)) {
56		$fields->addFieldToTab(
57		'Root.Main',
58		UploadField::create('ImageID', 'Image')
59		->setAllowedFileCategories('image')
60		->setAllowedMaxFileNumber(1),
61		'Content'
62		);
63		}
64
65		// do we use a section color?
66		if (!in_array('Color', $hiddenFields)) {
67		// default is this brand color.
68		$field = NoticeMessage::create('The brand colors have not been defined yet.');
69
70		// usually we replace this with the color palette.
71		if (BrandColors::get()->count() > 0) {
72		$field = ColorPaletteField::create(
73		'Color',
74		'Color',
75		BrandColors::get()->map('BrandColor', 'ColorName')
76		)->setRightTitle('Please select a brand color.');
77		}
78
79		$fields->addFieldToTab('Root.Main', $field, 'Content');
80		}
81
82		// It will repalce Content area field to notice message field, or nothing at the end.
83		if ($this->config()->get('useBlocksModule')) {
84		// move the block related fields over
85		$fields->addFieldsToTab('Root.Main', $fields->findOrMakeTab('Root.Blocks')->Fields(), 'Content');
86
87		// now we really don't need the content field anymore.
88		$fields->removeByName('Content');
89
90		// remove the blocks tab
91		$fields->removeByName('Root.Blocks');
92		}
93		if ($this->config()->get('hideContentField')) {
94		$fields->removebyName('Content');
95		}
96
97		return $fields;
98		}
99
100		/**
101		* @return ZenValidator
102		*/
103		public function getCMSValidator()
104		{
105		// create any validation contrain we need
106		$validator = ZenValidator::create();
107
108		foreach ($this->config()->get('validation') as $field => $validation) {
109		// protection against misconfiguration: is this field actually shown? no? okay, don't validate.
110		if (in_array($field, $this->config()->hideCMSInputs)) {
111		// just required?
112		if (array_key_exists('required', $validation)) {
113		$validator->setConstraint(
114		$field,
115		Constraint_require::create()->setMessage('This field is required.')
116		);
117		}
118
119		// min length?
120	View Code Duplication	if (array_key_exists('minLength', $validation)) {
		0 ignored issues – show Duplication introduced 2016-07-04 09:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		$validator->setConstraint(
122		$field,
123		Constraint_length::create('min', $validation['minLength'])
124		->setMessage(sprintf('Please enter at least %d characters.', $validation['minLength']))
125		);
126		}
127
128		// max length?
129	View Code Duplication	if (array_key_exists('maxLength', $validation)) {
		0 ignored issues – show Duplication introduced 2016-07-04 09:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
130		$validator->setConstraint(
131		$field,
132		Constraint_length::create('max', $validation['maxLength'])
133		->setMessage(sprintf('Please enter maximal %d characters.', $validation['maxLength']))
134		);
135		}
136
137		// width?
138	View Code Duplication	if (array_key_exists('width', $validation)) {
		0 ignored issues – show Duplication introduced 2016-07-04 09:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		$validator->setConstraint(
140		$field,
141		Constraint_dimension::create('width', $validation['width'])
142		->setMessage(sprintf(
143		'Please upload an image with an width of %s pixel.',
144		$validation['width']
145		)
146		)
147		);
148		}
149
150		// height?
151	View Code Duplication	if (array_key_exists('height', $validation)) {
		0 ignored issues – show Duplication introduced 2016-07-04 09:02 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		$validator->setConstraint(
153		$field,
154		Constraint_dimension::create('height', $validation['height'])
155		->setMessage(sprintf(
156		'Please upload an image with an height of %s pixel.',
157		$validation['height']
158		)
159		)
160		);
161		}
162		}
163		}
164
165		$this->extend('updateCMSValidator', $validator);
166
167		return $validator;
168		}
169		}
170
171		class GenericPage_Controller extends Page_Controller
172		{
173		}
174

FriendsOfSilverStripe / HandyPages

GenericPage::getCMSFields() B last analyzed 2020-08-21 20:11 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

GenericPage::getCMSFields() B
last analyzed 2020-08-21 20:11 UTC