FriendsOfPear /
Calendar
| Conditions | 13 |
| Paths | 30 |
| Total Lines | 39 |
| Code Lines | 34 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 82 | function create($type, $y = 2000, $m = 1, $d = 1, $h = 0, $i = 0, $s = 0) |
||
|
|
|||
| 83 | { |
||
| 84 | $firstDay = defined('CALENDAR_FIRST_DAY_OF_WEEK') ? CALENDAR_FIRST_DAY_OF_WEEK : 1; |
||
| 85 | switch ($type) { |
||
| 86 | case 'Day': |
||
| 87 | return new Day($y, $m, $d); |
||
| 88 | case 'Month': |
||
| 89 | // Set default state for which month type to build |
||
| 90 | if (!defined('CALENDAR_MONTH_STATE')) { |
||
| 91 | define('CALENDAR_MONTH_STATE', CALENDAR_USE_MONTH); |
||
| 92 | } |
||
| 93 | switch (CALENDAR_MONTH_STATE) { |
||
| 94 | case CALENDAR_USE_MONTH_WEEKDAYS: |
||
| 95 | $class = 'PEAR\Calendar\Month\Weekdays'; |
||
| 96 | break; |
||
| 97 | case CALENDAR_USE_MONTH_WEEKS: |
||
| 98 | $class = 'PEAR\Calendar\Month\Weeks'; |
||
| 99 | break; |
||
| 100 | case CALENDAR_USE_MONTH: |
||
| 101 | default: |
||
| 102 | $class = 'PEAR\Calendar\Month'; |
||
| 103 | break; |
||
| 104 | } |
||
| 105 | return new $class($y, $m, $firstDay); |
||
| 106 | case 'Week': |
||
| 107 | return new Week($y, $m, $d, $firstDay); |
||
| 108 | case 'Hour': |
||
| 109 | return new Hour($y, $m, $d, $h); |
||
| 110 | case 'Minute': |
||
| 111 | return new Minute($y, $m, $d, $h, $i); |
||
| 112 | case 'Second': |
||
| 113 | return new Second($y, $m, $d, $h, $i, $s); |
||
| 114 | case 'Year': |
||
| 115 | return new Year($y); |
||
| 116 | default: |
||
| 117 | include_once 'PEAR.php'; |
||
| 118 | PEAR::raiseError('Calendar_Factory::create() unrecognised type: '.$type, |
||
| 119 | null, PEAR_ERROR_TRIGGER, E_USER_NOTICE, 'Calendar_Factory::create()'); |
||
| 120 | return false; |
||
| 121 | } |
||
| 147 |
Loading history...
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.