Pickle\Package\PHP\Util\XML\Loader::load()

Complexity

Conditions	20
Paths	773

Size

Total Lines	100
Code Lines	58

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	45
CRAP Score	23.0302

Importance

Changes	5
Bugs	2	Features	0

<?php
    public function load($path, $versionOverride = null)
    {
        if (is_file($path) === false) {
            throw new InvalidArgumentException('File not found: ' . $path);
        }

        $xml = @simplexml_load_file($path);

        if ($xml === false) {
            $error = error_get_last();
            $exception = null;

            if ($error !== null) {
                $exception = new Exception($error['message'], $error['type']);
            }

            throw new RuntimeException('Failed to read ' . $path, 0, $exception);
        }

        $this->validate($xml);

        $package = [
            'name' => (string) $xml->name,
            'version' => (string) $versionOverride === '' ? (string) $xml->version->release : $versionOverride,
            'stability' => (string) $xml->stability->release,
            'description' => (string) $xml->summary,
        ];

        if (!isset($xml->providesextension)) {
            throw new Exception('not a PHP extension package.xml, providesextension tag missing');
        }

        $authors = [];
        foreach ([$xml->lead, $xml->developer, $xml->contributor, $xml->helper] as $devs) {
            foreach ($devs as $dev) {
                $authors[] = $dev;
            }
        }

        if (empty($authors) === false) {
            $package['authors'] = [];

            foreach ($authors as $author) {
                $tmp = [
                    'name' => trim((string) $author->name),
                    'email' => trim((string) $author->email),
                ];
                if ($tmp['name'] === '') {
                    unset($tmp['name']);
                }
                if ($tmp['email'] === '') {
                    unset($tmp['email']);
                }
                if ($tmp !== []) {
                    $package['authors'][] = $tmp;
                }
            }
        }

        $opts = $configureOptions = [];

        if (isset($xml->extsrcrelease->configureoption)) {
            $opts = $xml->extsrcrelease->configureoption;
        }

        foreach ($opts as $opt) {
            $name = trim($opt['name']);
            $default = trim($opt['default']);
            $prompt = trim($opt['prompt']);

            $configureOptions[$name] = [
                'default' => $default,
                'prompt' => $prompt,
            ];
        }

        if (empty($configureOptions) === false) {
            $package['extra'] = ['configure-options' => $configureOptions];
        }

        if (isset($xml->license)) {
            $package['license'] = (string) $xml->license;
        }
        $package['type'] = 'extension';

        $ret_pkg = $this->loader->load($package);
        if (!$ret_pkg) {

$ret_pkg is of type Composer\Package\PackageInterface, thus it always evaluated to true.

            throw new Exception("Package from '{$path}' failed to load.");
        }
        $ret_pkg->setRootDir(dirname($path));

The method setRootDir() does not exist on Composer\Package\PackageInterface. It seems like you code against a sub-type of Composer\Package\PackageInterface such as Pickle\Base\Interfaces\Package or Pickle\Package\PHP\Package or Pickle\Package\PHP\Package.

        if ($versionOverride !== '') {
            $src_ver = $versionOverride ?? (string) new Header\Version($ret_pkg);
            if ($src_ver !== $ret_pkg->getPrettyVersion()) {
                throw new Exception("Version mismatch - '" . $src_ver . "' != '" . $ret_pkg->getPrettyVersion() . "' in source vs. XML");
            }
        }
        $ret_pkg->setType('extension');

The method setType() does not exist on Composer\Package\PackageInterface. Did you maybe mean setDistType()?

        return $ret_pkg;
    }