Completed
Push — master ( 0e324f...947448 )
by Kamil
03:42
created

ResolveCrossContainerReferencesPassTest   A

Complexity

Total Complexity 8

Size/Duplication

Total Lines 139
Duplicated Lines 35.97 %

Coupling/Cohesion

Components 1
Dependencies 6

Importance

Changes 0
Metric Value
wmc 8
lcom 1
cbo 6
dl 50
loc 139
rs 10
c 0
b 0
f 0

7 Methods

Rating   Name   Duplication   Size   Complexity  
A it_resolves_cross_container_references_in_service_argument() 0 16 1
A it_resolves_cross_container_references_in_service_argument_array() 16 16 1
A it_resolves_cross_container_references_in_service_argument_nested_array() 16 16 1
A it_resolves_cross_container_references_in_service_argument_anonymous_definition() 18 18 1
A it_resolves_cross_container_parameters_inline_in_parameter() 0 13 1
A it_resolves_cross_container_parameters_in_service_definition_array() 0 15 1
A buildContainerWithDependencies() 0 14 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace tests\FriendsOfBehat\CrossContainer\Extension;
4
5
use FriendsOfBehat\CrossContainerExtension\ContainerBasedContainerAccessor;
6
use FriendsOfBehat\CrossContainerExtension\ResolveCrossContainerReferencesPass;
7
use Symfony\Component\DependencyInjection\ContainerBuilder;
8
use Symfony\Component\DependencyInjection\Definition;
9
use Symfony\Component\DependencyInjection\Reference;
10
11
final class ResolveCrossContainerReferencesPassTest extends \PHPUnit_Framework_TestCase
12
{
13
    /**
14
     * @test
15
     */
16
    public function it_resolves_cross_container_references_in_service_argument()
17
    {
18
        $externalContainer = new ContainerBuilder();
19
        $externalContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [['foo' => 'bar']]));
20
21
        $baseContainer = new ContainerBuilder();
22
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
23
            new Reference('__external__.array_object'),
24
        ]));
25
26
        $this->buildContainerWithDependencies($baseContainer, ['external' => $externalContainer]);
27
28
        static::assertTrue($baseContainer->has('array_object'));
29
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
30
        static::assertSame(['foo' => 'bar'], $baseContainer->get('array_object')->getArrayCopy());
31
    }
32
33
    /**
34
     * @test
35
     */
36 View Code Duplication
    public function it_resolves_cross_container_references_in_service_argument_array()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
37
    {
38
        $externalContainer = new ContainerBuilder();
39
        $externalContainer->setDefinition('std_class', new Definition(\stdClass::class));
40
41
        $baseContainer = new ContainerBuilder();
42
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
43
            ['std_class' => new Reference('__external__.std_class')],
44
        ]));
45
46
        $this->buildContainerWithDependencies($baseContainer, ['external' => $externalContainer]);
47
48
        static::assertTrue($baseContainer->has('array_object'));
49
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
50
        static::assertInstanceOf(\stdClass::class, $baseContainer->get('array_object')['std_class']);
51
    }
52
53
    /**
54
     * @test
55
     */
56 View Code Duplication
    public function it_resolves_cross_container_references_in_service_argument_nested_array()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
57
    {
58
        $externalContainer = new ContainerBuilder();
59
        $externalContainer->setDefinition('std_class', new Definition(\stdClass::class));
60
61
        $baseContainer = new ContainerBuilder();
62
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
63
            ['std' => ['class' => new Reference('__external__.std_class')]],
64
        ]));
65
66
        $this->buildContainerWithDependencies($baseContainer, ['external' => $externalContainer]);
67
68
        static::assertTrue($baseContainer->has('array_object'));
69
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
70
        static::assertInstanceOf(\stdClass::class, $baseContainer->get('array_object')['std']['class']);
71
    }
72
73
    /**
74
     * @test
75
     */
76 View Code Duplication
    public function it_resolves_cross_container_references_in_service_argument_anonymous_definition()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
77
    {
78
        $externalContainer = new ContainerBuilder();
79
        $externalContainer->setDefinition('std_class', new Definition(\stdClass::class));
80
81
        $baseContainer = new ContainerBuilder();
82
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
83
            new Definition(\ArrayObject::class, [
84
                ['std_class' => new Reference('__external__.std_class')],
85
            ]),
86
        ]));
87
88
        $this->buildContainerWithDependencies($baseContainer, ['external' => $externalContainer]);
89
90
        static::assertTrue($baseContainer->has('array_object'));
91
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
92
        static::assertInstanceOf(\stdClass::class, $baseContainer->get('array_object')->getArrayCopy()['std_class']);
93
    }
94
95
    /**
96
     * @test
97
     */
98
    public function it_resolves_cross_container_parameters_inline_in_parameter()
99
    {
100
        $externalContainer = new ContainerBuilder();
101
        $externalContainer->setParameter('parameter', '42');
102
103
        $baseContainer = new ContainerBuilder();
104
        $baseContainer->setParameter('parameter', '%__external__.parameter%');
105
106
        $this->buildContainerWithDependencies($baseContainer, ['external' => $externalContainer]);
107
108
        static::assertTrue($baseContainer->hasParameter('parameter'));
109
        static::assertSame('42', $baseContainer->getParameter('parameter'));
110
    }
111
112
    /**
113
     * @test
114
     */
115
    public function it_resolves_cross_container_parameters_in_service_definition_array()
116
    {
117
        $externalContainer = new ContainerBuilder();
118
        $externalContainer->setParameter('parameter', '42');
119
120
        $baseContainer = new ContainerBuilder();
121
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
122
            ['parameter' => '%__external__.parameter%'],
123
        ]));
124
125
        $this->buildContainerWithDependencies($baseContainer, ['external' => $externalContainer]);
126
127
        static::assertTrue($baseContainer->hasDefinition('array_object'));
128
        static::assertSame(['parameter' => '42'], $baseContainer->get('array_object')->getArrayCopy());
129
    }
130
131
    /**
132
     * @param ContainerBuilder $baseContainer
133
     * @param ContainerBuilder[] $externalContainers
134
     */
135
    private function buildContainerWithDependencies(ContainerBuilder $baseContainer, array $externalContainers)
136
    {
137
        $accessors = [];
138
        foreach ($externalContainers as $containerIdentifier => $container) {
139
            $container->compile();
140
141
            $accessors[$containerIdentifier] = new ContainerBasedContainerAccessor($container);
142
        }
143
144
        $crossContainerReferencesResolver = new ResolveCrossContainerReferencesPass($accessors);
145
        $crossContainerReferencesResolver->process($baseContainer);
146
147
        $baseContainer->compile();
148
    }
149
}
150