Completed
Push — master ( d7bbda...0e324f )
by Kamil
06:08
created

ResolveCrossContainerReferencesPassTest   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 150
Duplicated Lines 28 %

Coupling/Cohesion

Components 1
Dependencies 6

Importance

Changes 0
Metric Value
wmc 6
lcom 1
cbo 6
dl 42
loc 150
rs 10
c 0
b 0
f 0

6 Methods

Rating   Name   Duplication   Size   Complexity  
A it_resolves_cross_container_references_in_service_argument() 21 21 1
A it_resolves_cross_container_references_in_service_argument_array() 0 21 1
A it_resolves_cross_container_references_in_service_argument_nested_array() 21 21 1
A it_resolves_cross_container_references_in_service_argument_anonymous_definition() 0 23 1
A it_resolves_cross_container_parameters_inline_in_parameter() 0 18 1
A it_resolves_cross_container_parameters_in_service_definition_array() 0 20 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace tests\FriendsOfBehat\CrossContainer\Extension;
4
5
use FriendsOfBehat\CrossContainerExtension\ContainerBasedContainerAccessor;
6
use FriendsOfBehat\CrossContainerExtension\ResolveCrossContainerReferencesPass;
7
use Symfony\Component\DependencyInjection\ContainerBuilder;
8
use Symfony\Component\DependencyInjection\Definition;
9
use Symfony\Component\DependencyInjection\Reference;
10
11
final class ResolveCrossContainerReferencesPassTest extends \PHPUnit_Framework_TestCase
12
{
13
    /**
14
     * @test
15
     */
16 View Code Duplication
    public function it_resolves_cross_container_references_in_service_argument()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
17
    {
18
        $externalContainer = new ContainerBuilder();
19
        $externalContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [['foo' => 'bar']]));
20
        $externalContainer->compile();
21
22
        $baseContainer = new ContainerBuilder();
23
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
24
            new Reference('__external__.array_object'),
25
        ]));
26
27
        (new ResolveCrossContainerReferencesPass([
28
            'external' => new ContainerBasedContainerAccessor($externalContainer),
29
        ]))->process($baseContainer);
30
31
        $baseContainer->compile();
32
33
        static::assertTrue($baseContainer->has('array_object'));
34
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
35
        static::assertSame(['foo' => 'bar'], $baseContainer->get('array_object')->getArrayCopy());
36
    }
37
38
    /**
39
     * @test
40
     */
41
    public function it_resolves_cross_container_references_in_service_argument_array()
42
    {
43
        $externalContainer = new ContainerBuilder();
44
        $externalContainer->setDefinition('std_class', new Definition(\stdClass::class));
45
        $externalContainer->compile();
46
47
        $baseContainer = new ContainerBuilder();
48
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
49
            ['std_class' => new Reference('__external__.std_class')],
50
        ]));
51
52
        (new ResolveCrossContainerReferencesPass([
53
            'external' => new ContainerBasedContainerAccessor($externalContainer),
54
        ]))->process($baseContainer);
55
56
        $baseContainer->compile();
57
58
        static::assertTrue($baseContainer->has('array_object'));
59
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
60
        static::assertInstanceOf(\stdClass::class, $baseContainer->get('array_object')['std_class']);
61
    }
62
63
    /**
64
     * @test
65
     */
66 View Code Duplication
    public function it_resolves_cross_container_references_in_service_argument_nested_array()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
67
    {
68
        $externalContainer = new ContainerBuilder();
69
        $externalContainer->setDefinition('std_class', new Definition(\stdClass::class));
70
        $externalContainer->compile();
71
72
        $baseContainer = new ContainerBuilder();
73
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
74
            ['std' => ['class' => new Reference('__external__.std_class')]],
75
        ]));
76
77
        (new ResolveCrossContainerReferencesPass([
78
            'external' => new ContainerBasedContainerAccessor($externalContainer),
79
        ]))->process($baseContainer);
80
81
        $baseContainer->compile();
82
83
        static::assertTrue($baseContainer->has('array_object'));
84
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
85
        static::assertInstanceOf(\stdClass::class, $baseContainer->get('array_object')['std']['class']);
86
    }
87
88
    /**
89
     * @test
90
     */
91
    public function it_resolves_cross_container_references_in_service_argument_anonymous_definition()
92
    {
93
        $externalContainer = new ContainerBuilder();
94
        $externalContainer->setDefinition('std_class', new Definition(\stdClass::class));
95
        $externalContainer->compile();
96
97
        $baseContainer = new ContainerBuilder();
98
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
99
            new Definition(\ArrayObject::class, [
100
                ['std_class' => new Reference('__external__.std_class')],
101
            ]),
102
        ]));
103
104
        (new ResolveCrossContainerReferencesPass([
105
            'external' => new ContainerBasedContainerAccessor($externalContainer),
106
        ]))->process($baseContainer);
107
108
        $baseContainer->compile();
109
110
        static::assertTrue($baseContainer->has('array_object'));
111
        static::assertInstanceOf(\ArrayObject::class, $baseContainer->get('array_object'));
112
        static::assertInstanceOf(\stdClass::class, $baseContainer->get('array_object')->getArrayCopy()['std_class']);
113
    }
114
115
    /**
116
     * @test
117
     */
118
    public function it_resolves_cross_container_parameters_inline_in_parameter()
119
    {
120
        $externalContainer = new ContainerBuilder();
121
        $externalContainer->setParameter('parameter', '42');
122
        $externalContainer->compile();
123
124
        $baseContainer = new ContainerBuilder();
125
        $baseContainer->setParameter('parameter', '%__external__.parameter%');
126
127
        (new ResolveCrossContainerReferencesPass([
128
            'external' => new ContainerBasedContainerAccessor($externalContainer),
129
        ]))->process($baseContainer);
130
131
        $baseContainer->compile();
132
133
        static::assertTrue($baseContainer->hasParameter('parameter'));
134
        static::assertSame('42', $baseContainer->getParameter('parameter'));
135
    }
136
137
    /**
138
     * @test
139
     */
140
    public function it_resolves_cross_container_parameters_in_service_definition_array()
141
    {
142
        $externalContainer = new ContainerBuilder();
143
        $externalContainer->setParameter('parameter', '42');
144
        $externalContainer->compile();
145
146
        $baseContainer = new ContainerBuilder();
147
        $baseContainer->setDefinition('array_object', new Definition(\ArrayObject::class, [
148
            ['parameter' => '%__external__.parameter%'],
149
        ]));
150
151
        (new ResolveCrossContainerReferencesPass([
152
            'external' => new ContainerBasedContainerAccessor($externalContainer),
153
        ]))->process($baseContainer);
154
155
        $baseContainer->compile();
156
157
        static::assertTrue($baseContainer->hasDefinition('array_object'));
158
        static::assertSame(['parameter' => '42'], $baseContainer->get('array_object')->getArrayCopy());
159
    }
160
}
161