Issues in AuthenticationPlugin.php (master) - Issues in master - FriendsOfApi/sylius-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/AuthenticationPlugin.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace FAPI\Sylius\Http;

use Http\Client\Common\Plugin;
use Http\Promise\Promise;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * This will automatically refresh expired access token.
 *
 * @author Tobias Nyholm <[email protected]>
 */
class AuthenticationPlugin implements Plugin
{
    const RETRY_LIMIT = 2;

    /**
     * @var array
     */
    private $accessToken;

    /**
     * @var Authenticator
     */
    private $authenticator;

    /**
     * Store the retry counter for each request.
     *
     * @var array
     */
    private $retryStorage = [];

    public function __construct(Authenticator $authenticator, string $accessToken)
    {
        $this->authenticator = $authenticator;
        $this->accessToken = \json_decode($accessToken, true);
    }

    public function handleRequest(RequestInterface $request, callable $next, callable $first): Promise
    {
        if (null === $this->accessToken) {
            return $next($request);
        }

        $chainIdentifier = \spl_object_hash((object) $first);
        $header = \sprintf('Bearer %s', $this->accessToken['access_token'] ?? '');
        $request = $request->withHeader('Authorization', $header);

        $promise = $next($request);

        return $promise->then(function (ResponseInterface $response) use ($request, $next, $first, $chainIdentifier) {
            if (!\array_key_exists($chainIdentifier, $this->retryStorage)) {
                $this->retryStorage[$chainIdentifier] = 0;
            }

            if (401 !== $response->getStatusCode() || $this->retryStorage[$chainIdentifier] >= self::RETRY_LIMIT) {
                unset($this->retryStorage[$chainIdentifier]);

                return $response;
            }

            $accessToken = $this->authenticator->refreshAccessToken($this->accessToken['access_token'], $this->accessToken['refresh_token']);
            if (null === $accessToken) {
                return $response;
            }

            // Save new token
            $this->accessToken = \json_decode($accessToken, true);

            // Add new token to request
            $header = \sprintf('Bearer %s', $this->accessToken['access_token']);
            $request = $request->withHeader('Authorization', $header);
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)

            // Retry
            ++$this->retryStorage[$chainIdentifier];
            $promise = $this->handleRequest($request, $next, $first);

            return $promise->wait();
        });

        return $response;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function getAccessToken(): string
    {
        return \json_encode($this->accessToken);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace FAPI\Sylius\Http;
6
7			use Http\Client\Common\Plugin;
8			use Http\Promise\Promise;
9			use Psr\Http\Message\RequestInterface;
10			use Psr\Http\Message\ResponseInterface;
11
12			/**
13			* This will automatically refresh expired access token.
14			*
15			* @author Tobias Nyholm <[email protected]>
16			*/
17			class AuthenticationPlugin implements Plugin
18			{
19			const RETRY_LIMIT = 2;
20
21			/**
22			* @var array
23			*/
24			private $accessToken;
25
26			/**
27			* @var Authenticator
28			*/
29			private $authenticator;
30
31			/**
32			* Store the retry counter for each request.
33			*
34			* @var array
35			*/
36			private $retryStorage = [];
37
38			public function __construct(Authenticator $authenticator, string $accessToken)
39			{
40			$this->authenticator = $authenticator;
41			$this->accessToken = \json_decode($accessToken, true);
42			}
43
44			public function handleRequest(RequestInterface $request, callable $next, callable $first): Promise
45			{
46			if (null === $this->accessToken) {
47			return $next($request);
48			}
49
50			$chainIdentifier = \spl_object_hash((object) $first);
51			$header = \sprintf('Bearer %s', $this->accessToken['access_token'] ?? '');
52			$request = $request->withHeader('Authorization', $header);
53
54			$promise = $next($request);
55
56			return $promise->then(function (ResponseInterface $response) use ($request, $next, $first, $chainIdentifier) {
57			if (!\array_key_exists($chainIdentifier, $this->retryStorage)) {
58			$this->retryStorage[$chainIdentifier] = 0;
59			}
60
61			if (401 !== $response->getStatusCode() \|\| $this->retryStorage[$chainIdentifier] >= self::RETRY_LIMIT) {
62			unset($this->retryStorage[$chainIdentifier]);
63
64			return $response;
65			}
66
67			$accessToken = $this->authenticator->refreshAccessToken($this->accessToken['access_token'], $this->accessToken['refresh_token']);
68			if (null === $accessToken) {
69			return $response;
70			}
71
72			// Save new token
73			$this->accessToken = \json_decode($accessToken, true);
74
75			// Add new token to request
76			$header = \sprintf('Bearer %s', $this->accessToken['access_token']);
77			$request = $request->withHeader('Authorization', $header);
			0 ignored issues – show Bug introduced 2018-11-14 14:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different name than the imported variable `$request`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
78
79			// Retry
80			++$this->retryStorage[$chainIdentifier];
81			$promise = $this->handleRequest($request, $next, $first);
82
83			return $promise->wait();
84			});
85
86			return $response;
			0 ignored issues – show Unused Code introduced 2018-11-14 14:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `return $response;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
87			}
88
89			public function getAccessToken(): string
90			{
91			return \json_encode($this->accessToken);
92			}
93			}
94

FriendsOfApi / sylius-api-client

Issues (37)

Security Analysis no request data

src/Http/AuthenticationPlugin.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like