AuthenticationPlugin::__construct() - Code Metrics - Inspection of "Automatically refresh access token" - FriendsOfApi/sylius-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Tobias

created 2018-11-14 14:44 UTC

AuthenticationPlugin::__construct() A

↳ Parent: AuthenticationPlugin

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

declare(strict_types=1);

namespace FAPI\Sylius\Http;

use Http\Client\Common\Plugin;
use Http\Promise\Promise;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * This will automatically refresh expired access token.
 *
 * @author Tobias Nyholm <[email protected]>
 */
class AuthenticationPlugin implements Plugin
{
    /**
     * @var array
     */
    private $accessToken;

    /**
     * @var Authenticator
     */
    private $authenticator;

    public function __construct(Authenticator $authenticator, string $accessToken)
    {
        $this->authenticator = $authenticator;
        $this->accessToken = json_decode($accessToken, true);
    }

    public function handleRequest(RequestInterface $request, callable $next, callable $first)
    {
        $header = sprintf('Bearer %s', $this->accessToken['access_token']);
        $request =  $request->withHeader('Authorization', $header);

        $promise = $next($request);
        return $promise->then(function (ResponseInterface $response) use ($request, $next, $first) {
            if ($response->getStatusCode() !== 401) {
                return $response;
            }

            $accessToken = $this->authenticator->refreshAccessToken($this->accessToken['access_token'], $this->accessToken['refresh_token']);
            if (null === $accessToken) {
                return $response;
            }

            // Save new token
            $this->accessToken = json_decode($accessToken, true);

            // Add new token to request
            $header = sprintf('Bearer %s', $this->accessToken['access_token']);
            $request =  $request->withHeader('Authorization', $header);
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)

            // Retry
            $promise = $this->handleRequest($request, $next, $first);

            return $promise->wait();
        });

        return $response;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    public function getAccessToken(): string
    {
        return json_encode($this->accessToken);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace FAPI\Sylius\Http;
6
7			use Http\Client\Common\Plugin;
8			use Http\Promise\Promise;
9			use Psr\Http\Message\RequestInterface;
10			use Psr\Http\Message\ResponseInterface;
11
12			/**
13			* This will automatically refresh expired access token.
14			*
15			* @author Tobias Nyholm <[email protected]>
16			*/
17			class AuthenticationPlugin implements Plugin
18			{
19			/**
20			* @var array
21			*/
22			private $accessToken;
23
24			/**
25			* @var Authenticator
26			*/
27			private $authenticator;
28
29			public function __construct(Authenticator $authenticator, string $accessToken)
30			{
31			$this->authenticator = $authenticator;
32			$this->accessToken = json_decode($accessToken, true);
33			}
34
35			public function handleRequest(RequestInterface $request, callable $next, callable $first)
36			{
37			$header = sprintf('Bearer %s', $this->accessToken['access_token']);
38			$request = $request->withHeader('Authorization', $header);
39
40			$promise = $next($request);
41			return $promise->then(function (ResponseInterface $response) use ($request, $next, $first) {
42			if ($response->getStatusCode() !== 401) {
43			return $response;
44			}
45
46			$accessToken = $this->authenticator->refreshAccessToken($this->accessToken['access_token'], $this->accessToken['refresh_token']);
47			if (null === $accessToken) {
48			return $response;
49			}
50
51			// Save new token
52			$this->accessToken = json_decode($accessToken, true);
53
54			// Add new token to request
55			$header = sprintf('Bearer %s', $this->accessToken['access_token']);
56			$request = $request->withHeader('Authorization', $header);
			0 ignored issues – show Bug introduced 2018-11-14 14:51 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$request`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
57
58			// Retry
59			$promise = $this->handleRequest($request, $next, $first);
60
61			return $promise->wait();
62			});
63
64			return $response;
			0 ignored issues – show Unused Code introduced 2018-11-14 14:51 UTC by Report Bug Copy Issue Report `return $response;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
65			}
66
67			public function getAccessToken(): string
68			{
69			return json_encode($this->accessToken);
70			}
71			}
72

FriendsOfApi / sylius-api-client

Pull Request — master (#10)

AuthenticationPlugin::__construct() A

Complexity

Size

Duplication

Importance

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like