HttpApi::__construct() - Code Metrics - Inspection of "Bugfix (#23)" - FriendsOfApi/sylius-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 853263...f6940b )

by Tobias

created 2018-11-22 08:36 UTC

HttpApi::__construct() A

↳ Parent: HttpApi

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	0
cts	8
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	3
crap	6

<?php

declare(strict_types=1);

/*
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace FAPI\Sylius\Api;

use FAPI\Sylius\Exception\Domain as DomainExceptions;
use FAPI\Sylius\Exception\DomainException;
use FAPI\Sylius\Hydrator\Hydrator;
use FAPI\Sylius\Hydrator\NoopHydrator;
use FAPI\Sylius\RequestBuilder;
use Http\Client\HttpClient;
use Psr\Http\Message\ResponseInterface;

/**
 * @author Tobias Nyholm <[email protected]>
 */
abstract class HttpApi
{
    /**
     * @var HttpClient
     */
    protected $httpClient;

    /**
     * @var Hydrator
     */
    protected $hydrator;

    /**
     * @var RequestBuilder
     */
    protected $requestBuilder;

    public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
    {
        $this->httpClient = $httpClient;
        $this->requestBuilder = $requestBuilder;
        if (!$hydrator instanceof NoopHydrator) {
            $this->hydrator = $hydrator;
        }
    }

    /**
     * Send a GET request with query parameters.
     *
     * @param string $path           Request path
     * @param array  $params         GET parameters
     * @param array  $requestHeaders Request Headers
     */
    protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        if (\count($params) > 0) {
            $path .= '?'.\http_build_query($params);
        }

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('GET', $path, $requestHeaders)
        );
    }

    /**
     * Send a POST request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpPostRaw($path, $this->createJsonBody($params), $requestHeaders);
    }

    /**
     * Send a POST request with raw data.
     *
     * @param string       $path           Request path
     * @param array|string $body           Request body
     * @param array        $requestHeaders Request headers
     */
    protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
    {
        return $response = $this->httpClient->sendRequest(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $this->requestBuilder->create('POST', $path, $requestHeaders, $body)
        );
    }

    /**
     * Send a PUT request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('PUT', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Send a PATCH request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpPatch(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('PATCH', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Send a DELETE request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('DELETE', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Handle HTTP errors.
     *
     * Call is controlled by the specific API methods.
     *
     * @throws DomainException
     */
    protected function handleErrors(ResponseInterface $response)
    {
        switch ($response->getStatusCode()) {
            case 401:
                throw new DomainExceptions\UnauthorizedException();
            case 404:
                throw new DomainExceptions\NotFoundException();
            default:
                throw new DomainExceptions\UnknownErrorException();
        }
    }

    /**
     * Create a JSON encoded version of an array of parameters.
     *
     * @param array $params Request parameters
     *
     * @return null|string
     */
    private function createJsonBody(array $params)
    {
        return (0 === \count($params)) ? null : \json_encode($params, empty($params) ? \JSON_FORCE_OBJECT : 0);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This software may be modified and distributed under the terms
7			* of the MIT license. See the LICENSE file for details.
8			*/
9
10			namespace FAPI\Sylius\Api;
11
12			use FAPI\Sylius\Exception\Domain as DomainExceptions;
13			use FAPI\Sylius\Exception\DomainException;
14			use FAPI\Sylius\Hydrator\Hydrator;
15			use FAPI\Sylius\Hydrator\NoopHydrator;
16			use FAPI\Sylius\RequestBuilder;
17			use Http\Client\HttpClient;
18			use Psr\Http\Message\ResponseInterface;
19
20			/**
21			* @author Tobias Nyholm <[email protected]>
22			*/
23			abstract class HttpApi
24			{
25			/**
26			* @var HttpClient
27			*/
28			protected $httpClient;
29
30			/**
31			* @var Hydrator
32			*/
33			protected $hydrator;
34
35			/**
36			* @var RequestBuilder
37			*/
38			protected $requestBuilder;
39
40			public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
41			{
42			$this->httpClient = $httpClient;
43			$this->requestBuilder = $requestBuilder;
44			if (!$hydrator instanceof NoopHydrator) {
45			$this->hydrator = $hydrator;
46			}
47			}
48
49			/**
50			* Send a GET request with query parameters.
51			*
52			* @param string $path Request path
53			* @param array $params GET parameters
54			* @param array $requestHeaders Request Headers
55			*/
56			protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
57			{
58			if (\count($params) > 0) {
59			$path .= '?'.\http_build_query($params);
60			}
61
62			return $this->httpClient->sendRequest(
63			$this->requestBuilder->create('GET', $path, $requestHeaders)
64			);
65			}
66
67			/**
68			* Send a POST request with JSON-encoded parameters.
69			*
70			* @param string $path Request path
71			* @param array $params POST parameters to be JSON encoded
72			* @param array $requestHeaders Request headers
73			*/
74			protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
75			{
76			return $this->httpPostRaw($path, $this->createJsonBody($params), $requestHeaders);
77			}
78
79			/**
80			* Send a POST request with raw data.
81			*
82			* @param string $path Request path
83			* @param array\|string $body Request body
84			* @param array $requestHeaders Request headers
85			*/
86			protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
87			{
88			return $response = $this->httpClient->sendRequest(
			0 ignored issues – show Unused Code introduced 2018-10-08 13:20 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
89			$this->requestBuilder->create('POST', $path, $requestHeaders, $body)
90			);
91			}
92
93			/**
94			* Send a PUT request with JSON-encoded parameters.
95			*
96			* @param string $path Request path
97			* @param array $params POST parameters to be JSON encoded
98			* @param array $requestHeaders Request headers
99			*/
100			protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
101			{
102			return $this->httpClient->sendRequest(
103			$this->requestBuilder->create('PUT', $path, $requestHeaders, $this->createJsonBody($params))
104			);
105			}
106
107			/**
108			* Send a PATCH request with JSON-encoded parameters.
109			*
110			* @param string $path Request path
111			* @param array $params POST parameters to be JSON encoded
112			* @param array $requestHeaders Request headers
113			*/
114			protected function httpPatch(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
115			{
116			return $this->httpClient->sendRequest(
117			$this->requestBuilder->create('PATCH', $path, $requestHeaders, $this->createJsonBody($params))
118			);
119			}
120
121			/**
122			* Send a DELETE request with JSON-encoded parameters.
123			*
124			* @param string $path Request path
125			* @param array $params POST parameters to be JSON encoded
126			* @param array $requestHeaders Request headers
127			*/
128			protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
129			{
130			return $this->httpClient->sendRequest(
131			$this->requestBuilder->create('DELETE', $path, $requestHeaders, $this->createJsonBody($params))
132			);
133			}
134
135			/**
136			* Handle HTTP errors.
137			*
138			* Call is controlled by the specific API methods.
139			*
140			* @throws DomainException
141			*/
142			protected function handleErrors(ResponseInterface $response)
143			{
144			switch ($response->getStatusCode()) {
145			case 401:
146			throw new DomainExceptions\UnauthorizedException();
147			case 404:
148			throw new DomainExceptions\NotFoundException();
149			default:
150			throw new DomainExceptions\UnknownErrorException();
151			}
152			}
153
154			/**
155			* Create a JSON encoded version of an array of parameters.
156			*
157			* @param array $params Request parameters
158			*
159			* @return null\|string
160			*/
161			private function createJsonBody(array $params)
162			{
163			return (0 === \count($params)) ? null : \json_encode($params, empty($params) ? \JSON_FORCE_OBJECT : 0);
164			}
165			}
166

FriendsOfApi / sylius-api-client

Push — master ( 853263...f6940b )

HttpApi::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like