HttpApi::httpPatch() - Code Metrics - Inspection of "Merge pull request #16 from damienalexandre/patchA..." - FriendsOfApi/localise.biz - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d0b1f...3a7434 )

by Tobias

created 2017-05-31 08:30 UTC

HttpApi::httpPatch() A

↳ Parent: HttpApi

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	8
loc	8
ccs	0
cts	7
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	3
crap	2

<?php

declare(strict_types=1);

/*
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace FAPI\Localise\Api;

use FAPI\Localise\Exception\Domain as DomainExceptions;
use FAPI\Localise\Exception\DomainException;
use FAPI\Localise\Hydrator\NoopHydrator;
use Http\Client\HttpClient;
use FAPI\Localise\Hydrator\Hydrator;
use FAPI\Localise\RequestBuilder;
use Psr\Http\Message\ResponseInterface;

/**
 * @author Tobias Nyholm <[email protected]>
 */
abstract class HttpApi
{
    /**
     * @var HttpClient
     */
    protected $httpClient;

    /**
     * @var Hydrator
     */
    protected $hydrator;

    /**
     * @var RequestBuilder
     */
    protected $requestBuilder;

    /**
     * @param HttpClient     $httpClient
     * @param RequestBuilder $requestBuilder
     * @param Hydrator       $hydrator
     */
    public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
    {
        $this->httpClient = $httpClient;
        $this->requestBuilder = $requestBuilder;
        if (!$hydrator instanceof NoopHydrator) {
            $this->hydrator = $hydrator;
        }
    }

    /**
     * Send a GET request with query parameters.
     *
     * @param string $path           Request path
     * @param array  $params         GET parameters
     * @param array  $requestHeaders Request Headers
     *
     * @return ResponseInterface
     */
    protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface

    {
        if (count($params) > 0) {
            $path .= '?'.http_build_query($params);
        }

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('GET', $path, $requestHeaders)
        );
    }

    /**
     * Send a POST request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        $requestHeaders['Content-Type'] = 'application/x-www-form-urlencoded';

        return $this->httpPostRaw($path, http_build_query($params), $requestHeaders);
    }

    /**
     * Send a POST request with raw data.
     *
     * @param string       $path           Request path
     * @param array|string $body           Request body
     * @param array        $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
    {
        return $response = $this->httpClient->sendRequest(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $this->requestBuilder->create('POST', $path, $requestHeaders, $body)
        );
    }

    /**
     * Send a PUT request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface

    {
        $requestHeaders['Content-Type'] = 'application/x-www-form-urlencoded';

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('PUT', $path, $requestHeaders, http_build_query($params))
        );
    }

    /**
     * Send a PATCH request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         PATCH parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPatch(string $path, array $params = [], array $requestHeaders = []): ResponseInterface

    {
        $requestHeaders['Content-Type'] = 'application/json';

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('PATCH', $path, $requestHeaders, json_encode($params))
        );
    }

    /**
     * Send a DELETE request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface

    {
        $requestHeaders['Content-Type'] = 'application/x-www-form-urlencoded';

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('DELETE', $path, $requestHeaders, http_build_query($params))
        );
    }

    /**
     * Handle HTTP errors.
     *
     * Call is controlled by the specific API methods.
     *
     * @param ResponseInterface $response
     *
     * @throws DomainException
     */
    protected function handleErrors(ResponseInterface $response)
    {
        $body = $response->getBody()->__toString();

        $content = json_decode($body, true);
        $message = '';
        if (JSON_ERROR_NONE === json_last_error()) {
            $message = $content['error'];
        }

        switch ($response->getStatusCode()) {
            case 401:
                throw new DomainExceptions\InvalidApiKeyException($message);
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 403:
                throw new DomainExceptions\InsufficientPrivilegesException($message);
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 404:
                throw new DomainExceptions\NotFoundException($message);
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

            default:
                throw new DomainExceptions\UnknownErrorException($message);
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This software may be modified and distributed under the terms
7		* of the MIT license. See the LICENSE file for details.
8		*/
9
10		namespace FAPI\Localise\Api;
11
12		use FAPI\Localise\Exception\Domain as DomainExceptions;
13		use FAPI\Localise\Exception\DomainException;
14		use FAPI\Localise\Hydrator\NoopHydrator;
15		use Http\Client\HttpClient;
16		use FAPI\Localise\Hydrator\Hydrator;
17		use FAPI\Localise\RequestBuilder;
18		use Psr\Http\Message\ResponseInterface;
19
20		/**
21		* @author Tobias Nyholm <[email protected]>
22		*/
23		abstract class HttpApi
24		{
25		/**
26		* @var HttpClient
27		*/
28		protected $httpClient;
29
30		/**
31		* @var Hydrator
32		*/
33		protected $hydrator;
34
35		/**
36		* @var RequestBuilder
37		*/
38		protected $requestBuilder;
39
40		/**
41		* @param HttpClient $httpClient
42		* @param RequestBuilder $requestBuilder
43		* @param Hydrator $hydrator
44		*/
45		public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
46		{
47		$this->httpClient = $httpClient;
48		$this->requestBuilder = $requestBuilder;
49		if (!$hydrator instanceof NoopHydrator) {
50		$this->hydrator = $hydrator;
51		}
52		}
53
54		/**
55		* Send a GET request with query parameters.
56		*
57		* @param string $path Request path
58		* @param array $params GET parameters
59		* @param array $requestHeaders Request Headers
60		*
61		* @return ResponseInterface
62		*/
63	View Code Duplication	protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
		0 ignored issues – show Duplication introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		if (count($params) > 0) {
66		$path .= '?'.http_build_query($params);
67		}
68
69		return $this->httpClient->sendRequest(
70		$this->requestBuilder->create('GET', $path, $requestHeaders)
71		);
72		}
73
74		/**
75		* Send a POST request with JSON-encoded parameters.
76		*
77		* @param string $path Request path
78		* @param array $params POST parameters to be JSON encoded
79		* @param array $requestHeaders Request headers
80		*
81		* @return ResponseInterface
82		*/
83		protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
84		{
85		$requestHeaders['Content-Type'] = 'application/x-www-form-urlencoded';
86
87		return $this->httpPostRaw($path, http_build_query($params), $requestHeaders);
88		}
89
90		/**
91		* Send a POST request with raw data.
92		*
93		* @param string $path Request path
94		* @param array\|string $body Request body
95		* @param array $requestHeaders Request headers
96		*
97		* @return ResponseInterface
98		*/
99		protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
100		{
101		return $response = $this->httpClient->sendRequest(
		0 ignored issues – show Unused Code introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
102		$this->requestBuilder->create('POST', $path, $requestHeaders, $body)
103		);
104		}
105
106		/**
107		* Send a PUT request with JSON-encoded parameters.
108		*
109		* @param string $path Request path
110		* @param array $params POST parameters to be JSON encoded
111		* @param array $requestHeaders Request headers
112		*
113		* @return ResponseInterface
114		*/
115	View Code Duplication	protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
		0 ignored issues – show Duplication introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		$requestHeaders['Content-Type'] = 'application/x-www-form-urlencoded';
118
119		return $this->httpClient->sendRequest(
120		$this->requestBuilder->create('PUT', $path, $requestHeaders, http_build_query($params))
121		);
122		}
123
124		/**
125		* Send a PATCH request with JSON-encoded parameters.
126		*
127		* @param string $path Request path
128		* @param array $params PATCH parameters to be JSON encoded
129		* @param array $requestHeaders Request headers
130		*
131		* @return ResponseInterface
132		*/
133	View Code Duplication	protected function httpPatch(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
		0 ignored issues – show Duplication introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
134		{
135		$requestHeaders['Content-Type'] = 'application/json';
136
137		return $this->httpClient->sendRequest(
138		$this->requestBuilder->create('PATCH', $path, $requestHeaders, json_encode($params))
139		);
140		}
141
142		/**
143		* Send a DELETE request with JSON-encoded parameters.
144		*
145		* @param string $path Request path
146		* @param array $params POST parameters to be JSON encoded
147		* @param array $requestHeaders Request headers
148		*
149		* @return ResponseInterface
150		*/
151	View Code Duplication	protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
		0 ignored issues – show Duplication introduced 2017-05-31 08:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		{
153		$requestHeaders['Content-Type'] = 'application/x-www-form-urlencoded';
154
155		return $this->httpClient->sendRequest(
156		$this->requestBuilder->create('DELETE', $path, $requestHeaders, http_build_query($params))
157		);
158		}
159
160		/**
161		* Handle HTTP errors.
162		*
163		* Call is controlled by the specific API methods.
164		*
165		* @param ResponseInterface $response
166		*
167		* @throws DomainException
168		*/
169		protected function handleErrors(ResponseInterface $response)
170		{
171		$body = $response->getBody()->__toString();
172
173		$content = json_decode($body, true);
174		$message = '';
175		if (JSON_ERROR_NONE === json_last_error()) {
176		$message = $content['error'];
177		}
178
179		switch ($response->getStatusCode()) {
180		case 401:
181		throw new DomainExceptions\InvalidApiKeyException($message);
182		break;
		0 ignored issues – show Unused Code introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
183		case 403:
184		throw new DomainExceptions\InsufficientPrivilegesException($message);
185		break;
		0 ignored issues – show Unused Code introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
186		case 404:
187		throw new DomainExceptions\NotFoundException($message);
188		break;
		0 ignored issues – show Unused Code introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
189
190		default:
191		throw new DomainExceptions\UnknownErrorException($message);
192		break;
		0 ignored issues – show Unused Code introduced 2017-01-01 14:50 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
193		}
194		}
195		}
196

FriendsOfApi / localise.biz

Push — master ( 9d0b1f...3a7434 )

HttpApi::httpPatch() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like