HttpApi - Code Metrics - FriendsOfApi/fortnox - Measure and Improve Code Quality continuously with Scrutinizer

HttpApi A
last analyzed 2020-09-04 15:47 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	143
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	9
dl	0
loc	143
ccs	0
cts	64
cp	0
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	httpGet()	10	2
A	httpPost()	4	1
A	httpPostRaw()	6	1
A	httpPut()	6	1
A	httpDelete()	6	1
A	handleErrors()	25	5
A	createJsonBody()	4	3

<?php

declare(strict_types=1);

/*
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace FAPI\Fortnox\Api;

use FAPI\Fortnox\Exception\Domain as DomainExceptions;
use FAPI\Fortnox\Exception\DomainException;
use FAPI\Fortnox\Hydrator\Hydrator;
use FAPI\Fortnox\Hydrator\NoopHydrator;
use FAPI\Fortnox\RequestBuilder;
use Http\Client\HttpClient;
use Psr\Http\Message\ResponseInterface;

/**
 * @author Tobias Nyholm <[email protected]>
 */
abstract class HttpApi
{
    /**
     * @var HttpClient
     */
    protected $httpClient;

    /**
     * @var Hydrator
     */
    protected $hydrator;

    /**
     * @var RequestBuilder
     */
    protected $requestBuilder;

    public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
    {
        $this->httpClient = $httpClient;
        $this->requestBuilder = $requestBuilder;
        if (!$hydrator instanceof NoopHydrator) {
            $this->hydrator = $hydrator;
        }
    }

    /**
     * Send a GET request with query parameters.
     *
     * @param string $path           Request path
     * @param array  $params         GET parameters
     * @param array  $requestHeaders Request Headers
     */
    protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        if (\count($params) > 0) {
            $path .= '?'.\http_build_query($params);
        }

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('GET', $path, $requestHeaders)
        );
    }

    /**
     * Send a POST request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpPostRaw($path, $this->createJsonBody($params), $requestHeaders);
    }

    /**
     * Send a POST request with raw data.
     *
     * @param string       $path           Request path
     * @param array|string $body           Request body
     * @param array        $requestHeaders Request headers
     */
    protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
    {
        return $response = $this->httpClient->sendRequest(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $this->requestBuilder->create('POST', $path, $requestHeaders, $body)
        );
    }

    /**
     * Send a PUT request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('PUT', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Send a DELETE request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     */
    protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('DELETE', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Handle HTTP errors.
     *
     * Call is controlled by the specific API methods.
     *
     * @throws DomainException
     */
    protected function handleErrors(ResponseInterface $response)
    {
        $body = $response->getBody()->__toString();
        switch ($response->getStatusCode()) {
            case 400:
                throw new DomainExceptions\BadRequestException($body);
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

            case 403:
                throw new DomainExceptions\ForbiddenException();
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

            case 404:
                throw new DomainExceptions\NotFoundException();
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

            case 500:
                throw new DomainExceptions\ServerErrorException();
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

            default:
                throw new DomainExceptions\UnknownErrorException();
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
    }

    /**
     * Create a JSON encoded version of an array of parameters.
     *
     * @param array $params Request parameters
     *
     * @return string|null
     */
    private function createJsonBody(array $params)
    {
        return (0 === \count($params)) ? null : \json_encode($params, empty($params) ? \JSON_FORCE_OBJECT : 0);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This software may be modified and distributed under the terms
7			* of the MIT license. See the LICENSE file for details.
8			*/
9
10			namespace FAPI\Fortnox\Api;
11
12			use FAPI\Fortnox\Exception\Domain as DomainExceptions;
13			use FAPI\Fortnox\Exception\DomainException;
14			use FAPI\Fortnox\Hydrator\Hydrator;
15			use FAPI\Fortnox\Hydrator\NoopHydrator;
16			use FAPI\Fortnox\RequestBuilder;
17			use Http\Client\HttpClient;
18			use Psr\Http\Message\ResponseInterface;
19
20			/**
21			* @author Tobias Nyholm <[email protected]>
22			*/
23			abstract class HttpApi
24			{
25			/**
26			* @var HttpClient
27			*/
28			protected $httpClient;
29
30			/**
31			* @var Hydrator
32			*/
33			protected $hydrator;
34
35			/**
36			* @var RequestBuilder
37			*/
38			protected $requestBuilder;
39
40			public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
41			{
42			$this->httpClient = $httpClient;
43			$this->requestBuilder = $requestBuilder;
44			if (!$hydrator instanceof NoopHydrator) {
45			$this->hydrator = $hydrator;
46			}
47			}
48
49			/**
50			* Send a GET request with query parameters.
51			*
52			* @param string $path Request path
53			* @param array $params GET parameters
54			* @param array $requestHeaders Request Headers
55			*/
56			protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
57			{
58			if (\count($params) > 0) {
59			$path .= '?'.\http_build_query($params);
60			}
61
62			return $this->httpClient->sendRequest(
63			$this->requestBuilder->create('GET', $path, $requestHeaders)
64			);
65			}
66
67			/**
68			* Send a POST request with JSON-encoded parameters.
69			*
70			* @param string $path Request path
71			* @param array $params POST parameters to be JSON encoded
72			* @param array $requestHeaders Request headers
73			*/
74			protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
75			{
76			return $this->httpPostRaw($path, $this->createJsonBody($params), $requestHeaders);
77			}
78
79			/**
80			* Send a POST request with raw data.
81			*
82			* @param string $path Request path
83			* @param array\|string $body Request body
84			* @param array $requestHeaders Request headers
85			*/
86			protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
87			{
88			return $response = $this->httpClient->sendRequest(
			0 ignored issues – show Unused Code introduced 2018-11-20 14:13 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
89			$this->requestBuilder->create('POST', $path, $requestHeaders, $body)
90			);
91			}
92
93			/**
94			* Send a PUT request with JSON-encoded parameters.
95			*
96			* @param string $path Request path
97			* @param array $params POST parameters to be JSON encoded
98			* @param array $requestHeaders Request headers
99			*/
100			protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
101			{
102			return $this->httpClient->sendRequest(
103			$this->requestBuilder->create('PUT', $path, $requestHeaders, $this->createJsonBody($params))
104			);
105			}
106
107			/**
108			* Send a DELETE request with JSON-encoded parameters.
109			*
110			* @param string $path Request path
111			* @param array $params POST parameters to be JSON encoded
112			* @param array $requestHeaders Request headers
113			*/
114			protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
115			{
116			return $this->httpClient->sendRequest(
117			$this->requestBuilder->create('DELETE', $path, $requestHeaders, $this->createJsonBody($params))
118			);
119			}
120
121			/**
122			* Handle HTTP errors.
123			*
124			* Call is controlled by the specific API methods.
125			*
126			* @throws DomainException
127			*/
128			protected function handleErrors(ResponseInterface $response)
129			{
130			$body = $response->getBody()->__toString();
131			switch ($response->getStatusCode()) {
132			case 400:
133			throw new DomainExceptions\BadRequestException($body);
134			break;
			0 ignored issues – show Unused Code introduced 2018-11-20 14:13 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
135
136			case 403:
137			throw new DomainExceptions\ForbiddenException();
138			break;
			0 ignored issues – show Unused Code introduced 2018-11-20 14:13 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
139
140			case 404:
141			throw new DomainExceptions\NotFoundException();
142			break;
			0 ignored issues – show Unused Code introduced 2018-11-20 14:13 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
143
144			case 500:
145			throw new DomainExceptions\ServerErrorException();
146			break;
			0 ignored issues – show Unused Code introduced 2018-11-20 14:13 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
147
148			default:
149			throw new DomainExceptions\UnknownErrorException();
150			break;
			0 ignored issues – show Unused Code introduced 2018-11-20 14:13 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
151			}
152			}
153
154			/**
155			* Create a JSON encoded version of an array of parameters.
156			*
157			* @param array $params Request parameters
158			*
159			* @return string\|null
160			*/
161			private function createJsonBody(array $params)
162			{
163			return (0 === \count($params)) ? null : \json_encode($params, empty($params) ? \JSON_FORCE_OBJECT : 0);
164			}
165			}
166

FriendsOfApi / fortnox

HttpApi A last analyzed 2020-09-04 15:47 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

8 Methods

Duplication Side-by-Side

Filter issues like

HttpApi A
last analyzed 2020-09-04 15:47 UTC