1 | <?php |
||
23 | abstract class HttpApi |
||
24 | { |
||
25 | /** |
||
26 | * @var HttpClient |
||
27 | */ |
||
28 | protected $httpClient; |
||
29 | |||
30 | /** |
||
31 | * @var Hydrator |
||
32 | */ |
||
33 | protected $hydrator; |
||
34 | |||
35 | /** |
||
36 | * @var RequestBuilder |
||
37 | */ |
||
38 | protected $requestBuilder; |
||
39 | |||
40 | /** |
||
41 | * @param HttpClient $httpClient |
||
42 | * @param RequestBuilder $requestBuilder |
||
43 | * @param Hydrator $hydrator |
||
44 | */ |
||
45 | public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder) |
||
53 | |||
54 | /** |
||
55 | * Send a GET request with query parameters. |
||
56 | * |
||
57 | * @param string $path Request path |
||
58 | * @param array $params GET parameters |
||
59 | * @param array $requestHeaders Request Headers |
||
60 | * |
||
61 | * @return ResponseInterface |
||
62 | */ |
||
63 | protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface |
||
73 | |||
74 | /** |
||
75 | * Send a POST request with JSON-encoded parameters. |
||
76 | * |
||
77 | * @param string $path Request path |
||
78 | * @param array $params POST parameters to be JSON encoded |
||
79 | * @param array $requestHeaders Request headers |
||
80 | * |
||
81 | * @return ResponseInterface |
||
82 | */ |
||
83 | protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface |
||
87 | |||
88 | /** |
||
89 | * Send a POST request with raw data. |
||
90 | * |
||
91 | * @param string $path Request path |
||
92 | * @param array|string $body Request body |
||
93 | * @param array $requestHeaders Request headers |
||
94 | * |
||
95 | * @return ResponseInterface |
||
96 | */ |
||
97 | protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface |
||
103 | |||
104 | /** |
||
105 | * Send a PUT request with JSON-encoded parameters. |
||
106 | * |
||
107 | * @param string $path Request path |
||
108 | * @param array $params POST parameters to be JSON encoded |
||
109 | * @param array $requestHeaders Request headers |
||
110 | * |
||
111 | * @return ResponseInterface |
||
112 | */ |
||
113 | protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface |
||
119 | |||
120 | /** |
||
121 | * Send a DELETE request with JSON-encoded parameters. |
||
122 | * |
||
123 | * @param string $path Request path |
||
124 | * @param array $params POST parameters to be JSON encoded |
||
125 | * @param array $requestHeaders Request headers |
||
126 | * |
||
127 | * @return ResponseInterface |
||
128 | */ |
||
129 | protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface |
||
135 | |||
136 | /** |
||
137 | * Create a JSON encoded version of an array of parameters. |
||
138 | * |
||
139 | * @param array $params Request parameters |
||
140 | * |
||
141 | * @return null|string |
||
142 | */ |
||
143 | private function createJsonBody(array $params) |
||
147 | |||
148 | /** |
||
149 | * Handle HTTP errors. |
||
150 | * |
||
151 | * Call is controlled by the specific API methods. |
||
152 | * |
||
153 | * @param ResponseInterface $response |
||
154 | * |
||
155 | * @throws DomainException |
||
156 | */ |
||
157 | protected function handleErrors(ResponseInterface $response) |
||
169 | } |
||
170 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.