Issues in HttpApi.php (master) - Issues in master - FriendsOfApi/billogram - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Api/HttpApi.php (4 issues)

Labels

Unused Code 4

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);
/*
 * This software may be modified and distributed under the terms
 * of the MIT license. See the LICENSE file for details.
 */

namespace Billogram\Api;

use Billogram\Exception\Domain as DomainException;
use Billogram\Hydrator\NoopHydrator;
use Http\Client\HttpClient;
use Billogram\Hydrator\Hydrator;
use Billogram\RequestBuilder;
use Psr\Http\Message\ResponseInterface;

/**
 * @author Tobias Nyholm <[email protected]>
 */
abstract class HttpApi
{
    /**
     * @var HttpClient
     */
    protected $httpClient;

    /**
     * @var Hydrator
     */
    protected $hydrator;

    /**
     * @var RequestBuilder
     */
    protected $requestBuilder;

    /**
     * @param HttpClient     $httpClient
     * @param RequestBuilder $requestBuilder
     * @param Hydrator       $hydrator
     */
    public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
    {
        $this->httpClient = $httpClient;
        $this->requestBuilder = $requestBuilder;
        if (!$hydrator instanceof NoopHydrator) {
            $this->hydrator = $hydrator;
        }
    }

    /**
     * Send a GET request with query parameters.
     *
     * @param string $path           Request path
     * @param array  $params         GET parameters
     * @param array  $requestHeaders Request Headers
     *
     * @return ResponseInterface
     */
    protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        if (count($params) > 0) {
            $path .= '?'.http_build_query($params);
        }

        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('GET', $path, $requestHeaders)
        );
    }

    /**
     * Send a POST request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpPostRaw($path, $this->createJsonBody($params), $requestHeaders);
    }

    /**
     * Send a POST request with raw data.
     *
     * @param string       $path           Request path
     * @param array|string $body           Request body
     * @param array        $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
    {
        return $response = $this->httpClient->sendRequest(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $this->requestBuilder->create('POST', $path, $requestHeaders, $body)
        );
    }

    /**
     * Send a PUT request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('PUT', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Send a DELETE request with JSON-encoded parameters.
     *
     * @param string $path           Request path
     * @param array  $params         POST parameters to be JSON encoded
     * @param array  $requestHeaders Request headers
     *
     * @return ResponseInterface
     */
    protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
    {
        return $this->httpClient->sendRequest(
            $this->requestBuilder->create('DELETE', $path, $requestHeaders, $this->createJsonBody($params))
        );
    }

    /**
     * Create a JSON encoded version of an array of parameters.
     *
     * @param array $params Request parameters
     *
     * @return null|string
     */
    private function createJsonBody(array $params)
    {
        return (0 === count($params)) ? null : json_encode($params, empty($params) ? JSON_FORCE_OBJECT : 0);
    }

    /**
     * Handle HTTP errors.
     *
     * Call is controlled by the specific API methods.
     *
     * @param ResponseInterface $response
     *
     * @throws \Billogram\Exception\DomainException
     */
    protected function handleErrors(ResponseInterface $response)
    {
        switch ($response->getStatusCode()) {
            case 404:
                throw new DomainException\NotFoundException($response->getBody()->__toString());
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 400:
                throw new DomainException\ValidationException($response->getBody()->__toString());
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            default:
                throw new DomainException\UnknownErrorException($response->getBody()->__toString());
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
    }

    /**
     * @param ResponseInterface $response
     * @param string            $class    to hydrate
     *
     * @return mixed
     *
     * @throws \Billogram\Exception
     */
    protected function handleResponse(ResponseInterface $response, $class)
    {
        if (!$this->hydrator) {
            return $response;
        }

        if (200 !== $response->getStatusCode()) {
            $this->handleErrors($response);
        }

        return $this->hydrator->hydrate($response, $class);
    }
}


1		<?php
2
3		declare(strict_types=1);
4		/*
5		* This software may be modified and distributed under the terms
6		* of the MIT license. See the LICENSE file for details.
7		*/
8
9		namespace Billogram\Api;
10
11		use Billogram\Exception\Domain as DomainException;
12		use Billogram\Hydrator\NoopHydrator;
13		use Http\Client\HttpClient;
14		use Billogram\Hydrator\Hydrator;
15		use Billogram\RequestBuilder;
16		use Psr\Http\Message\ResponseInterface;
17
18		/**
19		* @author Tobias Nyholm <[email protected]>
20		*/
21		abstract class HttpApi
22		{
23		/**
24		* @var HttpClient
25		*/
26		protected $httpClient;
27
28		/**
29		* @var Hydrator
30		*/
31		protected $hydrator;
32
33		/**
34		* @var RequestBuilder
35		*/
36		protected $requestBuilder;
37
38		/**
39		* @param HttpClient $httpClient
40		* @param RequestBuilder $requestBuilder
41		* @param Hydrator $hydrator
42		*/
43	19	public function __construct(HttpClient $httpClient, Hydrator $hydrator, RequestBuilder $requestBuilder)
44		{
45	19	$this->httpClient = $httpClient;
46	19	$this->requestBuilder = $requestBuilder;
47	19	if (!$hydrator instanceof NoopHydrator) {
48	19	$this->hydrator = $hydrator;
49		}
50	19	}
51
52		/**
53		* Send a GET request with query parameters.
54		*
55		* @param string $path Request path
56		* @param array $params GET parameters
57		* @param array $requestHeaders Request Headers
58		*
59		* @return ResponseInterface
60		*/
61	11	protected function httpGet(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
62		{
63	11	if (count($params) > 0) {
64	4	$path .= '?'.http_build_query($params);
65		}
66
67	11	return $this->httpClient->sendRequest(
68	11	$this->requestBuilder->create('GET', $path, $requestHeaders)
69		);
70		}
71
72		/**
73		* Send a POST request with JSON-encoded parameters.
74		*
75		* @param string $path Request path
76		* @param array $params POST parameters to be JSON encoded
77		* @param array $requestHeaders Request headers
78		*
79		* @return ResponseInterface
80		*/
81	4	protected function httpPost(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
82		{
83	4	return $this->httpPostRaw($path, $this->createJsonBody($params), $requestHeaders);
84		}
85
86		/**
87		* Send a POST request with raw data.
88		*
89		* @param string $path Request path
90		* @param array\|string $body Request body
91		* @param array $requestHeaders Request headers
92		*
93		* @return ResponseInterface
94		*/
95	4	protected function httpPostRaw(string $path, $body, array $requestHeaders = []): ResponseInterface
96		{
97	4	return $response = $this->httpClient->sendRequest(
		0 ignored issues – show Unused Code introduced 2017-08-01 13:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98	4	$this->requestBuilder->create('POST', $path, $requestHeaders, $body)
99		);
100		}
101
102		/**
103		* Send a PUT request with JSON-encoded parameters.
104		*
105		* @param string $path Request path
106		* @param array $params POST parameters to be JSON encoded
107		* @param array $requestHeaders Request headers
108		*
109		* @return ResponseInterface
110		*/
111	4	protected function httpPut(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
112		{
113	4	return $this->httpClient->sendRequest(
114	4	$this->requestBuilder->create('PUT', $path, $requestHeaders, $this->createJsonBody($params))
115		);
116		}
117
118		/**
119		* Send a DELETE request with JSON-encoded parameters.
120		*
121		* @param string $path Request path
122		* @param array $params POST parameters to be JSON encoded
123		* @param array $requestHeaders Request headers
124		*
125		* @return ResponseInterface
126		*/
127	1	protected function httpDelete(string $path, array $params = [], array $requestHeaders = []): ResponseInterface
128		{
129	1	return $this->httpClient->sendRequest(
130	1	$this->requestBuilder->create('DELETE', $path, $requestHeaders, $this->createJsonBody($params))
131		);
132		}
133
134		/**
135		* Create a JSON encoded version of an array of parameters.
136		*
137		* @param array $params Request parameters
138		*
139		* @return null\|string
140		*/
141	9	private function createJsonBody(array $params)
142		{
143	9	return (0 === count($params)) ? null : json_encode($params, empty($params) ? JSON_FORCE_OBJECT : 0);
144		}
145
146		/**
147		* Handle HTTP errors.
148		*
149		* Call is controlled by the specific API methods.
150		*
151		* @param ResponseInterface $response
152		*
153		* @throws \Billogram\Exception\DomainException
154		*/
155		protected function handleErrors(ResponseInterface $response)
156		{
157		switch ($response->getStatusCode()) {
158		case 404:
159		throw new DomainException\NotFoundException($response->getBody()->__toString());
160		break;
		0 ignored issues – show Unused Code introduced 2017-08-01 13:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
161		case 400:
162		throw new DomainException\ValidationException($response->getBody()->__toString());
163		break;
		0 ignored issues – show Unused Code introduced 2017-08-01 13:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
164		default:
165		throw new DomainException\UnknownErrorException($response->getBody()->__toString());
166		break;
		0 ignored issues – show Unused Code introduced 2017-08-01 13:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
167		}
168		}
169
170		/**
171		* @param ResponseInterface $response
172		* @param string $class to hydrate
173		*
174		* @return mixed
175		*
176		* @throws \Billogram\Exception
177		*/
178	19	protected function handleResponse(ResponseInterface $response, $class)
179		{
180	19	if (!$this->hydrator) {
181		return $response;
182		}
183
184	19	if (200 !== $response->getStatusCode()) {
185		$this->handleErrors($response);
186		}
187
188	19	return $this->hydrator->hydrate($response, $class);
189		}
190		}
191

FriendsOfApi / billogram

Issues (33)

Security Analysis no request data

src/Api/HttpApi.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like