Billogram\Model\Setting\PaymentSetting

Complexity

Total Complexity

19

Size/Duplication

Total Lines	154
Duplicated Lines	5.84 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

51.02%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getBankgiro()	0	4	1
A	withBankgiro()	0	7	1
A	getPlusgiro()	0	4	1
A	withPlusgiro()	0	7	1
A	getDomesticBankAccount()	0	4	1
A	withDomesticBankAccount()	0	7	1
A	getInternationalBankAccount()	0	4	1
A	withInternationalBankAccount()	0	7	1
A	createFromArray()	0	10	1
D	toArray()	9	29	10

<?php

declare(strict_types=1);

namespace Billogram\Model\Setting;

use Billogram\Model\CreatableFromArray;

/**
 * @author Ibrahim Hizeoui <ibrahimhizeoui@gmail.com>
 */
class PaymentSetting implements CreatableFromArray
{
    /**
     * @var string
     */
    private $bankgiro;

    /**
     * @var string
     */
    private $plusgiro;

    /**
     * @var array
     */
    private $domesticBankAccount;

    /**
     * @var array
     */
    private $internationalBankAccount;

    /**
     * @return mixed
     */
    public function getBankgiro()
    {
        return $this->bankgiro;
    }

    /**
     * @param $bankgiro
     *
     * @return PaymentSetting
     */
    public function withBankgiro($bankgiro)
    {
        $new = clone $this;
        $new->bankgiro = $bankgiro;

        return $new;
    }

    /**
     * @return string
     */
    public function getPlusgiro(): string
    {
        return $this->plusgiro;
    }

    /**
     * @param string $plusgiro
     *
     * @return PaymentSetting
     */
    public function withPlusgiro(string $plusgiro)
    {
        $new = clone $this;
        $new->plusgiro = $plusgiro;

        return $new;
    }

    /**
     * @return mixed
     */
    public function getDomesticBankAccount()
    {
        return $this->domesticBankAccount;
    }

    /**
     * @param $domesticBankAccount
     *
     * @return PaymentSetting
     */
    public function withDomesticBankAccount($domesticBankAccount)
    {
        $new = clone $this;
        $new->domesticBankAccount = $domesticBankAccount;

        return $new;
    }

    /**
     * @return mixed
     */
    public function getInternationalBankAccount()
    {
        return $this->internationalBankAccount;
    }

    /**
     * @param $internationalBankAccount
     *
     * @return PaymentSetting
     */
    public function withInternationalBankAccount($internationalBankAccount)
    {
        $new = clone $this;
        $new->internationalBankAccount = $internationalBankAccount;

        return $new;
    }

    /**
     * Create an API response object from the HTTP response from the API server.
     *
     * @param array $data
     *
     * @return self
     */
    public static function createFromArray(array $data)
    {
        $paymentSetting = new self();
        $paymentSetting->bankgiro = $data['bankgiro'] ?? null;
        $paymentSetting->plusgiro = $data['plusgiro'] ?? null;
        $paymentSetting->domesticBankAccount = ['account_no' => $data['domestic_bank_account']['account_no'], 'clearing_no' => $data['domestic_bank_account']['clearing_no']] ?? null;

It seems like array('account_no' => $data['domestic_bank_account']['account_no'], 'clearing_no' => $data['domestic_bank_account']['clearing_no']) ?? null can be null. However, the property $domesticBankAccount is declared as array. Maybe change the type of the property to array|null or add a type check?

        $paymentSetting->internationalBankAccount = ['bank' => $data['international_bank_account']['bank'], 'iban' => $data['international_bank_account']['iban'], 'bic' => $data['international_bank_account']['bic'], 'swift' => $data['international_bank_account']['swift']] ?? null;

It seems like array('bank' => $data['international_bank_account']['bank'], 'iban' => $data['international_bank_account']['iban'], 'bic' => $data['international_bank_account']['bic'], 'swift' => $data['international_bank_account']['swift']) ?? null can be null. However, the property $internationalBankAccount is declared as array. Maybe change the type of the property to array|null or add a type check?

        return $paymentSetting;
    }

    public function toArray()
    {
        $data = [];
        if ($this->bankgiro !== null) {
            $data['bankgiro'] = $this->bankgiro;
        }
        if ($this->plusgiro !== null) {
            $data['plusgiro'] = $this->plusgiro;
        }
        if ($this->domesticBankAccount['account_no'] !== null && $this->domesticBankAccount['clearing_no'] !== null) {
            $data['domestic_bank_account']['account_no'] = $this->domesticBankAccount['account_no'];
            $data['domestic_bank_account']['clearing_no'] = $this->domesticBankAccount['clearing_no'];
        }
        if ($this->internationalBankAccount['iban'] !== null) {
            $data['international_bank_account']['iban'] = $this->internationalBankAccount['iban'];

            if ($this->internationalBankAccount['iban'] !== null && $this->internationalBankAccount['bank'] !== null) {

This code seems to be duplicated across your project.

                $data['international_bank_account']['bank'] = $this->internationalBankAccount['bank'];
            }
            if ($this->internationalBankAccount['bic'] !== null) {

This code seems to be duplicated across your project.

                $data['international_bank_account']['bic'] = $this->internationalBankAccount['bic'];
            }
            if ($this->internationalBankAccount['swift'] !== null) {

This code seems to be duplicated across your project.

                $data['international_bank_account']['swift'] = $this->internationalBankAccount['swift'];
            }
        }

        return $data;
    }
}