Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | View Code Duplication | class AutomaticReminderCollection implements CreatableFromArray |
|
|
|||
13 | { |
||
14 | /** |
||
15 | * var int. |
||
16 | */ |
||
17 | private $delayDays; |
||
18 | |||
19 | /** |
||
20 | * var string. |
||
21 | */ |
||
22 | private $message; |
||
23 | |||
24 | /** |
||
25 | * @return int |
||
26 | */ |
||
27 | public function getDelayDays() |
||
31 | |||
32 | /** |
||
33 | * @param $delayDays |
||
34 | * |
||
35 | * @return AutomaticReminderCollection |
||
36 | */ |
||
37 | public function withDelayDays($delayDays) |
||
44 | |||
45 | /** |
||
46 | * @return string |
||
47 | */ |
||
48 | public function getMessage() |
||
52 | |||
53 | /** |
||
54 | * @param $message |
||
55 | * |
||
56 | * @return AutomaticReminderCollection |
||
57 | */ |
||
58 | public function withMessage($message) |
||
65 | |||
66 | 1 | public function toArray() |
|
78 | |||
79 | /** |
||
80 | * Create an API response object from the HTTP response from the API server. |
||
81 | * |
||
82 | * @param array $data |
||
83 | * |
||
84 | * @return self |
||
85 | */ |
||
86 | 2 | public static function createFromArray(array $data) |
|
94 | } |
||
95 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.