CustomerDeliveryAddress - Code Metrics - Inspection of "Item rebase (#23)" - FriendsOfApi/billogram - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4bb787...bf6574 )

by Tobias

created 2017-08-11 12:11 UTC

CustomerDeliveryAddress A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	207
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	21
lcom	1
cbo	0
dl	207
loc	207
ccs	0
cts	97
cp	0
rs	10
c	0
b	0
f	0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	3	3	1
A	getName()	4	4	1
A	withName()	7	7	1
A	getStreetAddress()	4	4	1
A	withStreetAddress()	7	7	1
A	getCareOf()	4	4	1
A	withCareOf()	7	7	1
A	getZipCode()	4	4	1
A	withZipCode()	7	7	1
A	getCity()	4	4	1
A	withCity()	7	7	1
A	getCountry()	4	4	1
A	withCountry()	7	7	1
C	toArray()	24	24	7
A	createFromArray()	12	12	1

How to fix Duplicated Code

<?php

namespace Billogram\Model\Customer;

use Billogram\Model\CreatableFromArray;

/**
 * @author Ibrahim Hizeoui <[email protected]>
 */
class CustomerDeliveryAddress implements CreatableFromArray

{
    /**
     * @var string
     */
    private $name;

    /**
     * @var string
     */
    private $streetAddress;

    /**
     * @var string
     */
    private $careOf;

    /**
     * @var string
     */
    private $zipCode;

    /**
     * @var string
     */
    private $city;

    /**
     * @var string
     */
    private $country;

    public function __construct()
    {
    }

    /**
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @param string $name
     *
     * @return CustomerDeliveryAddress
     */
    public function withName(string $name)
    {
        $new = clone $this;
        $new->name = $name;

        return $new;
    }

    /**
     * @return string
     */
    public function getStreetAddress()
    {
        return $this->streetAddress;
    }

    /**
     * @param string $streetAddress
     *
     * @return CustomerDeliveryAddress
     */
    public function withStreetAddress(string $streetAddress)
    {
        $new = clone $this;
        $new->streetAddress = $streetAddress;

        return $new;
    }

    /**
     * @return string
     */
    public function getCareOf()
    {
        return $this->careOf;
    }

    /**
     * @param string $careOf
     *
     * @return CustomerDeliveryAddress
     */
    public function withCareOf(string $careOf)
    {
        $new = clone $this;
        $new->zipCode = $careOf;

        return $new;
    }

    /**
     * @return string
     */
    public function getZipCode()
    {
        return $this->zipCode;
    }

    /**
     * @param string $zipCode
     *
     * @return CustomerDeliveryAddress
     */
    public function withZipCode(string $zipCode)
    {
        $new = clone $this;
        $new->zipCode = $zipCode;

        return $new;
    }

    /**
     * @return string
     */
    public function getCity()
    {
        return $this->city;
    }

    /**
     * @param string $city
     *
     * @return CustomerDeliveryAddress
     */
    public function withCity(string $city)
    {
        $new = clone $this;
        $new->city = $city;

        return $new;
    }

    /**
     * @return string
     */
    public function getCountry()
    {
        return $this->country;
    }

    /**
     * @param string $country
     *
     * @return CustomerDeliveryAddress
     */
    public function withCountry(string $country)
    {
        $new = clone $this;
        $new->country = $country;

        return $new;
    }

    public function toArray()
    {
        $data = [];
        if ($this->name !== null) {
            $data['name'] = $this->name;
        }
        if ($this->streetAddress !== null) {
            $data['street_address'] = $this->streetAddress;
        }
        if ($this->careOf !== null) {
            $data['careof'] = $this->careOf;
        }
        if ($this->zipCode !== null) {
            $data['zipcode'] = $this->zipCode;
        }
        if ($this->city !== null) {
            $data['city'] = $this->city;
        }
        if ($this->country !== null) {
            $data['country'] = $this->country;
        }

        return $data;
    }

    /**
     * Create an API response object from the HTTP response from the API server.
     *
     * @param array $data
     *
     * @return self
     */
    public static function createFromArray(array $data)
    {
        $customerDeliveryAddress = new self();
        $customerDeliveryAddress->name = $data['name'];
        $customerDeliveryAddress->streetAddress = $data['street_address'];
        $customerDeliveryAddress->careOf = $data['careof'];
        $customerDeliveryAddress->zipCode = $data['zipcode'];
        $customerDeliveryAddress->city = $data['city'];
        $customerDeliveryAddress->country = $data['country'];

        return $customerDeliveryAddress;
    }
}


1		<?php
2
3		namespace Billogram\Model\Customer;
4
5		use Billogram\Model\CreatableFromArray;
6
7		/**
8		* @author Ibrahim Hizeoui <[email protected]>
9		*/
10	View Code Duplication	class CustomerDeliveryAddress implements CreatableFromArray
		0 ignored issues – show Duplication introduced 2017-08-01 13:14 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* @var string
14		*/
15		private $name;
16
17		/**
18		* @var string
19		*/
20		private $streetAddress;
21
22		/**
23		* @var string
24		*/
25		private $careOf;
26
27		/**
28		* @var string
29		*/
30		private $zipCode;
31
32		/**
33		* @var string
34		*/
35		private $city;
36
37		/**
38		* @var string
39		*/
40		private $country;
41
42		public function __construct()
43		{
44		}
45
46		/**
47		* @return string
48		*/
49		public function getName()
50		{
51		return $this->name;
52		}
53
54		/**
55		* @param string $name
56		*
57		* @return CustomerDeliveryAddress
58		*/
59		public function withName(string $name)
60		{
61		$new = clone $this;
62		$new->name = $name;
63
64		return $new;
65		}
66
67		/**
68		* @return string
69		*/
70		public function getStreetAddress()
71		{
72		return $this->streetAddress;
73		}
74
75		/**
76		* @param string $streetAddress
77		*
78		* @return CustomerDeliveryAddress
79		*/
80		public function withStreetAddress(string $streetAddress)
81		{
82		$new = clone $this;
83		$new->streetAddress = $streetAddress;
84
85		return $new;
86		}
87
88		/**
89		* @return string
90		*/
91		public function getCareOf()
92		{
93		return $this->careOf;
94		}
95
96		/**
97		* @param string $careOf
98		*
99		* @return CustomerDeliveryAddress
100		*/
101		public function withCareOf(string $careOf)
102		{
103		$new = clone $this;
104		$new->zipCode = $careOf;
105
106		return $new;
107		}
108
109		/**
110		* @return string
111		*/
112		public function getZipCode()
113		{
114		return $this->zipCode;
115		}
116
117		/**
118		* @param string $zipCode
119		*
120		* @return CustomerDeliveryAddress
121		*/
122		public function withZipCode(string $zipCode)
123		{
124		$new = clone $this;
125		$new->zipCode = $zipCode;
126
127		return $new;
128		}
129
130		/**
131		* @return string
132		*/
133		public function getCity()
134		{
135		return $this->city;
136		}
137
138		/**
139		* @param string $city
140		*
141		* @return CustomerDeliveryAddress
142		*/
143		public function withCity(string $city)
144		{
145		$new = clone $this;
146		$new->city = $city;
147
148		return $new;
149		}
150
151		/**
152		* @return string
153		*/
154		public function getCountry()
155		{
156		return $this->country;
157		}
158
159		/**
160		* @param string $country
161		*
162		* @return CustomerDeliveryAddress
163		*/
164		public function withCountry(string $country)
165		{
166		$new = clone $this;
167		$new->country = $country;
168
169		return $new;
170		}
171
172		public function toArray()
173		{
174		$data = [];
175		if ($this->name !== null) {
176		$data['name'] = $this->name;
177		}
178		if ($this->streetAddress !== null) {
179		$data['street_address'] = $this->streetAddress;
180		}
181		if ($this->careOf !== null) {
182		$data['careof'] = $this->careOf;
183		}
184		if ($this->zipCode !== null) {
185		$data['zipcode'] = $this->zipCode;
186		}
187		if ($this->city !== null) {
188		$data['city'] = $this->city;
189		}
190		if ($this->country !== null) {
191		$data['country'] = $this->country;
192		}
193
194		return $data;
195		}
196
197		/**
198		* Create an API response object from the HTTP response from the API server.
199		*
200		* @param array $data
201		*
202		* @return self
203		*/
204		public static function createFromArray(array $data)
205		{
206		$customerDeliveryAddress = new self();
207		$customerDeliveryAddress->name = $data['name'];
208		$customerDeliveryAddress->streetAddress = $data['street_address'];
209		$customerDeliveryAddress->careOf = $data['careof'];
210		$customerDeliveryAddress->zipCode = $data['zipcode'];
211		$customerDeliveryAddress->city = $data['city'];
212		$customerDeliveryAddress->country = $data['country'];
213
214		return $customerDeliveryAddress;
215		}
216		}
217

FriendsOfApi / billogram

Push — master ( 4bb787...bf6574 )

CustomerDeliveryAddress A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like