CliCommandPathValidator::validate() - Code Metrics - Inspection of "Cron validation rebased" - FriendsOfAkeneo/FOACronBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#14)

by jean-marie

created 2017-02-23 00:15 UTC

CliCommandPathValidator::validate() A

↳ Parent: CliCommandPathValidator

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666
cc	2
eloc	6
nc	2
nop	2

<?php

namespace FOA\CronBundle\Validator\Constraints;

use Symfony\Component\Validator\Constraint;
use Symfony\Component\Validator\ConstraintValidator;

class CliCommandPathValidator extends ConstraintValidator
{
    /**
     * @var string
     */
    private $kernelDir;

    /**
     * @param $kernelDir
     */
    public function __construct($kernelDir)
    {
        $this->kernelDir = $kernelDir;
    }

    public function validate($value, Constraint $constraint)
    {
        $pattern = sprintf('#^php \s+ %s/console \s+#x', preg_quote($this->kernelDir));
        if (!preg_match($pattern, $value, $matches)) {
            $this->context->buildViolation($constraint->message)
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setParameter('%string%', $value)
                ->addViolation();
        }
    }
}


1			<?php
2
3			namespace FOA\CronBundle\Validator\Constraints;
4
5			use Symfony\Component\Validator\Constraint;
6			use Symfony\Component\Validator\ConstraintValidator;
7
8			class CliCommandPathValidator extends ConstraintValidator
9			{
10			/**
11			* @var string
12			*/
13			private $kernelDir;
14
15			/**
16			* @param $kernelDir
17			*/
18			public function __construct($kernelDir)
19			{
20			$this->kernelDir = $kernelDir;
21			}
22
23			public function validate($value, Constraint $constraint)
24			{
25			$pattern = sprintf('#^php \s+ %s/console \s+#x', preg_quote($this->kernelDir));
26			if (!preg_match($pattern, $value, $matches)) {
27			$this->context->buildViolation($constraint->message)
			0 ignored issues – show Bug introduced 2017-02-23 00:11 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Valida...ecutionContextInterface` as the method `buildViolation()` does only exist in the following implementations of said interface: `Symfony\Component\Valida...ontext\ExecutionContext`, `Symfony\Component\Valida...\LegacyExecutionContext`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
28			->setParameter('%string%', $value)
29			->addViolation();
30			}
31			}
32			}
33

FriendsOfAkeneo / FOACronBundle

Pull Request — develop (#14)

CliCommandPathValidator::validate() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like