LogController::addFlash() - Code Metrics - FriendsOfAkeneo/FOACronBundle - Measure and Improve Code Quality continuously with Scrutinizer

LogController::addFlash() A
last analyzed 2017-03-26 15:07 UTC

↳ Parent: LogController

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666
cc	2
eloc	5
nc	2
nop	2

<?php

namespace FOA\CronBundle\Controller;

use Symfony\Component\HttpFoundation\Response;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;

/**
 * Display and manage log files
 * @author Novikov Viktor
 */
class LogController extends Controller
{
    /**
     * Gets a log file
     *
     * @param $id   - the line of the cron in the cron table
     * @param $type - the type of file, log or error
     *
     * @return Response
     */
    public function fileAction($id, $type)
    {
        $cronManager = $this->get('foa.cron_bundle.cron_manager');
        $cron = $cronManager->getById($id);
        $filepath = ($type == 'log') ? $cron->getLogFile() : $cron->getErrorFile();
        // TODO: re-activate when secure
        // $content = file_get_contents($filepath);

        $content = 'File content not displayable.';

        return $this->render('FOACronBundle:Dashboard:log.html.twig', [
            'filepath' => $filepath,
            'content'  => $content,
        ]);
    }

    /**
     * Adds a flash to the flash bag where flashes are array of messages
     *
     * @param $type
     * @param $message
     */
    protected function addFlash($type, $message)
    {
        if (empty($message)) {
            return;
        }

        $session = $this->get('session');
        $session->getFlashBag()->add($type, $message);
    }
}


1			<?php
2
3			namespace FOA\CronBundle\Controller;
4
5			use Symfony\Component\HttpFoundation\Response;
6			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7
8			/**
9			* Display and manage log files
10			* @author Novikov Viktor
11			*/
12			class LogController extends Controller
13			{
14			/**
15			* Gets a log file
16			*
17			* @param $id - the line of the cron in the cron table
18			* @param $type - the type of file, log or error
19			*
20			* @return Response
21			*/
22			public function fileAction($id, $type)
23			{
24			$cronManager = $this->get('foa.cron_bundle.cron_manager');
25			$cron = $cronManager->getById($id);
26			$filepath = ($type == 'log') ? $cron->getLogFile() : $cron->getErrorFile();
27			// TODO: re-activate when secure
28			// $content = file_get_contents($filepath);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-10 21:42 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
29			$content = 'File content not displayable.';
30
31			return $this->render('FOACronBundle:Dashboard:log.html.twig', [
32			'filepath' => $filepath,
33			'content' => $content,
34			]);
35			}
36
37			/**
38			* Adds a flash to the flash bag where flashes are array of messages
39			*
40			* @param $type
41			* @param $message
42			*/
43			protected function addFlash($type, $message)
44			{
45			if (empty($message)) {
46			return;
47			}
48
49			$session = $this->get('session');
50			$session->getFlashBag()->add($type, $message);
51			}
52			}
53

FriendsOfAkeneo / FOACronBundle

LogController::addFlash() A last analyzed 2017-03-26 15:07 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

LogController::addFlash() A
last analyzed 2017-03-26 15:07 UTC