CronDayOfMonthFormatValidatorTest   A
last analyzed

Complexity

Total Complexity 5

Size/Duplication

Total Lines 75
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 5

Importance

Changes 2
Bugs 0 Features 0
Metric Value
wmc 5
lcom 1
cbo 5
dl 75
loc 75
c 2
b 0
f 0
rs 10

5 Methods

Rating   Name   Duplication   Size   Complexity  
A createValidator() 4 4 1
A testValidValue() 6 6 1
A testInvalidValues() 8 8 1
A getValidValues() 14 14 1
A getInvalidValues() 17 17 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Tests\FOA\CronBundle\Validator\Constraints;
4
5
use FOA\CronBundle\Validator\Constraints\CronDayOfMonthFormat;
6
use FOA\CronBundle\Validator\Constraints\CronDayOfMonthFormatValidator;
7
use Symfony\Component\Validator\Tests\Constraints\AbstractConstraintValidatorTest;
8
9
/**
10
 * @author JM Leroux <[email protected]>
11
 */
12 View Code Duplication
class CronDayOfMonthFormatValidatorTest extends AbstractConstraintValidatorTest
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
13
{
14
    /**
15
     * {@inheritdoc}
16
     */
17
    protected function createValidator()
18
    {
19
        return new CronDayOfMonthFormatValidator();
20
    }
21
22
    /**
23
     * @return array
24
     */
25
    public function getValidValues()
26
    {
27
        return [
28
            [1],
29
            [31],
30
            ['2,15'],
31
            ['4-15'],
32
            ['1-9,15-25'],
33
            ['5,15-30'],
34
            ['*/10'],
35
            ['*'],
36
            ['*,7,*/10'],
37
        ];
38
    }
39
40
    /**
41
     * @dataProvider getValidValues
42
     *
43
     * @param string $value
44
     */
45
    public function testValidValue($value)
46
    {
47
        $constraint = new CronDayOfMonthFormat();
48
        $this->validator->validate($value, $constraint);
49
        $this->assertNoViolation();
50
    }
51
52
    /**
53
     * @return array
54
     */
55
    public function getInvalidValues()
56
    {
57
        return [
58
            [-1],
59
            [0],
60
            [32],
61
            ['5,35'],
62
            ['3-35'],
63
            ['-1'],
64
            ['1-'],
65
            ['3,20-35'],
66
            ['1-10,20-45'],
67
            ['25/*'],
68
            ['2-10,25/*'],
69
            ['**'],
70
        ];
71
    }
72
73
    /**
74
     * @dataProvider getInvalidValues
75
     *
76
     * @param string $value
77
     */
78
    public function testInvalidValues($value)
79
    {
80
        $constraint = new CronDayOfMonthFormat();
81
        $this->validator->validate($value, $constraint);
82
        $this->buildViolation($constraint->message)
83
            ->setParameter('%string%', $value)
84
            ->assertRaised();
85
    }
86
}
87