XMLParser.__next__() - Code Metrics - Inspection of "Initial refactoring the import iteration routine" - FreeOpcUa/python-opcua - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#267)

unknown

created 2016-08-02 20:16 UTC

XMLParser.next() A

↳ Parent: Project

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
dl	0
loc	7
ccs	6
cts	6
cp	1
crap	3
rs	9.4285
c	1
b	0
f	0

"""
parse xml file from opcua-spec
"""
import logging
import re
import sys

import xml.etree.ElementTree as ET


class NodeData(object):

    def __init__(self):
        self.nodetype = None
        self.nodeid = None
        self.browsename = None
        self.displayname = None
        self.symname = None  # FIXME: this param is never used, why?
        self.parent = None
        self.parentlink = None
        self.desc = ""
        self.typedef = None
        self.refs = []
        self.nodeclass = None
        self.eventnotifier = 0

        # variable
        self.datatype = None
        self.rank = -1  # check default value
        self.value = None
        self.valuetype = None
        self.dimensions = None
        self.accesslevel = None
        self.useraccesslevel = None
        self.minsample = None

        # referencetype
        self.inversename = ""
        self.abstract = "false"
        self.symmetric = "false"

        # datatype
        self.definition = []


class RefStruct(object):

    def __init__(self):
        self.reftype = None
        self.forward = True
        self.target = None


class XMLParser(object):

    def __init__(self, xmlpath, server):
        self.server = server  # POC
        self.logger = logging.getLogger(__name__)
        self._retag = re.compile(r"(\{.*\})(.*)")
        self.path = xmlpath
        self.aliases = {}

        self.tree = ET.parse(xmlpath)
        self.root = self.tree.getroot()
        self.it = None

        self.namespaces = {}
        self._re_nodeid = re.compile(r"^ns=(?P<ns>\d+[^;]*);i=(?P<i>\d+)")

    def __iter__(self):
        items = []
        for child in self.root:
            name = self._retag.match(child.tag).groups()[1]
            if name == "Aliases":
                for el in child:
                    self.aliases[el.attrib["Alias"]] = self._get_node_id(el.text)
            elif name == 'NamespaceUris':
                for ns_index, ns_element in enumerate(child):
                    ns_uri = ns_element.text
                    ns_server_index = self.server.register_namespace(ns_uri)
                    self.namespaces[ns_index + 1] = (ns_server_index, ns_uri)
            else:
                node = self._parse_node(name, child)
                items.append(node)
        # here comes the logic for ordering
        # TBD
        self.it = iter(items)
        return self

    def __next__(self):
        while True:
            if sys.version_info[0] < 3:
                child = self.it.next()
            else:
                child = self.it.__next__()
            return child

    def next(self):  # support for python2
        return self.__next__()

    def _get_node_id(self, value):
        """
        Check if the nodeid given in the xml model file must be converted
        to a already existing namespace id based on the files namespace uri

        :returns: NodeId (str)
        """
        result = value
        r_match = self._re_nodeid.search(value)
        if r_match:
            node_ns, node_id = r_match.groups()
            ns_server = self.namespaces.get(int(node_ns), None)
            if ns_server:
                result = "ns={};i={}".format(ns_server[0], node_id)
        return result

    def _parse_node(self, name, child):
        obj = NodeData()
        obj.nodetype = name
        for key, val in child.attrib.items():
            self._set_attr(key, val, obj)
        obj.displayname = obj.browsename  # give a default value to display name
        for el in child:
            self._parse_tag(el, obj)
        return obj

    def _set_attr(self, key, val, obj):
        if key == "NodeId":
            obj.nodeid = self._get_node_id(val)
        elif key == "BrowseName":
            obj.browsename = val
        elif key == "SymbolicName":
            obj.symname = val
        elif key == "ParentNodeId":
            obj.parent = self._get_node_id(val)
        elif key == "DataType":
            obj.datatype = val
        elif key == "IsAbstract":
            obj.abstract = val
        elif key == "EventNotifier":
            obj.eventnotifier = 1 if val == "1" else 0
        elif key == "ValueRank":
            obj.rank = int(val)
        elif key == "ArrayDimensions":
            obj.dimensions = [int(i) for i in val.split(",")]
        elif key == "MinimumSamplingInterval":
            obj.minsample = int(val)
        elif key == "AccessLevel":
            obj.accesslevel = int(val)
        elif key == "UserAccessLevel":
            obj.useraccesslevel = int(val)
        elif key == "Symmetric":
            obj.symmetric = True if val == "true" else False
        else:
            self.logger.info("Attribute not implemented: %s:%s", key, val)

    def _parse_tag(self, el, obj):
        tag = self._retag.match(el.tag).groups()[1]

        if tag == "DisplayName":
            obj.displayname = el.text
        elif tag == "Description":
            obj.desc = el.text
        elif tag == "References":
            self._parse_refs(el, obj)
        elif tag == "Value":
            self._parse_value(el, obj)
        elif tag == "InverseName":
            obj.inversename = el.text
        elif tag == "Definition":
            for field in el:
                obj.definition.append(field)
        else:
            self.logger.info("Not implemented tag: %s", el)

    def _parse_value(self, el, obj):
        for val in el:
            ntag = self._retag.match(val.tag).groups()[1]
            obj.valuetype = ntag
            if ntag in ("Int8", "UInt8", "Int16", "UInt16", "Int32", "UInt32", "Int64", "UInt64"):
                obj.value = int(val.text)
            elif ntag in ("Float", "Double"):
                obj.value = float(val.text)
            elif ntag in ("Boolean"):
                if val.text in ("True", "true", "1", "on", "On"):
                    obj.value = bool(1)
                else:
                    obj.value = bool(0)
            elif ntag in ("ByteString", "String"):
                mytext = val.text
                if mytext is None:  # support importing null strings
                    mytext = ""
                mytext = mytext.replace('\n', '').replace('\r', '')
                # obj.value.append('b"{}"'.format(mytext))
                obj.value = mytext
            elif ntag == "ListOfExtensionObject":
                obj.value, obj.valuetype = self._parse_list_of_extension_object(el)
            elif ntag == "ListOfLocalizedText":
                obj.value = self._parse_list_of_localized_text(el)
            else:
                self.logger.info("Value type not implemented: %s", ntag)

    def _get_text(self, el):
        txt = ""
        for text in el.itertext():
            txt += text
        return txt

    def _parse_list_of_localized_text(self, el):
        value = []
        for localized_text_list in el:
            for localized_text in localized_text_list:
                ntag = self._retag.match(localized_text.tag).groups()[1]
                for child in localized_text:
                    ntag = self._retag.match(child.tag).groups()[1]
                    if ntag == 'Text':
                        value.append(self._get_text(child))
        return value

    def _parse_list_of_extension_object(self, el):
        '''
        Parse a uax:ListOfExtensionObject Value
        
        Return an array with a value of each uax:ExtensionObject/*/* (each element is convert to a netry in a dict.
               also the valuetype is returned. The valuetype is  uax:ExtensionObject/*/tag()
        '''
        value = []
        valuetype = None
        for extension_object_list in el:
            for extension_object in extension_object_list:
                extension_object.find('Body')
                for extension_object_part in extension_object:
                    ntag = self._retag.match(extension_object_part.tag).groups()[1]
                    if ntag == 'Body':
                        data = {}
                        ntag = self._retag.match(extension_object_part.find('*').tag).groups()[1]
                        valuetype = ntag
                        for body_item in extension_object_part.findall('*/*'):
                            ntag = self._retag.match(body_item.tag).groups()[1]

                            child = body_item.find('*')
                            if child is not None:
                                data[ntag] = self._get_text(child)
                            else:
                                data[ntag] = self._get_text(body_item)
                        value.append(data)
        return value, valuetype

    def _parse_refs(self, el, obj):
        for ref in el:
            if ref.attrib["ReferenceType"] == "HasTypeDefinition":
                obj.typedef = self._get_node_id(ref.text)
            elif "IsForward" in ref.attrib and ref.attrib["IsForward"] == "false":
                # if obj.parent:
                    # sys.stderr.write("Parent is already set with: "+ obj.parent + " " + ref.text + "\n")
                obj.parent = self._get_node_id(ref.text)
                obj.parentlink = ref.attrib["ReferenceType"]
            else:
                struct = RefStruct()
                if "IsForward" in ref.attrib:
                    struct.forward = ref.attrib["IsForward"]
                struct.target = self._get_node_id(ref.text)
                struct.reftype = ref.attrib["ReferenceType"]
                obj.refs.append(struct)


1		"""
2		parse xml file from opcua-spec
3		"""
4	1	import logging
5	1	import re
6	1	import sys
7
8	1	import xml.etree.ElementTree as ET
9
10
11	1	class NodeData(object):
12
13	1	def __init__(self):
14	1	self.nodetype = None
15	1	self.nodeid = None
16	1	self.browsename = None
17	1	self.displayname = None
18	1	self.symname = None # FIXME: this param is never used, why?
19	1	self.parent = None
20	1	self.parentlink = None
21	1	self.desc = ""
22	1	self.typedef = None
23	1	self.refs = []
24	1	self.nodeclass = None
25	1	self.eventnotifier = 0
26
27		# variable
28	1	self.datatype = None
29	1	self.rank = -1 # check default value
30	1	self.value = None
31	1	self.valuetype = None
32	1	self.dimensions = None
33	1	self.accesslevel = None
34	1	self.useraccesslevel = None
35	1	self.minsample = None
36
37		# referencetype
38	1	self.inversename = ""
39	1	self.abstract = "false"
40	1	self.symmetric = "false"
41
42		# datatype
43	1	self.definition = []
44
45
46	1	class RefStruct(object):
47
48	1	def __init__(self):
49		self.reftype = None
50		self.forward = True
51		self.target = None
52
53
54	1	class XMLParser(object):
55
56	1	def __init__(self, xmlpath, server):
57	1	self.server = server # POC
58	1	self.logger = logging.getLogger(__name__)
59	1	self._retag = re.compile(r"(\{.\})(.)")
60	1	self.path = xmlpath
61		self.aliases = {}
62	1
63	1	self.tree = ET.parse(xmlpath)
64	1	self.root = self.tree.getroot()
65		self.it = None
66	1
67	1	self.namespaces = {}
68	1	self._re_nodeid = re.compile(r"^ns=(?P<ns>\d+[^;]*);i=(?P<i>\d+)")
69
70	1	def __iter__(self):
71	1	items = []
72	1	for child in self.root:
73		name = self._retag.match(child.tag).groups()[1]
74		if name == "Aliases":
75	1	for el in child:
76	1	self.aliases[el.attrib["Alias"]] = self._get_node_id(el.text)
77	1	elif name == 'NamespaceUris':
78		for ns_index, ns_element in enumerate(child):
79		ns_uri = ns_element.text
80		ns_server_index = self.server.register_namespace(ns_uri)
81	1	self.namespaces[ns_index + 1] = (ns_server_index, ns_uri)
82	1	else:
83		node = self._parse_node(name, child)
84	1	items.append(node)
85		# here comes the logic for ordering
86		# TBD
87	1	self.it = iter(items)
88	1	return self
89	1
90	1	def __next__(self):
91	1	while True:
92	1	if sys.version_info[0] < 3:
93	1	child = self.it.next()
94	1	else:
95	1	child = self.it.__next__()
96		return child
97	1
98	1	def next(self): # support for python2
99	1	return self.__next__()
100	1
101	1	def _get_node_id(self, value):
102	1	"""
103		Check if the nodeid given in the xml model file must be converted
104	1	to a already existing namespace id based on the files namespace uri
105
106	1	:returns: NodeId (str)
107	1	"""
108		result = value
109		r_match = self._re_nodeid.search(value)
110		if r_match:
111		node_ns, node_id = r_match.groups()
112		ns_server = self.namespaces.get(int(node_ns), None)
113		if ns_server:
114		result = "ns={};i={}".format(ns_server[0], node_id)
115		return result
116
117		def _parse_node(self, name, child):
118		obj = NodeData()
119		obj.nodetype = name
120		for key, val in child.attrib.items():
121		self._set_attr(key, val, obj)
122		obj.displayname = obj.browsename # give a default value to display name
123		for el in child:
124		self._parse_tag(el, obj)
125		return obj
126
127		def _set_attr(self, key, val, obj):
128	1	if key == "NodeId":
129	1	obj.nodeid = self._get_node_id(val)
130		elif key == "BrowseName":
131	1	obj.browsename = val
132		elif key == "SymbolicName":
133	1	obj.symname = val
134	1	elif key == "ParentNodeId":
135	1	obj.parent = self._get_node_id(val)
136	1	elif key == "DataType":
137	1	obj.datatype = val
138	1	elif key == "IsAbstract":
139		obj.abstract = val
140		elif key == "EventNotifier":
141		obj.eventnotifier = 1 if val == "1" else 0
142		elif key == "ValueRank":
143		obj.rank = int(val)
144		elif key == "ArrayDimensions":
145		obj.dimensions = [int(i) for i in val.split(",")]
146		elif key == "MinimumSamplingInterval":
147	1	obj.minsample = int(val)
148	1	elif key == "AccessLevel":
149	1	obj.accesslevel = int(val)
150	1	elif key == "UserAccessLevel":
151	1	obj.useraccesslevel = int(val)
152	1	elif key == "Symmetric":
153	1	obj.symmetric = True if val == "true" else False
154		else:
155	1	self.logger.info("Attribute not implemented: %s:%s", key, val)
156
157		def _parse_tag(self, el, obj):
158		tag = self._retag.match(el.tag).groups()[1]
159
160	1	if tag == "DisplayName":
161	1	obj.displayname = el.text
162	1	elif tag == "Description":
163		obj.desc = el.text
164	1	elif tag == "References":
165		self._parse_refs(el, obj)
166	1	elif tag == "Value":
167		self._parse_value(el, obj)
168		elif tag == "InverseName":
169		obj.inversename = el.text
170		elif tag == "Definition":
171		for field in el:
172		obj.definition.append(field)
173		else:
174	1	self.logger.info("Not implemented tag: %s", el)
175	1
176	1	def _parse_value(self, el, obj):
177	1	for val in el:
178	1	ntag = self._retag.match(val.tag).groups()[1]
179		obj.valuetype = ntag
180		if ntag in ("Int8", "UInt8", "Int16", "UInt16", "Int32", "UInt32", "Int64", "UInt64"):
181	1	obj.value = int(val.text)
182	1	elif ntag in ("Float", "Double"):
183		obj.value = float(val.text)
184		elif ntag in ("Boolean"):
185		if val.text in ("True", "true", "1", "on", "On"):
186		obj.value = bool(1)
187		else:
188		obj.value = bool(0)
189		elif ntag in ("ByteString", "String"):
190		mytext = val.text
191		if mytext is None: # support importing null strings
192		mytext = ""
193		mytext = mytext.replace('\n', '').replace('\r', '')
194		# obj.value.append('b"{}"'.format(mytext))
195		obj.value = mytext
196		elif ntag == "ListOfExtensionObject":
197		obj.value, obj.valuetype = self._parse_list_of_extension_object(el)
198		elif ntag == "ListOfLocalizedText":
199		obj.value = self._parse_list_of_localized_text(el)
200		else:
201		self.logger.info("Value type not implemented: %s", ntag)
202
203		def _get_text(self, el):
204		txt = ""
205		for text in el.itertext():
206		txt += text
207		return txt
208
209		def _parse_list_of_localized_text(self, el):
210		value = []
211		for localized_text_list in el:
212		for localized_text in localized_text_list:
213		ntag = self._retag.match(localized_text.tag).groups()[1]
214		for child in localized_text:
215		ntag = self._retag.match(child.tag).groups()[1]
216		if ntag == 'Text':
217		value.append(self._get_text(child))
218		return value
219
220		def _parse_list_of_extension_object(self, el):
221		'''
222		Parse a uax:ListOfExtensionObject Value
223
224		Return an array with a value of each uax:ExtensionObject// (each element is convert to a netry in a dict.
225		also the valuetype is returned. The valuetype is uax:ExtensionObject/*/tag()
226		'''
227		value = []
228		valuetype = None
229		for extension_object_list in el:
230		for extension_object in extension_object_list:
231		extension_object.find('Body')
232		for extension_object_part in extension_object:
233		ntag = self._retag.match(extension_object_part.tag).groups()[1]
234		if ntag == 'Body':
235		data = {}
236		ntag = self._retag.match(extension_object_part.find('*').tag).groups()[1]
237		valuetype = ntag
238		for body_item in extension_object_part.findall('/'):
239		ntag = self._retag.match(body_item.tag).groups()[1]
240
241		child = body_item.find('*')
242		if child is not None:
243		data[ntag] = self._get_text(child)
244		else:
245		data[ntag] = self._get_text(body_item)
246		value.append(data)
247		return value, valuetype
248
249		def _parse_refs(self, el, obj):
250		for ref in el:
251		if ref.attrib["ReferenceType"] == "HasTypeDefinition":
252		obj.typedef = self._get_node_id(ref.text)
253		elif "IsForward" in ref.attrib and ref.attrib["IsForward"] == "false":
254		# if obj.parent:
255		# sys.stderr.write("Parent is already set with: "+ obj.parent + " " + ref.text + "\n")
256		obj.parent = self._get_node_id(ref.text)
257		obj.parentlink = ref.attrib["ReferenceType"]
258		else:
259		struct = RefStruct()
260		if "IsForward" in ref.attrib:
261		struct.forward = ref.attrib["IsForward"]
262		struct.target = self._get_node_id(ref.text)
263		struct.reftype = ref.attrib["ReferenceType"]
264		obj.refs.append(struct)
265

FreeOpcUa / python-opcua

Pull Request — master (#267)

XMLParser.__next__() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

XMLParser.next() A