| Total Complexity | 13 |
| Total Lines | 88 |
| Duplicated Lines | 27.27 % |
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | import time |
||
| 17 | class HistoryCommon(object): |
||
| 18 | srv = Server |
||
| 19 | clt = Client |
||
| 20 | |||
| 21 | def start_server_and_client(self): |
||
| 22 | self.srv = Server() |
||
| 23 | self.srv.set_endpoint('opc.tcp://localhost:%d' % port_num1) |
||
| 24 | self.srv.start() |
||
| 25 | |||
| 26 | self.clt = Client('opc.tcp://localhost:%d' % port_num1) |
||
| 27 | self.clt.connect() |
||
| 28 | |||
| 29 | def stop_server_and_client(self): |
||
| 30 | self.clt.disconnect() |
||
| 31 | self.srv.stop() |
||
| 32 | |||
| 33 | def create_var(self): |
||
| 34 | o = self.srv.get_objects_node() |
||
| 35 | self.values = [i for i in range(20)] |
||
| 36 | self.var = o.add_variable(3, "history_var", 0) |
||
| 37 | self.srv.iserver.enable_history(self.var, period=None, count=10) |
||
| 38 | for i in self.values: |
||
| 39 | self.var.set_value(i) |
||
| 40 | time.sleep(1) |
||
| 41 | |||
| 42 | def test_history_read_one(self): |
||
| 43 | res = self.var.read_raw_history(None, None, 1) |
||
| 44 | self.assertEqual(len(res), 1) |
||
| 45 | self.assertEqual(res[0].Value.Value, self.values[-1]) |
||
| 46 | |||
| 47 | # no start and no end is not defined by spec, return reverse order |
||
| 48 | def test_history_read_none(self): |
||
| 49 | # FIXME not sure this once is supported by spec |
||
| 50 | res = self.var.read_raw_history(None, None, 0) |
||
| 51 | self.assertEqual(len(res), 20) |
||
| 52 | self.assertEqual(res[0].Value.Value, self.values[-1]) # self.values was 0 |
||
| 53 | self.assertEqual(res[-1].Value.Value, self.values[0]) # self.values was -1 |
||
| 54 | |||
| 55 | # no start and no end is not defined by spec, return reverse order |
||
| 56 | def test_history_read_last_3(self): |
||
| 57 | res = self.var.read_raw_history(None, None, 3) |
||
| 58 | self.assertEqual(len(res), 3) |
||
| 59 | self.assertEqual(res[-1].Value.Value, self.values[-3]) # self.values was -1 |
||
| 60 | self.assertEqual(res[0].Value.Value, self.values[-1]) # self.values was -3 |
||
| 61 | |||
| 62 | # no start and no end is not defined by spec, return reverse order |
||
| 63 | def test_history_read_all2(self): |
||
| 64 | res = self.var.read_raw_history(None, None, 9999) |
||
| 65 | self.assertEqual(len(res), 20) |
||
| 66 | self.assertEqual(res[-1].Value.Value, self.values[0]) # self.values was -1 |
||
| 67 | self.assertEqual(res[0].Value.Value, self.values[-1]) # self.values was 0 |
||
| 68 | |||
| 69 | # only has end time, should return reverse order |
||
| 70 | def test_history_read_2_with_end(self): |
||
| 71 | now = datetime.utcnow() |
||
| 72 | old = now - timedelta(days=6) |
||
| 73 | |||
| 74 | res = self.var.read_raw_history(None, now, 2) |
||
| 75 | self.assertEqual(len(res), 2) |
||
| 76 | self.assertEqual(res[-1].Value.Value, self.values[-2]) # self.values was -1 |
||
| 77 | |||
| 78 | View Code Duplication | def test_history_read_all(self): |
|
|
|
|||
| 79 | now = datetime.utcnow() |
||
| 80 | old = now - timedelta(days=6) |
||
| 81 | |||
| 82 | res = self.var.read_raw_history(old, now, 0) |
||
| 83 | self.assertEqual(len(res), 20) |
||
| 84 | self.assertEqual(res[-1].Value.Value, self.values[-1]) |
||
| 85 | self.assertEqual(res[0].Value.Value, self.values[0]) |
||
| 86 | |||
| 87 | View Code Duplication | def test_history_read_5_in_timeframe(self): |
|
| 88 | now = datetime.utcnow() |
||
| 89 | old = now - timedelta(days=6) |
||
| 90 | |||
| 91 | res = self.var.read_raw_history(old, now, 5) |
||
| 92 | self.assertEqual(len(res), 5) |
||
| 93 | self.assertEqual(res[-1].Value.Value, self.values[4]) |
||
| 94 | self.assertEqual(res[0].Value.Value, self.values[0]) |
||
| 95 | |||
| 96 | # start time greater than end time, should return reverse order |
||
| 97 | View Code Duplication | def test_history_read_5_in_timeframe_start_greater_than_end(self): |
|
| 98 | now = datetime.utcnow() |
||
| 99 | old = now - timedelta(days=6) |
||
| 100 | |||
| 101 | res = self.var.read_raw_history(now, old, 5) |
||
| 102 | self.assertEqual(len(res), 5) |
||
| 103 | self.assertEqual(res[-1].Value.Value, self.values[-5]) |
||
| 104 | self.assertEqual(res[0].Value.Value, self.values[-1]) |
||
| 105 | |||
| 140 |